Re: [sr-dev] [kamailio/kamailio] warning cleanup (#2298)

2020-05-02 Thread Daniel-Constantin Mierla
Closed #2298. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2298#event-3296764892___ Kamailio (SER) - Development Mailing List sr-dev@l

Re: [sr-dev] [kamailio/kamailio] warning cleanup (#2298)

2020-05-02 Thread Daniel-Constantin Mierla
Closing, commits were also backported to 5.3. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2298#issuecomment-623005705___ Kamailio (SE

Re: [sr-dev] [kamailio/kamailio] set_contact_alias() issue with clients adding it to their Contact (#2308)

2020-05-02 Thread Daniel-Constantin Mierla
set_contact_alias() should not be used for registrations, but for requests that are typically forwarded. If you do it on an edge proxy between device and registrar server, then you should use path module and leave the contact unchanged. If you use it in the registrar server config, then you sho

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-05-02 Thread Daniel-Constantin Mierla
Closed #2294. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2294#event-3296751120___ Kamailio (SER) - Development Mailing List sr-dev@l

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-05-02 Thread Daniel-Constantin Mierla
Closing based on a few days running without issues. From now on newly discovered bugs can get a dedicated issue on this tracker. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/229

Re: [sr-dev] json request fails

2020-05-02 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > I pushed a fix for it (not tested) -- it was the new siptrace mode > trying to save to database using core callbacks and not checking it is > sip traffic or not. The errors were for the http traffic. Thanks, the error messages are now gone. -- Juha ___

[sr-dev] json request fails

2020-05-02 Thread Juha Heinanen
This is the config command that my SIP proxy executes on the incoming JSON over HTTP request: jsonrpc_dispatch(); -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinf

[sr-dev] json request fails

2020-05-02 Thread Juha Heinanen
Juha Heinanen writes: > I noticed that json rpc commands have started to fail, for example, Actually, the commands still work even when error messages are produced. -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https:

[sr-dev] json request fails

2020-05-02 Thread Juha Heinanen
I noticed that json rpc commands have started to fail, for example, May 2 15:41:15 char /usr/bin/sip-proxy[10440]: INFO: Executing JSON request <{"jsonrpc":"2.0","method":"siptrace.status","params":["on"],"id":1}> from <127.0.0.1> with host <127.0.0.1:6060> May 2 15:41:15 char /usr/bin/sip-pro

Re: [sr-dev] undefined symbol: ul_cseq_delay

2020-05-02 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > It was introduced by my previous commit. I pushed the fix for it. OK, thanks, running now. -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/li

[sr-dev] undefined symbol: ul_cseq_delay

2020-05-02 Thread Juha Heinanen
I build my sip proxy from today's master and it didn't start: May 2 15:12:51 char sip-proxy[22422]: 0(22474) ERROR: [core/sr_module.c:512]: load_module(): could not open module : /usr/lib/x86_64-linux-gnu/sip-proxy/modules/usrloc.so: undefined symbol: ul_cseq_delay -- Juha ___

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Merged #2304 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#event-3296066480___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Thanks Daniel, documentation added to the wiki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#issuecomment-622961098___ Kamailio (SE

[sr-dev] git:master:f6c68817: Merge pull request #2304 from kamailio/grumvalski/usrloc_stats

2020-05-02 Thread GitHub
Module: kamailio Branch: master Commit: f6c688178902138dff8115cdabd72e8631a635dc URL: https://github.com/kamailio/kamailio/commit/f6c688178902138dff8115cdabd72e8631a635dc Author: Federico Cabiddu Committer: GitHub Date: 2020-05-02T16:22:06+02:00 Merge pull request #2304 from kamailio/grumvalsk

[sr-dev] git:master:3203a657: core: new core parameter stats_name_separator

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 3203a6572b874d191c3be61519853005bd5ab056 URL: https://github.com/kamailio/kamailio/commit/3203a6572b874d191c3be61519853005bd5ab056 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-05-01T13:02:39+02:00 core: new core parameter stats_name_se

[sr-dev] git:master:9948696f: core: remove stats_name_separator from cfg_group_core

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 9948696fd84605919e6ce6a7106099f1cdd0de98 URL: https://github.com/kamailio/kamailio/commit/9948696fd84605919e6ce6a7106099f1cdd0de98 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-05-02T10:14:23+02:00 core: remove stats_name_separator from

[sr-dev] git:master:0595795c: ims_usrloc_pcscf, p_usrloc, usrloc: use KSR_STATS_NAMESEP for stats names

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 0595795c659f6af586e63837efe56b45808cd735 URL: https://github.com/kamailio/kamailio/commit/0595795c659f6af586e63837efe56b45808cd735 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T16:24:24+02:00 ims_usrloc_pcscf, p_usrloc, usrloc: us

[sr-dev] git:master:ddd27713: usrloc: change "-" for "_" in stats name to be prometheus compliant

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: ddd277139165f39406832ddd557c2b56b75a7100 URL: https://github.com/kamailio/kamailio/commit/ddd277139165f39406832ddd557c2b56b75a7100 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T10:24:04+02:00 usrloc: change "-" for "_" in stats na

[sr-dev] git:master:4357b5e6: core: define KSR_STATS_NAMESEP for stats name separator

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 URL: https://github.com/kamailio/kamailio/commit/4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T16:22:40+02:00 core: define KSR_STATS_NAMESEP for sta

[sr-dev] git:master:2fe0378c: p_usrloc, ims_usrloc_pcscf: change "-" for "_" in stats name to be prometheus compliant

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 URL: https://github.com/kamailio/kamailio/commit/2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T14:48:59+02:00 p_usrloc, ims_usrloc_pcscf: change "-"

Re: [sr-dev] json request fails

2020-05-02 Thread Daniel-Constantin Mierla
I pushed a fix for it (not tested) -- it was the new siptrace mode trying to save to database using core callbacks and not checking it is sip traffic or not. The errors were for the http traffic. Cheers, Daniel On 02.05.20 15:02, Juha Heinanen wrote: > This is the config command that my SIP proxy

[sr-dev] git:master:c840fa6e: siptrace: skip non-sip traffic for db storage using core callbacks

2020-05-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: c840fa6eb19b4b5d316e36ce534f4d481805ee0b URL: https://github.com/kamailio/kamailio/commit/c840fa6eb19b4b5d316e36ce534f4d481805ee0b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2020-05-02T15:02:55+02:00 siptrace: skip non-sip

Re: [sr-dev] undefined symbol: ul_cseq_delay

2020-05-02 Thread Daniel-Constantin Mierla
It was introduced by my previous commit. I pushed the fix for it. Cheers, Daniel On 02.05.20 14:15, Juha Heinanen wrote: > I build my sip proxy from today's master and it didn't start: > > May 2 15:12:51 char sip-proxy[22422]: 0(22474) ERROR: > [core/sr_module.c:512]: load_module(): could not

[sr-dev] git:master:d515c93a: usrloc: fixed missing symbol for ul_cseq_delay

2020-05-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: d515c93a5c9c9eb920f001d04870dc6333ca60dd URL: https://github.com/kamailio/kamailio/commit/d515c93a5c9c9eb920f001d04870dc6333ca60dd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2020-05-02T14:29:53+02:00 usrloc: fixed missing

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Daniel-Constantin Mierla
OK to merge it. Do not forget to add docs in the core cookbook wiki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#issuecomment-622938364___

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Right, I realized after doing it. I've pushed the new suggest implementation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#issuecomment-622852013__

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 9948696fd84605919e6ce6a7106099f1cdd0de98 core: remove stats_name_separator from cfg_group_core -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2304/files/3203a6572b874d191c3be6151985

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Daniel-Constantin Mierla
@grumvalski - I think it makes no sense to added to the `cfg_group_core / default_core_cfg` structure, because that is for parameters that can be changed at runtime. But, imo, this is not set once and actually use only during startup, when the stats names are exported. It can simply be a global