@wkampich pushed 1 commit.
b458bbcba00cd6678617f004bbdeff2a1b0c524d lost: memory leak fix and code
refactoring
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2675/files/25378c0388bb4365e8d4f1a4e874381fe339cd3b.
@wkampich commented on this pull request.
> +#define PATH_NODE (const char *)"via"
+#define PATH_NODE_VIA (const char *)"via"
+#define MAPP_NODE (const char *)"mapping"
+#define MAPP_NODE_URI (const char *)"uri"
+#define MAPP_PROP_EXP (const char *)"expires"
+#define MAPP_PROP_LUP (const char *)
@wkampich: lost_copy_string() is not a significant amount of code to replace
with pkg_str_dup(), the signature is different as well -- overall, it could be
good, but not a must. If you fix the leak, the PR should be ready to merge.
--
You are receiving this because you are subscribed to this th
@wkampich commented on this pull request.
> + goto err;
+ }
+ /* clean up */
+ tmp.s = NULL;
+
@wkampich commented on this pull request.
> + tmp.len =
> strlen(fsrdata->mapping->name->text);
+ name.s = lost_copy_string(tmp,
&name.len);
+ }
+
@wkampich commented on this pull request.
> + case RESPONSE:
+ if(fsrdata->uri != NULL) {
+ /* get the first uri element */
+ if((tmp.s = fsrdata->uri->value) !=
NULL) {
@wkampich commented on this pull request.
> -
- /* get the error patterm */
- err.s = lost_get_childname(root, errors_element, &err.len);
- LM_DBG("findService error response: [%.*s]\n", err.len, err.s);
- if(err.len == 0) {
-
@wkampich commented on this pull request.
> + if(rtp.len == 0) {
+ LM_WARN("no response type found\n");
+ rtype = NULL;
+ } else {
+ len = 0;
+ /* response type string sanity check *
@wkampich commented on this pull request.
> + if(oldurl.s != NULL &&
> oldurl.len > 0) {
+ if(str_strcasecmp(&url,
&oldurl) == 0) {
+
@wkampich commented on this pull request.
> LM_ERR("lost request failed\n");
goto err;
}
LM_DBG("findService request: [%.*s]\n", req.len, req.s);
/* send findService request to mapping server - HTTP POST */
- curlres = httpapi.http_
@wkampich commented on this pull request.
> +
+ /* clean up */
+ if(rtype != NULL) {
+ pkg_free(rtype);
+ }
+
+ if(heldreq != NULL && len == 0) {
+ LM_ERR("could not create POST request\n");
+ goto err;
+ }
+
+ LM_DBG(
@wkampich commented on this pull request.
> + lost_free_string(&idhdr);
+ goto err;
+ }
+ } else {
+ LM_ERR("failed to get location service for [%.*s]\n",
did.len,
+
@wkampich commented on this pull request.
> + /* send via connection */
+ curl = httpapi.http_connect(_m, &con, NULL, &res, mtheld, &que);
+ } else {
+ /* we have no connection ... do a NAPTR lookup */
+ if(lost_parse_host(did.s, &host,
@wkampich commented on this pull request.
>
pkg_free(ptr);
- ptr = NULL;
+ *held = NULL;
+}
+
+/*
+ * lost_copy_string(str, int*) {
yes true `pkg_str_dup(..)` would be an option; basically I only use the
function when a pointer to a string is necessary and requires zero t
Module: kamailio
Branch: master
Commit: 5a96993efd6cff7677a5c49fee15c30715903ea0
URL:
https://github.com/kamailio/kamailio/commit/5a96993efd6cff7677a5c49fee15c30715903ea0
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-04-01T00:01:22+02:00
topos: use context for
Module: kamailio
Branch: master
Commit: 5c2699c4f6a9e8a24057b754e6510433129f509d
URL:
https://github.com/kamailio/kamailio/commit/5c2699c4f6a9e8a24057b754e6510433129f509d
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T23:55:51+02:00
core: sruid - use spec
Closed #2125.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2125#event-4536210145___
Kamailio (SER) - Development Mailing List
sr-dev@l
Closing as no devs to implement.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2125#issuecomment-811273926___
Kamailio (SER) - Developm
Module: kamailio
Branch: master
Commit: 858fab6bbf0c26f22bb9411e9385c10d654a6da5
URL:
https://github.com/kamailio/kamailio/commit/858fab6bbf0c26f22bb9411e9385c10d654a6da5
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T21:59:51+02:00
topos: ability to exec
Module: kamailio
Branch: master
Commit: 4eae7ee7819c528297e24778ae480d3a2e0a8188
URL:
https://github.com/kamailio/kamailio/commit/4eae7ee7819c528297e24778ae480d3a2e0a8188
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T21:46:14+02:00
topos: option to set a
Module: kamailio
Branch: master
Commit: 3363d4671e9dcb68bf182f9eae708ca55c71
URL:
https://github.com/kamailio/kamailio/commit/3363d4671e9dcb68bf182f9eae708ca55c71
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T21:45:14+02:00
kamctl: db schema rege
Module: kamailio
Branch: master
Commit: e6609d4041f9bc74b68fe83b67ba4499e8fb1924
URL:
https://github.com/kamailio/kamailio/commit/e6609d4041f9bc74b68fe83b67ba4499e8fb1924
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T21:44:12+02:00
lib: srdb1 - added x_c
@jchavanton pushed 1 commit.
0a293fdbe2dfe1ac4741e0a1aec0495de3d3b900 acc_json: param to accept pre-encoded
json values
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2699/files/934125304d8f156f17007c53d69cd547
This is pretty old, if no dev plans to work on it, then it will be closed soon.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2125#issuecomment-811106706__
Closed #2387.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2387#event-4535082816___
Kamailio (SER) - Development Mailing List
sr-dev@l
Added explicit notes about 1-based index in textopsx docs.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2387#issuecomment-811105390___
Closed #2591.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2591#event-4534933408___
Kamailio (SER) - Development Mailing List
sr-dev@l
I added the function `tls_set_connect_server_id(srvid)` in tls module trying to
cover this kind of need to specify the server id for next tls connect in the
event_route[tm:local-request], where you can set its value from the dispatcher
route attributes.
Testing and feedback would be appreciated
I added the function `tls_set_connect_server_id(srvid)` in tls module trying to
cover this kind of need to specify the server id for next tls connect. Testing
and feedback would be appreciated. I am closing this issue, in case of a
problems, open a new one reporting what happens.
--
You are re
Closed #2413.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2413#event-4534915332___
Kamailio (SER) - Development Mailing List
sr-dev@l
Closed #2652.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2652#event-4534568033___
Kamailio (SER) - Development Mailing List
sr-dev@l
Closing it, support for SUBSCRIBE handling was added by #2662. If there is any
problem with that approach, open an issue with details about what is not
working with the current version of the module in master branch.
--
You are receiving this because you are subscribed to this thread.
Reply to
Module: kamailio
Branch: master
Commit: ac60e5d0a9f847fe77458d733d6ca67c9352978d
URL:
https://github.com/kamailio/kamailio/commit/ac60e5d0a9f847fe77458d733d6ca67c9352978d
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2021-03-31T16:16:15+02:00
modules: readme files regenerated - textopsx .
Module: kamailio
Branch: master
Commit: 6379f1280ba41e87ddb34fa1705ffe4231dcac9c
URL:
https://github.com/kamailio/kamailio/commit/6379f1280ba41e87ddb34fa1705ffe4231dcac9c
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T16:06:31+02:00
textopsx: docs - notes
Module: kamailio
Branch: master
Commit: 47e9a74bbe48025d238b85eac9ba5ed183f70667
URL:
https://github.com/kamailio/kamailio/commit/47e9a74bbe48025d238b85eac9ba5ed183f70667
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2021-03-31T16:01:16+02:00
modules: readme files regenerated - tls ... [s
Module: kamailio
Branch: master
Commit: c9702415579b8c7c2eb525accc909a586c17c2d1
URL:
https://github.com/kamailio/kamailio/commit/c9702415579b8c7c2eb525accc909a586c17c2d1
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2021-03-31T13:58:40Z
topos: add functionality to set a varia
Module: kamailio
Branch: master
Commit: 4edb9b27aa5cf8e39cb87c78557391445952b21c
URL:
https://github.com/kamailio/kamailio/commit/4edb9b27aa5cf8e39cb87c78557391445952b21c
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T15:51:04+02:00
tls: docs for tls_set_
Module: kamailio
Branch: master
Commit: e979a341c1b142bb02da25c7753e7efb2d34e80a
URL:
https://github.com/kamailio/kamailio/commit/e979a341c1b142bb02da25c7753e7efb2d34e80a
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T15:44:41+02:00
tls: added tls_set_con
Good point @miconda regarding the zero termination, then of course one needs to
do a copy. The license topic is of course valid as well, the original author of
the enum code is Juha.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Moving code to the core from existing module must ensure it can be relocated
under BSD license.
Regarding the cloning of some str values, they seem to be required due to used
functions that require zero-terminated strings, like ipstr that is passed to
lost_get_nameinfo(), which is using libc in
Closed #2617.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2617#event-4532899105___
Kamailio (SER) - Development Mailing List
sr-dev@lis
In master, see #2615.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2617#issuecomment-810869265___
Kamailio (SER) - Development Mailing L
Closed #2615.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2615#event-4532892041___
Kamailio (SER) - Development Mailing List
sr-dev@l
Added in master branch (to be in 5.5 series) -- see the docs for
attribute_display parameter.
Testing and feedback would be appreciated, if it works as expected or not.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https:
@henningw commented on this pull request.
Thanks for the update. I just did a quick review, focus on the usual string
handling and memory allocation topics.
>
pkg_free(ptr);
- ptr = NULL;
+ *held = NULL;
+}
+
+/*
+ * lost_copy_string(str, int*) {
Have you considered using
All good. Thanks for fixing!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2675#issuecomment-810817098___
Kamailio (SER) - Development Ma
Merged #2676 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2676#event-4532354520___
Kamailio (SER) - Development Mailing Lis
Thanks, merging.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2676#issuecomment-810808466___
Kamailio (SER) - Development Mailing List
s
Code duplication was removed for http client module. I guess this can be
merged, if no other opinions against.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2675#issuecomment-81080
It can be merged from my point of view.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2699#issuecomment-810803783___
Kamailio (SER) - Dev
Module: kamailio
Branch: master
Commit: 30cb2e4ec263e182e0726b217086135de2e2520c
URL:
https://github.com/kamailio/kamailio/commit/30cb2e4ec263e182e0726b217086135de2e2520c
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2021-03-31T12:01:18+02:00
modules: readme files regenerated - http_async
Module: kamailio
Branch: master
Commit: 14a399652bb813f77da13956eb47e1f16c5d6b8f
URL:
https://github.com/kamailio/kamailio/commit/14a399652bb813f77da13956eb47e1f16c5d6b8f
Author: gled
Committer: gled
Date: 2021-03-26T17:17:09-07:00
http_async_client: add curl_follow_redirect parameter
- add c
Module: kamailio
Branch: master
Commit: 91c73d62bcb5e635aae4462393e3fe71b64657f1
URL:
https://github.com/kamailio/kamailio/commit/91c73d62bcb5e635aae4462393e3fe71b64657f1
Author: Federico Cabiddu
Committer: Federico Cabiddu
Date: 2021-03-31T11:50:29+02:00
http_async_client: configure curl redi
Module: kamailio
Branch: master
Commit: 3b339e15e0c14c688b2dea1c2a46b212cd60eef8
URL:
https://github.com/kamailio/kamailio/commit/3b339e15e0c14c688b2dea1c2a46b212cd60eef8
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2021-03-31T10:16:13+02:00
modules: readme files regenerated - pua_dialog
Module: kamailio
Branch: master
Commit: 499d1fcf4a16a7f52fda7548c990de70745b54d4
URL:
https://github.com/kamailio/kamailio/commit/499d1fcf4a16a7f52fda7548c990de70745b54d4
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T10:01:11+02:00
pua_dialoginfo: docs f
Module: kamailio
Branch: master
Commit: be279afb807ad74c7d46f9e57cfa7fae5226a1e3
URL:
https://github.com/kamailio/kamailio/commit/be279afb807ad74c7d46f9e57cfa7fae5226a1e3
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T10:01:11+02:00
pua_dialoginfo: new pa
Module: kamailio
Branch: master
Commit: 8c69bd53ebd47c51f37bdcc96a8719b1d1c69947
URL:
https://github.com/kamailio/kamailio/commit/8c69bd53ebd47c51f37bdcc96a8719b1d1c69947
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2021-03-31T10:01:11+02:00
pua_dialoginfo: use he
Hi Olle,
thanks for the pointer, it was just a spelling mistake 😉. Should be fixed now.
Cheers,
Henning
--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com
-Original Message-
From: sr-dev On Behalf Of Olle E. Johansson
Sent: Wednesday, March 31,
58 matches
Mail list logo
