Re: [sr-dev] [kamailio/kamailio] Jchavanton/statsd (#2774)

2021-06-09 Thread Julien Chavanton
@jchavanton pushed 1 commit. 51b01c736abf746ff577963411b82c56c714721e stastd: adding histogram -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] Jchavanton/statsd (#2774)

2021-06-09 Thread Julien Chavanton
adding support for histograms !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch

Re: [sr-dev] [kamailio/kamailio] tcpops fixup failure (#2772)

2021-06-09 Thread Julien Chavanton
I was wrong, in fact this is fixed by ``` commit 02240711239149e2f5c4890a70ab158d10fa8187 Author: Daniel-Constantin Mierla Date: Sat May 8 23:30:22 2021 +0200 tcpops: use fixup_igp_all() instead of fixup_igp_null() - needed for functions with many parameters ``` but it is not in

Re: [sr-dev] [kamailio/kamailio] tcpops fixup failure (#2772)

2021-06-09 Thread Julien Chavanton
Closed #2772. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2772#event-4867527689___ Kamailio (SER) - Development Mailing List

[sr-dev] [kamailio/kamailio] postrgresql: kamdbctl create issue (#2773)

2021-06-09 Thread Ilya Demyanov
``` # kamdbctl create -e \E[37;33mINFO: creating database kamailio ... -e \E[37;33mINFO: Core Kamailio tables successfully created. Install presence related tables? (y/n): y -e \E[37;33mINFO: creating presence tables into kamailio ... -e \E[37;33mINFO: Presence tables successfully created.

[sr-dev] [kamailio/kamailio] tcpops fixup failure (#2772)

2021-06-09 Thread Julien Chavanton
### Description Kamailio does not start when doing fixup for tcpops. ``` tcp_keepalive_enable("$avp(caller_conid)", "60", "5", "2"); ``` ``` 0(1) ERROR: [core/route.c:1166]: fix_actions(): fixing failed (code=-1) at cfg:/etc/kamailio/kamailio.cfg:160 ``` ### Troubleshooting I will try

Re: [sr-dev] [kamailio/kamailio] rtpengine: ignore mos 0 when selecting min-mos (#2771)

2021-06-09 Thread Julien Chavanton
@jchavanton pushed 1 commit. 86607cfad830ed5591bd1c0d04d79b223e65d6f5 rtpengine: ignore mos 0 when selecting min-mos -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] rtpengine: ignore mos 0 when selecting min-mos (#2771)

2021-06-09 Thread Julien Chavanton
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] nathelper: fix_nated_sdp added ignoring RFC3605-param if omitted (#2737)

2021-06-09 Thread Arsen Semenov
Hello @dwagin Could you please check the case: if 'a=rtcp' is presents, but contains only port value, exactly as mentioned in #2768 `rtcp-attribute = "a=rtcp:" port [nettype space addrtype space connection-address] CRLF` It seems that in this case the fix you've provided will not

Re: [sr-dev] [kamailio/kamailio] TLS: same TLSc is used for different outbound connection when it is switched with tls_set_connect_server_id() (#2760)

2021-06-09 Thread Daniel-Constantin Mierla
As I understood from the previous comment, it is same target address, but you want different tls connections with different certs. SIP specifications decouple transport layer from SIP traffic, there is no relation between a SIP request/transaction/dialog and transport layer (in this case the

Re: [sr-dev] [kamailio/kamailio] TLS: same TLSc is used for different outbound connection when it is switched with tls_set_connect_server_id() (#2760)

2021-06-09 Thread Tim Chubb
Debug output attached, in the full version from about line 8050 is the dispatcher activity [kamailio-debug-dispatcher-sni-full.log](https://github.com/kamailio/kamailio/files/6623779/kamailio-debug-dispatcher-sni-full.log)

Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Victor Seva
It seems both are trying to fix the same issue. I didn't notice #2737 @dwagin can you please check it my solution works for you? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] [stirshaken] add identity header in reply messages or to a separate variable (#2770)

2021-06-09 Thread sergei lavrov
Hello Daniel! Thanks for your prompt reply, greatly appreciated! I can confirm that your solution works, but with a slight modification to the `record_route()` function to get rid of the error: ``` ERROR: [core/msg_translator.c:3355]: sip_msg_apply_changes(): cannot apply msg changes after

Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Arsen Semenov
Hello @linuxmaniac seems this use case somehow escaped from my attention, when I was looking into the fix for #2459. Thank you for fixing it up. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Daniel-Constantin Mierla
It seems to be a conflict looking at the commits in the two PRs, if the offsets are not messing my evaluation -- yours is changing replace_sdp_ip() function with: ``` - if(!hasreplaced) { + if(!hasreplaced && memcmp("a=rtcp", line, 6) != 0) { LM_ERR("can't extract

Re: [sr-dev] [kamailio/kamailio] [stirshaken] add identity header in reply messages or to a separate variable (#2770)

2021-06-09 Thread Daniel-Constantin Mierla
Making it available on a variable seems to offer more flexibility, then append_to_reply() can be used for your specific case. With the current version, if the sip transaction is not created yet (which I assume is not, because of stateless reply with sl_send_reply()), you can try: ``` if

Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Victor Seva
> Is it somehow related to PR #2737? No, it's not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2769#issuecomment-857609029___

[sr-dev] [kamailio/kamailio] [stirshaken] add identity header in reply messages or to a separate variable (#2770)

2021-06-09 Thread sergei lavrov
### Description I'm unable to add the generated `Identity` value to reply message when `kamailio` acts as a redirect server and replies with `302 Moved Temporarily` instead of relaying `INVITE`. This code doesn't work, i.e. no `Identity` header in `302 Moved Temporarily` message: ``` if

Re: [sr-dev] [kamailio/kamailio] SDP filtering issues with sdpops module (#2755)

2021-06-09 Thread Alessio Garzi
thanks a lot @miconda and yes... for now I will try to write a workaround using remove_line_by_prefix inside my kamailio config files, thx for your suggestions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] siptrace: added siptrace pseudo var (#2752)

2021-06-09 Thread Daniel-Constantin Mierla
I changed the code to be $siptrace(src_addr) and $siptrace(dst_addr), because the URI in the keyword would suggest is a SIP URI format. I also updated the wiki. You can parse "proto:ip:port" with `parse_phostport()` and then get its attributes to have variables for ip, port, ... -- You are

Re: [sr-dev] [kamailio/kamailio] siptrace: added siptrace pseudo var (#2752)

2021-06-09 Thread sergey-safarov
Done https://www.kamailio.org/wiki/cookbooks/devel/pseudovariables#siptrace_module I think feature updates still required. I think src_uri and dst_uri are not correct here because of this socket info, not SIP uri. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [sr-dev] [kamailio/kamailio] filter_body() fails when there isn't a space after "Content-Type:" (#2748)

2021-06-09 Thread duarterocha91
I've sent it to your e-mail with the subject "filter_body issue #2748". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] SDP filtering issues with sdpops module (#2755)

2021-06-09 Thread Daniel-Constantin Mierla
Actually instead of `subst_body()` from textops, which I suggested in the previous comment, the sdpops module offers a more convenient function to remove lines from sdp that match a prefix: * https://www.kamailio.org/docs/modules/stable/modules/sdpops.html#sdpops.f.remove_line_by_prefix --

Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Daniel-Constantin Mierla
Is it somehow related to PR #2737? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2769#issuecomment-857542874___ Kamailio (SER) -

[sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

2021-06-09 Thread Victor Seva
Examples from RFC3605: m=audio 49170 RTP/AVP 0 a=rtcp:53020 m=audio 49170 RTP/AVP 0 a=rtcp:53020 IN IP4 126.16.64.4 m=audio 49170 RTP/AVP 0 a=rtcp:53020 IN IP6 2001:2345:6789:ABCD:EF01:2345:6789:ABCD fix #2768 Pre-Submission Checklist !-- Go over all points below,

[sr-dev] [kamailio/kamailio] nathelper: 'a=rtcp' without IP generates an ERROR (#2768)

2021-06-09 Thread Victor Seva
### Description As described at [RFC3605](https://datatracker.ietf.org/doc/html/rfc3605#section-2.1) ``` rtcp-attribute = "a=rtcp:" port [nettype space addrtype space connection-address] CRLF ``` So IP info is optional. ### Troubleshooting Log Messages ``` Jun 7 09:55:57 sp2

Re: [sr-dev] [kamailio/kamailio] TLS: same TLSc is used for different outbound connection when it is switched with tls_set_connect_server_id() (#2760)

2021-06-09 Thread Tim Chubb
Certainly, i spent yesterday debugging and going through the logs and im thinking the issue may be the (ab)use of dispatcher to ping the same destination presenting as different domains. The destinations are intentially the same in the sample dispatcher.list in the first post ```1

[sr-dev] git:master:5d03c923: core: kemi - added KSR.is_WSX() - return true of proto is WS or WSS

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 5d03c9235f79ce4af35b6f79eddebae9f512f1d3 URL: https://github.com/kamailio/kamailio/commit/5d03c9235f79ce4af35b6f79eddebae9f512f1d3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T14:48:19+02:00 core: kemi - added

Re: [sr-dev] [kamailio/kamailio] Random segfault or general protection crash on siptrace.so module (#2718)

2021-06-09 Thread Daniel-Constantin Mierla
Probably the field `dst->send_sock` is no longer valid, it can confirmed by getting: ``` frame 0 p *dst->send_sock ``` If the address is invalid, can be the case that the SIP transaction is destroyed at same time due to a race. I see you use dialog mode tracing - `d` mode: ``` # Only

Re: [sr-dev] [kamailio/kamailio] app_perl: Ignore __DIE__ signals that come from eval blocks (#2745)

2021-06-09 Thread Daniel-Constantin Mierla
Closed #2745. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2745#event-4863236509___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] app_perl: Ignore __DIE__ signals that come from eval blocks (#2745)

2021-06-09 Thread Daniel-Constantin Mierla
PR was merged, can be backported to stable branches before new releases are out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] SDP filtering issues with sdpops module (#2755)

2021-06-09 Thread Daniel-Constantin Mierla
The code needs to be updated to be able to catch `a=rtcp-fb:`, probably it was not a common attribute when the sdp parser was written and not covered at that time (iirc, it was @ovidiusas writing the sdp parser). The solution right now is to use `subst_body()` function to remove lines from sdp

[sr-dev] git:master:5e06b6bc: pv: support Record/-Route headers for $hflc(...)

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 5e06b6bcaf0047e5bb22105e03331268cee8486f URL: https://github.com/kamailio/kamailio/commit/5e06b6bcaf0047e5bb22105e03331268cee8486f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T13:33:06+02:00 pv: support

Re: [sr-dev] [kamailio/kamailio] siptrace: added siptrace pseudo var (#2752)

2021-06-09 Thread Daniel-Constantin Mierla
@sergey-safarov - you have the list the new variables in the pv cookbook: * https://www.kamailio.org/wiki/cookbooks/devel/pseudovariables -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] siptrace: added siptrace pseudo var (#2752)

2021-06-09 Thread Daniel-Constantin Mierla
Merged #2752 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2752#event-4863113559___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] siptrace: added siptrace pseudo var (#2752)

2021-06-09 Thread Daniel-Constantin Mierla
Thanks! Merging it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2752#issuecomment-857452823___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] TLS: same TLSc is used for different outbound connection when it is switched with tls_set_connect_server_id() (#2760)

2021-06-09 Thread Daniel-Constantin Mierla
Can you set the `debug=3` global parameter, reproduce the scenario and attach here all log messages printed by kamailio to syslog (there should be a log of `DEBUG`)? It will help to troubleshoot and see what happens. -- You are receiving this because you are subscribed to this thread. Reply to

[sr-dev] git:master:7bf207bf: siptrace: use src/dst_addr instead src/dst_uri for $siptrace(...) vars

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 7bf207bf6bd60bd1c50fb9321d31c4d48562b5b7 URL: https://github.com/kamailio/kamailio/commit/7bf207bf6bd60bd1c50fb9321d31c4d48562b5b7 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T12:31:31+02:00 siptrace: use

[sr-dev] git:master:e5f13086: pv: support INET/6 as alternative IPv4/6 for $K(key)

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: e5f130860d909e9a4348db170d4001332e90427e URL: https://github.com/kamailio/kamailio/commit/e5f130860d909e9a4348db170d4001332e90427e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T12:27:57+02:00 pv: support INET/6 as

[sr-dev] git:master:36817c3e: core: cfg.lex - accept IPv4/6 as alternative keywords for INET/6

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 36817c3ea53daae9706c1caa695af98f9ca987bd URL: https://github.com/kamailio/kamailio/commit/36817c3ea53daae9706c1caa695af98f9ca987bd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T12:19:24+02:00 core: cfg.lex -

[sr-dev] git:master:11acfd85: pv: extended $nh(k) to work for replies using 2nd via

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 11acfd857d1b9c5e7e4c10efd8f1eb239c77e8a8 URL: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb239c77e8a8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T12:02:08+02:00 pv: extended $nh(k)

[sr-dev] git:master:a8c9d0ae: pv: added missing WS and WSS to $K(key) variable

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: a8c9d0ae4fbafba89ef12737419037d141eed1d3 URL: https://github.com/kamailio/kamailio/commit/a8c9d0ae4fbafba89ef12737419037d141eed1d3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-06-09T12:15:38+02:00 pv: added missing WS

[sr-dev] Releasing Kamailio v5.5.1

2021-06-09 Thread Daniel-Constantin Mierla
Hello, I am considering to release Kamailio v5.5.1 sometime next week, likely on Tuesday or Wednesday (June 15 or 16, 2021). This is the usual heads up notification to see if anyone is aware of issues not yet reported to bug tracker and if yes, do it as soon as possible to give them a chance to

[sr-dev] git:master:8275046a: siptrace: aadded siptrace pseudo var

2021-06-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 8275046a250a80018f42f8dbadaa245094c6f5ff URL: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245094c6f5ff Author: Sergey Safarov Committer: Daniel-Constantin Mierla Date: 2021-06-09T09:21:16+02:00 siptrace: aadded siptrace