Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Victor Seva
@iliesh Sorry is a structure not a pointer... try this, please ``` diff --git a/src/modules/nats/nats_mod.c b/src/modules/nats/nats_mod.c index 852d0fbbab..51277e4ac0 100644 --- a/src/modules/nats/nats_mod.c +++ b/src/modules/nats/nats_mod.c @@ -588,7 +588,8 @@ int nats_destroy_workers()

Re: [sr-dev] [kamailio/kamailio] Regression on app_lua after ASLR enable (Issue #3202)

2022-09-28 Thread Henning Westerholt
@drTr0jan I agree that its not the optimal solution for the affected OS. But as you mentioned the easiest workaround is to just deactivate it on the systems until 5.7.0 next year. OS that build their own packages (like the mentioned FreeBSD) could of course also add the two patches to their own

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread iliesh
@linuxmaniac, I'm trying to apply the patch you provided but it's not working for me. Maybe it's for a different branch? I tried with 5.6, master and none of them worked. ``` patching file src/modules/nats/nats_mod.c Hunk #1 FAILED at 588. 1 out of 1 hunk FAILED -- saving rejects to file src/mod

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Wouldn't it work in the old version by providing `sip:group_id@domain` as the > second parameter of `sl_lookup()`, with the `username` set to `group_id` > inside database table? Yes, I failed to communicate the idea: that a group could have multiple domains. For example: group A has speed di

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Daniel-Constantin Mierla
Wouldn't it work in the old version by providing `sip:group_id@domain` as the second parameter of `sl_lookup()`, with the `username` set to `group_id` inside database table? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3255#issuecomment-126098

Re: [sr-dev] [kamailio/kamailio] Regression on app_lua after ASLR enable (Issue #3202)

2022-09-28 Thread Daniel-Constantin Mierla
Those are changes that introduce nu syntax to config file and do not qualify for back porting. As I wrote in previous comments, this report is not about a regression, because there was not a past commit that introduced such limitation, which could have been eventually reverted to get it back wo

[sr-dev] git:master:9a41fb54: rtpengine: allow to-tag usage for all commands

2022-09-28 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 9a41fb5403a6bc4fd5ccee239ccdf725fe6f91df URL: https://github.com/kamailio/kamailio/commit/9a41fb5403a6bc4fd5ccee239ccdf725fe6f91df Author: Richard Fuchs Committer: Richard Fuchs Date: 2022-09-28T09:33:56-04:00 rtpengine: allow to-tag usage for all comman

Re: [sr-dev] [kamailio/kamailio] Regression on app_lua after ASLR enable (Issue #3202)

2022-09-28 Thread Boris Korzun
@miconda, what about to merge f5c98a49c98aedcf6e1afec3c42dd862d0eeb9a3 and 69ba64e26e3876ce84053a691dee2f2ad9bb6185 to 5.6? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3202#issuecomment-1260918081 You are receiving this because you are subscr

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
Could you try the changes @linuxmaniac proposed -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1260872121 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread iliesh
Hi @eschmidbauer, thanks for looking into this, but unfortunately still not working for me, this is the format I've tried: ``` modparam("nats", "nats_url", "nats://192.168.1.1:4222") modparam("nats", "subject_queue_group", "sql.test_sub.com:testqueue") ``` -- Reply to this email directly or vi

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
I believe you need to use the correct format like `modparam("nats", "subject_queue_group", "Kamailio-World:2020")` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1260834997 You are receiving this because you are subscribed to t

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread iliesh
@eschmidbauer, not sure about that, just tried now to subscribe to a queue and it's still the same ``` modparam("nats", "subject_queue_group", "test") ``` Log Error: ``` ERROR: nats [nats_mod.c:456]: nats_init_connection(): could not create nats options [System Error] ERROR: nats [nats_mod.c:26

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Ok, thanks - now its more clear. There might be more review comments from > people more familiar about this module. One remark about the SQL changes - > this needs to be done not in the actual SQL files, but in the XML template > available in lib/srdb1/schema. You should probably also incremen

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
Hi- I think the module requires you to subscribe to a channel. The module was originally built only as a consumer but now since the module can publish, that is no longer the case. Please confirm my suspicion and I will try to work on a fix to disable subscribe if only needed it for publish --

[sr-dev] git:master:28ce28f2: modules: readme files regenerated - lrkproxy ... [skip ci]

2022-09-28 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 28ce28f26ba069781ac6aee6c7ffcbd1281d7848 URL: https://github.com/kamailio/kamailio/commit/28ce28f26ba069781ac6aee6c7ffcbd1281d7848 Author: Kamailio Dev Committer: Kamailio Dev Date: 2022-09-28T13:01:21+02:00 modules: readme files regenerated - lrkproxy .

[sr-dev] git:master:6eb5bb67: lrkproxy: Add new features : TURN support, behind_nat support, subset of range ports

2022-09-28 Thread Mojtaba Esfandiari . S
Module: kamailio Branch: master Commit: 6eb5bb67586bf91c5d42a5864d881a4fc82a6638 URL: https://github.com/kamailio/kamailio/commit/6eb5bb67586bf91c5d42a5864d881a4fc82a6638 Author: Mojtaba Esfandiari.S Committer: Mojtaba Esfandiari.S Date: 2022-09-28T14:25:26+03:30 lrkproxy: Add new features : T

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Victor Seva
@eschmidbauer maybe this? ``` diff --git a/src/modules/nats/nats_mod.c b/src/modules/nats/nats_mod.c index 852d0fbbab..35e6b2612f 100644 --- a/src/modules/nats/nats_mod.c +++ b/src/modules/nats/nats_mod.c @@ -588,7 +588,8 @@ int nats_destroy_workers() LM_ERR

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
@Tomohare pushed 2 commits. 92836699af2949ff9181d3a99d838099667cf654 speeddial: allow search uri of speed dial by group f8a15c42bc21990966aeb47c1ac2345d199b163a kamctl: update speeddial schema -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3255/files/1a2122c875995f3be6939f38d

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread iliesh
There you go: ``` (gdb) f 3 #3 0x7fb35c146d3d in nats_destroy_workers () at nats_mod.c:591 591 uv_poll_stop(&pub_worker->poll); (gdb) p *pub_worker $1 = {pid = 0, fd = 0, uvLoop = 0x0, pipe = {data = 0x0, loop = 0x0, type = UV_UNKNOWN_HANDLE, close_cb = 0x0, handle

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Victor Seva
can you please go to frame 3 and check the value of ``pub_worker``? ``` f 3 p *pub_worker ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1260637465 You are receiving this because you are subscribed to this thread. Message

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread iliesh
Hi @henningw , Please find the core dump below: ``` (gdb) bt #0 0x7fb35c0961cc in uv.io_stop () from /lib64/libuv.so.1 #1 0x7fb35c09c71a in uv.poll_stop.lto_priv () from /lib64/libuv.so.1 #2 0x7fb35c09c763 in uv_poll_stop () from /lib64/libuv.so.1 #3 0x7fb35c146d3d in nats_des

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Henning Westerholt
Ok, thanks - now its more clear. There might be more review comments from people more familiar about this module. One remark about the SQL changes - this needs to be done not in the actual SQL files, but in the XML template available in lib/srdb1/schema. You should probably also increment the ta

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Thanks for the pull requests. Maybe I missed something, but it seems that the > actual implementation of the new functions is missing? if its still work in > progress, no problem just let us known. Sorry 🙇 Here are the missing modifications. -- Reply to this email directly or view it on GitH

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
@Tomohare pushed 1 commit. 1a2122c875995f3be6939f38d555838a6f234605 speeddial: allow search uri of speed dial by group -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3255/files/b5547542c327c363824fdd0b822cd9aada132b5c..1a2122c875995f3be6939f38d555838a6f234605 You are receiving

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Henning Westerholt
Thanks for the report. Could you please create a core dump from the created dump file? Refer e.g. to [http://www.kamailio.org/wiki/tutorials/troubleshooting/coredumpfile](wiki) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-12

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Henning Westerholt
Thanks for the pull requests. Maybe I missed something, but it seems that the actual implementation of the new functions is missing? if its still work in progress, no problem just let us known. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3255#

[sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare