[sr-dev] git:master:aef9cec3: core: avoid C99 error

2024-01-05 Thread Morten Tryfoss via sr-dev
Module: kamailio Branch: master Commit: aef9cec329893f58b0c7df5aec2050b6c3cecc60 URL: https://github.com/kamailio/kamailio/commit/aef9cec329893f58b0c7df5aec2050b6c3cecc60 Author: Morten Tryfoss Committer: Morten Tryfoss Date: 2024-01-04T13:26:26+01:00 core: avoid C99 error --- Modified: src/

[sr-dev] Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,xenial #2567

2024-01-05 Thread kamailio--- via sr-dev
See Changes: -- [...truncated 1.45 MB...] make[2]: Entering directory '/build/kamailio-5.8.0~dev2+ubuntu16.04.20240105005443.2590

[sr-dev] Re: [kamailio/kamailio] parser/contact: Change addition order to the end of list (PR #3698)

2024-01-05 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 1 commit. 2cd4b4dfcc4e9a642a9d02de7cc2541e913586b3 parser/contact: Change addition order to the end of list -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3698/files/cf39918a7d22c1f55b74c22fa659e79f7eccff3e..2cd4b4dfcc4e9a642a9d02de7cc2541e913586b3 You are rec

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2024-01-05 Thread Henning Westerholt via sr-dev
Are there more comments or objections? If not I would merge it in the next days. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878352646 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] pv_core: Fix negative index bug for hfl() (PR #3697)

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Thanks! I thought it was based on the same approach as for `$(hdr(name)[index])`, but that works fine. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3697#issuecomment-1878365467 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] pv_core: Fix negative index bug for hfl() (PR #3697)

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Merged #3697 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3697#event-11399179201 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] git:master:8038fba2: pv_core: Fix negative index bug for hfl()

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 8038fba2dd056193b37a5c2571f2d4d910c47e73 URL: https://github.com/kamailio/kamailio/commit/8038fba2dd056193b37a5c2571f2d4d910c47e73 Author: Xenofon Karamanos Committer: Daniel-Constantin Mierla Date: 2024-01-05T10:25:02+01:00 pv_core: Fix negative index b

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Thanks for the PR! I haven't done a full review, but first, you have to add documentation to the xml fine in the doc/ subfolder. It helps to understand how is supposed to be used and see if follows the code. Also, the DS_MATCH_STRICTEST should be changed to try to reflect better what kind of m

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
I haven't gotten the time to review if the list of XAVPs can be just linked or needs to be cloned. If it is just used temporarily in a function, then linking should be fine, but if it needs to be kept for long, then it could be that clone has to be done, otherwise the list stays linked from two

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2024-01-05 Thread Henning Westerholt via sr-dev
Thanks, yes this was basically the question also @xkaraman had earlier. The XAVPs will be used in the cfg script context later on I think. He will do another review. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878409382 You

[sr-dev] git:master:ef45b7b8: tm: free new uac dlg in case of errors

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ef45b7b804a3ba79880afd218f6b3f3962c85ed7 URL: https://github.com/kamailio/kamailio/commit/ef45b7b804a3ba79880afd218f6b3f3962c85ed7 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-01-05T11:55:03+01:00 tm: free new uac dlg i

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Morten Tryfoss via sr-dev
I've not done any testing myself, but by my understanding the DS_MATCH_STRICTEST flag is basically a flag to indicate it should not return on the first match but scan through all. Then sort and return the one that is matching one most criterias? -- Reply to this email directly or view it on Gi

[sr-dev] git:master:4708f537: outbound: build, fix missing argument name

2024-01-05 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: 4708f537d7f5d28123b48cd89474a4931dd698ad URL: https://github.com/kamailio/kamailio/commit/4708f537d7f5d28123b48cd89474a4931dd698ad Author: S-P Chan Committer: S-P Chan Date: 2024-01-05T20:56:39+08:00 outbound: build, fix missing argument name --- Modif

[sr-dev] [kamailio/kamailio] sip_trace(address, "", "t") uses the duplicate_uri for replies from auth_challenge instead of address argument in sip_trace() (Issue #3700)

2024-01-05 Thread Niklas Larsson via sr-dev
### Description Using sip_trace() with different address arguments: ``` modparam("siptrace", "duplicate_uri", "sip:X.X.X.X:9060") # siptrace till Homer if(method == "REGISTER"){ sip_trace("sip:X.X.X.X:9060", "", "t"); } # siptrace till Voipmonitor if (is_method("INVITE|BYE|UPDATE|CANCE

[sr-dev] Re: [kamailio/kamailio] sip_trace(address, "", "t") uses the duplicate_uri for replies from auth_challenge instead of address argument in sip_trace() (Issue #3700)

2024-01-05 Thread Markus Monka via sr-dev
Hi, 407 is a reply, so i guess, kamailio sends the duplicate message to default target configured in modpraram. You should configure something like onreply_route { if 407 sip_trace(sip:Y.Y.Y.Y) } Markus On Fri, Jan 5, 2024 at 2:23 PM Niklas Larsson via sr-dev < sr-dev@lists.kama

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Dennis via sr-dev
> Maybe DS_MATCH_FULLADDRSOCK. OK, i will change the flag name, need some time to think about adequate name, writing docs hope can help with this. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3699#issuecomment-1879191053 You are receiving thi

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Dennis via sr-dev
> I've not done any testing myself, but by my understanding the > DS_MATCH_STRICTEST flag is basically a flag to indicate it should not return > on the first match but scan through all. Then sort and return the one that is > matching one most criterias? Right, but not exactly, there is no sorti

[sr-dev] git:master:95d8d937: msilo: make static and add prefix to global variables with short name

2024-01-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 95d8d9374a0e4385fd549078fcf56ecadef424a0 URL: https://github.com/kamailio/kamailio/commit/95d8d9374a0e4385fd549078fcf56ecadef424a0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-01-05T21:36:29+01:00 msilo: make static and

[sr-dev] Re: [kamailio/kamailio] dialog: failover database loading behaviour in shared DB scenario, expiration of dialogs (#2080)

2024-01-05 Thread github-actions[bot] via sr-dev
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2080#issuecomment-1879505889 You are receiving this because yo