[sr-dev] TLS.reload and memory usage of SSL_CTX structs

2024-05-14 Thread Xenofon Karamanos via sr-dev
Hello all, I am currently looking into issue https://github.com/kamailio/kamailio/issues/3823 regarding the tls.reload and the constant increase in memory usage when it's called. I tried to look something up related to CRL and related functions for what causing it but nothing to obvious. The o

[sr-dev] Re: [kamailio/kamailio] permissions: introduce func `allow_register_include_port()` (PR #3846)

2024-05-14 Thread Donat Zenichev via sr-dev
@mtirpak can you pleae have a look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3846#issuecomment-2109971461 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] Re: TLS.reload and memory usage of SSL_CTX structs

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Hello, thanks for digging in it! As I understand, this is somehow first about reducing the size of used memory, not clearly identifying the leak itself. The duplication done per process was to avoid races if local changes has to be performed (e.g., by libssl internally on handling traffic), b

[sr-dev] [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches -

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 4ccadb7ed3a762ec1d2781e783f760f6de4b588e Format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4a1aa23d6b1d8bb90f267b64a33b25beb2b0977c..4ccadb7ed3a762ec1d2781e783f760f6de4b588e You are receiving this because you are subscribed to thi

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 6992d1784aa3e1f96aa3a406f25675178605108d More format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4ccadb7ed3a762ec1d2781e783f760f6de4b588e..6992d1784aa3e1f96aa3a406f25675178605108d You are receiving this because you are subscribed t

[sr-dev] Re: [kamailio/kamailio] possible memory corruption in sipcapture module (Issue #3835)

2024-05-14 Thread Lennart Rosam via sr-dev
I've worked with @sipgate-uhlig on this topic. He's out of office this week so I took a look at it together with another colleague. We can confirm that the latest master branch does no longer suffer from this issue . Thank you @miconda for resolving this so quickly! Can we assume that it will b

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
The README must not be regenerated locally and part of the commit, it is going to be generated on server and pushed to git repository by a cron job. One can generate readme locally only for checking it if it is correct, but then reverted before committing. Of course, if one pushed a regenerated

[sr-dev] Re: TLS.reload and memory usage of SSL_CTX structs

2024-05-14 Thread Xenofon Karamanos via sr-dev
Hello Daniel, Thanks for the feedback! Maybe i should have explained better regarding the leak. Indeed, i couldn't clearly identify the leak itself but there is an indication that the leak is happening in the SSL_CTX_load_verify_locations() function. When i comment out that part of the load_cr

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
Daniel-Constantin Mierla writes: > One can generate readme locally only for checking it if it is correct, > but then reverted before committing. That is exactly what I tried to do according to instructions, but generation failed. Also, there is something wrong with the format check. It shows re

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
If you want to test README generation locally, then you are missing some dockbook-relate packages, likely `docbook-xsl`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110568295 You are receiving this because you are subscribed

[sr-dev] git:master:3763e9c8: auth: new function auth_algorithm(...) to dynamically override algorithm

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 3763e9c826640402c798d4581d0b2f1b13e4519b URL: https://github.com/kamailio/kamailio/commit/3763e9c826640402c798d4581d0b2f1b13e4519b Author: Juha Heinanen Committer: Daniel-Constantin Mierla Date: 2024-05-14T17:52:29+02:00 auth: new function auth_algorithm

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Merged manually! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110591764 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Closed #3849. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#event-12804750240 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:4a7aa098: modules: readme files regenerated - auth ... [skip ci]

2024-05-14 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: master Commit: 4a7aa098281b608177c5da61e7a47067463267bf URL: https://github.com/kamailio/kamailio/commit/4a7aa098281b608177c5da61e7a47067463267bf Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-05-14T18:01:11+02:00 modules: readme files regenerated - auth ... [

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
> If you want to test README generation locally, then you are missing some > dockbook-relate packages, likely `docbook-xsl`. README generation worked after I installed Debian package `docbook-xsl`. For some reason make command as described here [https://www.kamailio.org/wikidocs/devel/module-d

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
How about the failing format check? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110621100 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] git:master:18e4d38e: auth: export auth_algorithm(...) to kemi

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 18e4d38e4d57ce88cbe16eec4cfb2a5a1b5554a4 URL: https://github.com/kamailio/kamailio/commit/18e4d38e4d57ce88cbe16eec4cfb2a5a1b5554a4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-14T18:13:04+02:00 auth: export auth_algo

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
I haven't checked closely, at the first look it seems some spacing issues in one of the commits out of three. Did you run clang-format? I installed the git hooks as suggested by Victor Seva and any clang-format issues are reported and fixed before I can do a commit. -- Reply to this email dire

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
After the first commit. there was format issues that I tried to fix manually and pushed another commit. After that, format check was re-run automatically and one more format issue remained. I fixed also that, push a new commit, and again format check was re-run automatically. Now the format c

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
As I said, I haven't looked much into it, not sure what was the reason ... I installed `pre-commit` along with `clang-format` and before each commit the formatting is checked automatically, simplifying my coding process as I can do it without caring of formatting and it gets fixed at commit time

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Victor Seva via sr-dev
You can push --force the new commit with the format fixed squashing previous commits -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110860065 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)

2024-05-14 Thread github-actions[bot] via sr-dev
Closed #3778 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3778#event-12810266353 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Dev

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-05-14 Thread github-actions[bot] via sr-dev
Closed #3731. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3731#event-12810265977 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing