[sr-dev] Re: Releasing v5.7.6

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Hello, short reminder that today v5.7.6 is going to be release, as usual, any commits to branch 5.7 have to be announced to sr-dev mailing list and wait for the ack before pushing to the repo to avoid conflicts with the release building process. Once the announcement is out, the commits can go in

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
A heavier touch, but we can postpone `close(fd)` to the end and it also doesn't matter if we close needlessly - it is almost a no-op with `fd = -1`. If you disagree, I can try something else. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
@guss77 pushed 1 commit. 5c2e09a354af17682f82cc769eb7e1ae130e541e rtpengine: show errno and error string in more places where it is useful -- View it on GitHub:

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)

2024-07-01 Thread Dragos Vingarzan via sr-dev
Merged #3895 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3895#event-13355737088 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:0c7affcd: ims_registrar_scscf: drop subscription on notification failure (#3895)

2024-07-01 Thread GitHub via sr-dev
Module: kamailio Branch: master Commit: 0c7affcde380af433ce3373248a9544450261e1b URL: https://github.com/kamailio/kamailio/commit/0c7affcde380af433ce3373248a9544450261e1b Author: Dragos Vingarzan Committer: GitHub Date: 2024-07-01T21:34:17+02:00 ims_registrar_scscf: drop subscription on

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
> You should be able to just run `clang-format` over your edited code and that > should reformat it to make the format checker happy. I figured it out afterwards :sweat_smile: > There are some function calls (`close()` for example) between testing the > `errno` value and printing out the log

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)

2024-07-01 Thread Supreeth Herle via sr-dev
@herlesupreeth approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3895#pullrequestreview-2151236217 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Richard Fuchs via sr-dev
You should be able to just run `clang-format` over your edited code and that should reformat it to make the format checker happy. There are some function calls (`close()` for example) between testing the `errno` value and printing out the log line. These functions might reset `errno` to

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)

2024-07-01 Thread Dragos Vingarzan via sr-dev
@vingarzan commented on this pull request. > tmb.t_request_within(_r); } - if(h.s) - pkg_free(h.s); - if(content.s) { - pkg_free(content.s); + watcher_contact = 0; Shouldn't - both branches of the `if` before have the

[sr-dev] git:master:12c30d56: ims_registrar_scscf: fix for location AOR with empty host (#3897)

2024-07-01 Thread GitHub via sr-dev
Module: kamailio Branch: master Commit: 12c30d5606213eaf14c250e572545c3f8b37d50b URL: https://github.com/kamailio/kamailio/commit/12c30d5606213eaf14c250e572545c3f8b37d50b Author: Dragos Vingarzan Committer: GitHub Date: 2024-07-01T13:56:02+02:00 ims_registrar_scscf: fix for location AOR with

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix for location AOR with empty host (PR #3897)

2024-07-01 Thread Dragos Vingarzan via sr-dev
I tested with tel-URIs as global-number, which I think is a valid use-cases. The S-CSCF would say that the destination is not found in the registrar, although I could see it exactly like it was in the INVITE. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix for location AOR with empty host (PR #3897)

2024-07-01 Thread Dragos Vingarzan via sr-dev
Merged #3897 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3897#event-13350181896 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:b8c1bab2: pv: increase PV_ESCSTR_SIZE to 32

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: b8c1bab290eaf1e26862c73c1add9d104c9841c0 URL: https://github.com/kamailio/kamailio/commit/b8c1bab290eaf1e26862c73c1add9d104c9841c0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-01T13:47:16+02:00 pv: increase

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
@guss77 pushed 1 commit. da1c411f6ae165eedd1fccf7891b66de2bc844ec rtpengine: show errno and error string in more places where it is useful -- View it on GitHub:

[sr-dev] git:5.6:825b3655: modules: readme files regenerated - modules ... [skip ci]

2024-07-01 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: 5.6 Commit: 825b36557be137fd51626c8cdbc80027b79afa2b URL: https://github.com/kamailio/kamailio/commit/825b36557be137fd51626c8cdbc80027b79afa2b Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-07-01T10:31:33+02:00 modules: readme files regenerated - modules ...

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
I tried to match the line indentation formatting to what the CI action is showing, but it doesn't show the difference between tabs and spaces - and now I have the feeling that it showed extra indentation using spaces while all other indentation is tabs, and I overshot. -- Reply to this email

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
@guss77 pushed 1 commit. 7d577c072b31ed8abccdffb49031723d70ce055f rtpengine: show errno and error string in more places where it is useful -- View it on GitHub:

[sr-dev] git: new commits in branch 5.6

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
- URL: https://github.com/kamailio/kamailio/commit/1b96bb4a5a667c9838441876838d3c1adc6d6d51 Author: Daniel-Constantin Mierla Date: 2024-07-01T09:59:39+02:00 core: parse privacy recompute lenght of rest to parse (cherry picked from commit 804ee651b45498727196886c97cb55d20b254c4a) (cherry

[sr-dev] git:5.7:4d1c41f2: modules: readme files regenerated - modules ... [skip ci]

2024-07-01 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: 5.7 Commit: 4d1c41f2af5279f6ffbcba59f5b51e06989ba66d URL: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e06989ba66d Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-07-01T10:01:27+02:00 modules: readme files regenerated - modules ...

[sr-dev] git: new commits in branch 5.7

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
- URL: https://github.com/kamailio/kamailio/commit/6173af8d414de313b3ed8ced5e662e95022baf58 Author: Daniel-Constantin Mierla Date: 2024-07-01T09:19:24+02:00 sipcapture: use local static buffers for ip address and port - GH #3835 (cherry picked from commit

[sr-dev] git:5.8:3161964e: modules: readme files regenerated - modules ... [skip ci]

2024-07-01 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: 5.8 Commit: 3161964efba19e5e7bd730bf656d019cac2c6ed8 URL: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019cac2c6ed8 Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-07-01T09:16:18+02:00 modules: readme files regenerated - modules ...

[sr-dev] git:5.8:4fa5fc10: core: removed duplicated break

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: 4fa5fc10370d81d534d75b034322a6250c7e2557 URL: https://github.com/kamailio/kamailio/commit/4fa5fc10370d81d534d75b034322a6250c7e2557 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-01T09:11:38+02:00 core: removed duplicated

[sr-dev] git:5.8:ca3d4b35: cnxcc: check if final pulse is 0

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: ca3d4b3515024732805038509dd0d9f0b60ab273 URL: https://github.com/kamailio/kamailio/commit/ca3d4b3515024732805038509dd0d9f0b60ab273 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-01T09:12:43+02:00 cnxcc: check if final

[sr-dev] git:5.8:f59f980d: core: dns cache - check warnings made debug

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: f59f980d03b884f2494892eb4d007293b7ad4e34 URL: https://github.com/kamailio/kamailio/commit/f59f980d03b884f2494892eb4d007293b7ad4e34 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-01T09:12:30+02:00 core: dns cache - check

[sr-dev] git:5.8:7bf787d0: textopx/doc: fixed hard-to-read documentation for textopsx

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975 URL: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d1413b2b5c975 Author: Dragos Vingarzan Committer: Daniel-Constantin Mierla Date: 2024-07-01T09:10:51+02:00 textopx/doc: fixed hard-to-read

[sr-dev] git:5.8:70cf3ebd: textopsx: docs - note about @hf_value2 select

2024-07-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: 70cf3ebd2b52c341a90c9b9b6149985667a6b96c URL: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985667a6b96c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-01T09:11:16+02:00 textopsx: docs - note

[sr-dev] [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Oded Arbel via sr-dev
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for