[sr-dev] git:master:3333611a: core: cfg select - check res when getting the variable

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 611a3ef9078cbcb9867db88921f0c48fce1b URL: https://github.com/kamailio/kamailio/commit/611a3ef9078cbcb9867db88921f0c48fce1b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-26T19:50:40+02:00 core: cfg select -

[sr-dev] git:master:660a0192: xprint: return on mod init error case

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 660a019263b81d318700c205531bf4e042c912cf URL: https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e042c912cf Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-26T19:50:40+02:00 xprint: return on mod

[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
I just wanted to be sure that topos is not creating any issue, because `TH` should never leave Kamailio as a header. As it looks right now, some lenght is not computed right, because it adds more data than needs, which was in the buffer at some point in time. -- Reply to this email directly

[sr-dev] Re: [kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)

2024-07-25 Thread Daniel-Constantin Mierla via sr-dev
@sergey-safarov: this one is about RPM specs, can you do a review and merge if it is ok? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886#issuecomment-2249997743 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] git:master:a71bd9d9: cdp: fix use after free in transaction call backs

2024-07-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: a71bd9d9424456ef1167468c5bbbfd38b1099e89 URL: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd38b1099e89 Author: Rick Barenthin Committer: Daniel-Constantin Mierla Date: 2024-07-25T12:20:59+02:00 cdp: fix use after free in

[sr-dev] Re: [kamailio/kamailio] cdp: fix use after free in transaction call backs (PR #3931)

2024-07-25 Thread Daniel-Constantin Mierla via sr-dev
Merged #3931 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3931#event-13643517285 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:b4efe772: janssonrpcc: free new servers list on error

2024-07-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: b4efe7725728392d0c8921c006d6fbc6455e9b8f URL: https://github.com/kamailio/kamailio/commit/b4efe7725728392d0c8921c006d6fbc6455e9b8f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-25T10:59:15+02:00 janssonrpcc: free new

[sr-dev] git:master:a6c41571: core: cfg select - check res before initializing

2024-07-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: a6c415713bb209b03ff110d4ae891173d04ac471 URL: https://github.com/kamailio/kamailio/commit/a6c415713bb209b03ff110d4ae891173d04ac471 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-25T08:44:15+02:00 core: cfg select -

[sr-dev] git:master:7ba313f6: jsonrpcc: declare variables are the beginning of function

2024-07-24 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 7ba313f6f96ffa6042c163027c0c7bb65106fef7 URL: https://github.com/kamailio/kamailio/commit/7ba313f6f96ffa6042c163027c0c7bb65106fef7 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-24T10:43:18+02:00 jsonrpcc: declare

[sr-dev] git:master:796bcc03: jsonrpcc: free allocated pkg buffer on error

2024-07-24 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 796bcc038d7885e01dbad34abc68bf612062c533 URL: https://github.com/kamailio/kamailio/commit/796bcc038d7885e01dbad34abc68bf612062c533 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-24T10:37:21+02:00 jsonrpcc: free

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-23 Thread Daniel-Constantin Mierla via sr-dev
As far as I know, *reginfo* is not used (much, if at all) outside of ims world, so it might be related to *pua_reginfo*. Maybe you can look at pua_dialoginfo and see how it deals with TM callbacks. Overall, I am not completely satisfied with the TM callbacks system, there are many events

[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-23 Thread Daniel-Constantin Mierla via sr-dev
Are you using topoh module? If yes, can you try without it and see if P-Charging-Vector operations are ok? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3929#issuecomment-2245654758 You are receiving this because you are subscribed to this

[sr-dev] git:master:193a8457: osp: module relocated to archive

2024-07-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 193a8457af56dea6e7a1320df1d77d52e0951584 URL: https://github.com/kamailio/kamailio/commit/193a8457af56dea6e7a1320df1d77d52e0951584 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-23T12:54:27+02:00 osp: module relocated

[sr-dev] git:master:e9684113: Makefile.groups: removed osp module

2024-07-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: e96841130fd4d3a1e362170beef6b83e7a84f1cc URL: https://github.com/kamailio/kamailio/commit/e96841130fd4d3a1e362170beef6b83e7a84f1cc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-23T12:56:32+02:00 Makefile.groups:

[sr-dev] git:master:29510872: erlang: init xavps for safety destroy on error

2024-07-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 29510872607deb3238411b358c422d004fb307b7 URL: https://github.com/kamailio/kamailio/commit/29510872607deb3238411b358c422d004fb307b7 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-23T11:57:48+02:00 erlang: init xavps

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Good, thanks for testing and reporting back. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3917#issuecomment-2242964017 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Closed #3917 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3917#event-13601366680 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:7350a80a: nghttp2: duplicate reply status code in nghttp2_send_reply()

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 7350a80a1d4d121a75e12529553191c4a9038f56 URL: https://github.com/kamailio/kamailio/commit/7350a80a1d4d121a75e12529553191c4a9038f56 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-22T14:44:42+02:00 nghttp2: duplicate

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
5.8 series definitely does not have nghttp2 module. Maybe you used the git master branch. However, the coredump backtrace you attached two comments above points to: ``` 0x7fffef76f21f in ksr_nghttp2_send_reply (msg=0x1, rcode=0x55eeafb0, sbody=0x55efc770) at nghttp2_mod.c:328 ```

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
In the comments is written that the Kamailio version is 5.8, but nghttp2 module is not part of that series. Can you clarify about the version and how you use the module? -- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:34749ab1: utils: jump to error on pkg allocation failure

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 34749ab13b31504358761c964f794b283931394c URL: https://github.com/kamailio/kamailio/commit/34749ab13b31504358761c964f794b283931394c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-22T11:01:16+02:00 utils: jump to error

[sr-dev] git:master:5a1f80f2: xprint: check to avoid double free

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 5a1f80f266069dbc453b44a856f225c254e7c050 URL: https://github.com/kamailio/kamailio/commit/5a1f80f266069dbc453b44a856f225c254e7c050 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-22T10:02:09+02:00 xprint: check to

[sr-dev] git:master:7c06997a: tls: remove uselss pv format parsing in pv_parse_alt_name()

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 7c06997a1b6e77ae0642d369f532219dc35ef8e0 URL: https://github.com/kamailio/kamailio/commit/7c06997a1b6e77ae0642d369f532219dc35ef8e0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-22T10:23:31+02:00 tls: remove uselss pv

[sr-dev] git:master:79a668b8: tls: check lenght when parsing pv alt name

2024-07-22 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 79a668b8bdb0e085adb3581d718e5fd5ae73e2e4 URL: https://github.com/kamailio/kamailio/commit/79a668b8bdb0e085adb3581d718e5fd5ae73e2e4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-22T10:41:47+02:00 tls: check lenght

[sr-dev] git:master:20f2096d: core: removed unnecessary destroy

2024-07-19 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 20f2096d314253e7e74688da664de2830289a276 URL: https://github.com/kamailio/kamailio/commit/20f2096d314253e7e74688da664de2830289a276 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-19T20:00:12+02:00 core: removed

[sr-dev] git:master:dc71c0a5: topoh: 0-init alocated structures

2024-07-19 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: dc71c0a5791ebc1306648b5ed338613050e32f5c URL: https://github.com/kamailio/kamailio/commit/dc71c0a5791ebc1306648b5ed338613050e32f5c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-19T20:00:12+02:00 topoh: 0-init

[sr-dev] Re: [kamailio/kamailio] ims_qos_npn: fixed issues discovered by coverity (PR #3926)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
The commit message has to describe what changes in the code were done, to be useful for release changelog and understand better the changes, not tell what tool was used for detecting or analyzing,. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Can you explain in more details what is happening now and how it changes with this PR? Also, I noticed that instead of a reference in an output parameter, now it makes a hard copy: ``` - *from = >su; + memcpy(*from, >su, sockaddru_len(si->su)); ```

[sr-dev] Re: [kamailio/kamailio] tcpops: fix memory leak in $tcp(conid) (PR #3924)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3924#issuecomment-2236273477 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:acf50d86: tcpops: fix memory leak in $tcp(conid)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: acf50d86b502af36e3635d61745feaa5c577231d URL: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa5c577231d Author: Dennis Yurasov Committer: Daniel-Constantin Mierla Date: 2024-07-18T13:31:26+02:00 tcpops: fix memory leak in

[sr-dev] Re: [kamailio/kamailio] tcpops: fix memory leak in $tcp(conid) (PR #3924)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Merged #3924 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3924#event-13554195461 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:84ea36b4: core: remove unnecessary check after using the structure

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 84ea36b4b79c07c4fc0a8c9e119184433353764e URL: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e119184433353764e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-18T12:29:05+02:00 core: remove

[sr-dev] git:master:15b2a546: core: set digit 0 in the md5 buffer in case of error inside char_msg_val()

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 15b2a5467f11e009ae4efad1ee29af860326095f URL: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af860326095f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-18T12:17:10+02:00 core: set digit 0 in

[sr-dev] git:master:a471d34d: core: init res inside select_cfg_var()

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: a471d34d6162387a1427f5d0c5b3c6079a2b0bdc URL: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c6079a2b0bdc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-18T12:00:47+02:00 core: init res inside

[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
I had no time for a proper review, it seems rather important change considering that logging is critical component. Does it affect in any way the modules `log_custom` or `log_systemd`? Maybe other can review as well and make remarks on this change. -- Reply to this email directly or view it

[sr-dev] Re: [kamailio/kamailio] siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (PR #3919)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Merged #3919 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3919#event-13551654157 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (PR #3919)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Thanks, merging it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3919#issuecomment-2235894091 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] sqlops: Don't truncated sql command when logging. (PR #3903)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
It can be merged. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3903#issuecomment-2235889858 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] allow address 'grp' 'mask' 'port' fields to be a mysql BIGINT (PR #3923)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Note also that the git commit message has to follow the format detailed at: - https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] allow address 'grp' 'mask' 'port' fields to be a mysql BIGINT (PR #3923)

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
@miconda commented on this pull request. > @@ -208,12 +208,12 @@ int reload_address_db_table(address_tables_group_t *atg) "address table - NULL value not permitted\n"); goto dberror; } - if((VAL_TYPE(val +

[sr-dev] git:master:8c3b5ab3: dispatcher: remove reference to MI in comments

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 8c3b5ab3818c86b90b02e20aa4631654e0b51745 URL: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa4631654e0b51745 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-18T09:09:01+02:00 dispatcher: remove

[sr-dev] git:master:aa79588c: dispatcher: added ocidx to the rpc response

2024-07-18 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: aa79588ceacaaae118230bd06b0eb7aadf9b31f3 URL: https://github.com/kamailio/kamailio/commit/aa79588ceacaaae118230bd06b0eb7aadf9b31f3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-18T09:09:01+02:00 dispatcher: added

[sr-dev] git: new commits in branch master

2024-07-17 Thread Daniel-Constantin Mierla via sr-dev
- URL: https://github.com/kamailio/kamailio/commit/fa792054a58126b57797675aadc4f0e862316dfd Author: Daniel-Constantin Mierla Date: 2024-07-16T20:27:27+02:00 core: pvapi - use defined types for pv_get_avp_name() name and flags - URL:

[sr-dev] Re: [kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)

2024-07-16 Thread Daniel-Constantin Mierla via sr-dev
Not being the developers of the custom global variables, I have very little experience with them, and I couldn't spot anything wrong quickly. The crash seems to be when checking if one of these variables was changed or not. As alternative suggestion, if you don't need to change them, then

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-16 Thread Daniel-Constantin Mierla via sr-dev
My previous commit was not related to this issue, it was a cleanup in a function used at startup. As I said in the comment above, get the backtrace with gdb from the generated core file, do not run kamailio with gdb. After it crashes and the core file is generated, use gdb to extract the

[sr-dev] git:master:2ce75082: dispatcher: docs - listed flag 32

2024-07-16 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 2ce75082134a7e03c29e3096316cee5ad455d9af URL: https://github.com/kamailio/kamailio/commit/2ce75082134a7e03c29e3096316cee5ad455d9af Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-16T10:20:17+02:00 dispatcher: docs -

[sr-dev] git:master:abdd0bfa: dispatcher: new flag 32 to not send ping to destination

2024-07-16 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: abdd0bfaf6a2e50fb96e2f522f03a65f331b57b5 URL: https://github.com/kamailio/kamailio/commit/abdd0bfaf6a2e50fb96e2f522f03a65f331b57b5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-16T10:10:06+02:00 dispatcher: new flag

[sr-dev] git:master:eda03789: core: remove unnecessary cleanup when locating a module

2024-07-16 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: eda03789f693bb72ec4ee05a8b2b4723e5080504 URL: https://github.com/kamailio/kamailio/commit/eda03789f693bb72ec4ee05a8b2b4723e5080504 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-16T08:27:42+02:00 core: remove

[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Over all, it should be ok to merge, just with the note that it is preferred to declare the variable at the beginning of the block. A few in this PR are in the middle. It is ok to have them at the beginning of the functions or at the beginning of the blocks, e.g.,: ``` if(cond) { int v;

[sr-dev] Re: [kamailio/kamailio] nghttp2 module causing Kamailio P-CSCF to crash on connect (Issue #3917)

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
I have just tested on Ubuntu 22.04 and all seems fine. What is the libnghttp2 version? Anyhow, I have no Ubuntu 24.04 at hand that can test with. The core file is not useful without the entire system where it was generated. You have to extract the full backtrace with `gdb` from it and post it

[sr-dev] Kamailio Developers Meeting, Nov 19-20, 2024, in Dusseldorf

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Hello, Kamailio SIP Server project is organizing another meeting of its developers and community members during November 19-20, 2024 (Tue-Wed), hosted again by sipgate.de in Dusseldorf, Germany. The event is intended to facilitate the interaction between Kamailio developers and contributors in

[sr-dev] git:master:f92fe42d: nghttp2: free the addr info on listen failure

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f92fe42dc6c8d3d5b79cf6543b387501a41c09b3 URL: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b387501a41c09b3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-15T08:24:59+02:00 nghttp2: free the

[sr-dev] git:master:f2a7a3c0: dispatcher: remove unnecessary comparisons for unsigned

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 URL: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-14T18:56:20+02:00 dispatcher: remove

[sr-dev] git:master:d5076b55: evrexec: remove unnecessary safety exit loop

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d5076b557728b3f9d80df391ae71e2eab2c896dc URL: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2eab2c896dc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-14T18:56:20+02:00 evrexec: remove

[sr-dev] Re: [kamailio/kamailio] Possible crash related to src/core/parser/digest/param_parser.c (Issue #3911)

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Thanks for those further details! Closing it as tests cannot reproduce it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911#issuecomment-2226160715 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] Possible crash related to src/core/parser/digest/param_parser.c (Issue #3911)

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Closed #3911 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911#event-13491012306 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:c9714586: rls: remove unnecessary assignment

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: c97145862119e9001874cd07de9b20ad8e96ff54 URL: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20ad8e96ff54 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-12T11:49:10+02:00 rls: remove

[sr-dev] git:master:fc8bee5b: pua: use long for time value diff operation

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: fc8bee5b87e95e43bda2635e65457b2025eab6f9 URL: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2025eab6f9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-12T12:05:40+02:00 pua: use long for

[sr-dev] git:master:214eaaa5: rtpengine: check fd before closing

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 214eaaa5b7a0308fd7384a41e97b1204d71c93de URL: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b1204d71c93de Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-12T09:45:53+02:00 rtpengine: check fd

[sr-dev] git:master:87e1a4a7: stun: check message len for response

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 87e1a4a7f5d565a59a362f22e9372697f2f2f2af URL: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e9372697f2f2f2af Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-12T08:06:36+02:00 stun: check message

[sr-dev] git:master:1e1ad4e7: sdpops: proper detect CR or LF

2024-07-12 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 1e1ad4e74822881bb4d9cc2e9bd0f53e845bb48b URL: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53e845bb48b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-12T08:01:37+02:00 sdpops: proper detect

[sr-dev] git:master:1c2b3361: tmx: t_precheck_trans() - explicit catch of internal return 0

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 1c2b33615888dede0ea8abc098f6f910f810366b URL: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f910f810366b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T21:30:33+02:00 tmx:

[sr-dev] git:master:e2193b9c: htable: do not print item name before is computed

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: e2193b9cd7f59377c54e0424c0d4a1628a5a60de URL: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a1628a5a60de Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T19:38:24+02:00 htable: do not print

[sr-dev] git:master:0a9cb4bf: htable: updated duplicated rm op id

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 0a9cb4bf74bf11af88e93c1512053008d94aff13 URL: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c1512053008d94aff13 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T19:31:23+02:00 htable: updated

[sr-dev] git:master:d7466474: core: counters - init local global variables

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d7466474bdc86b2b0d0872c5fd41d743ec1c7d66 URL: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d743ec1c7d66 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T15:44:07+02:00 core: counters - init

[sr-dev] git:master:48730820: core: action - logical OR for log() parameter types check

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 487308204d2674368a16ea913137a368761dd0b2 URL: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a368761dd0b2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T15:27:37+02:00 core: action -

[sr-dev] git:master:fffe7aae: core: counters - declare global cnts_no as unsigned short

2024-07-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: fffe7aaecc41b8986eae342ce693bde87cdc20bc URL: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde87cdc20bc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-11T15:50:48+02:00 core: counters -

[sr-dev] Re: [kamailio/kamailio] Outdated OpenSIPS Sources in Kamailio Project Lack Security Fixes (CVE-2023-28098) (Issue #3911)

2024-07-10 Thread Daniel-Constantin Mierla via sr-dev
Thanks for reporting a potential issue of our project! Just for clarification, Kamailio does not contain code from any other project in this case, I tracked the related code to be dated back to 2002 (when the project had its original name `SER` and the project you named didn't exist). The other

[sr-dev] git:master:22880dbb: core: log message that #!endif requires EoL after it

2024-07-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 22880dbb2171c2763b4df2731be49f208fde7e8c URL: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f208fde7e8c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-10T14:18:30+02:00 core: log message

[sr-dev] git:master:bd98aadf: corex: destroy nio_msg_avp avp after event_route[network:msg]

2024-07-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: bd98aadf9803c0c0789680d5ca781e86499f55cd URL: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e86499f55cd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-10T14:01:23+02:00 corex: destroy

[sr-dev] Re: [kamailio/kamailio] core: Improved URN parsing according to RFC8141 (PR #3909)

2024-07-09 Thread Daniel-Constantin Mierla via sr-dev
Thanks, I think it is ok to merge. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3909#issuecomment-2217448133 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] Re: [kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)

2024-07-09 Thread Daniel-Constantin Mierla via sr-dev
It might be an incompatibility due to more recent version of libhiredis. I have no system where I can try with libshiredis 1.2.0, maybe others can comment or you can try with older versions of hiredis lib, like the one in the debian 12 or ubuntu 22.04. -- Reply to this email directly or view

[sr-dev] git:master:501b7da6: ndb_redis: dpcs - updated link to hiredis library

2024-07-09 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 501b7da6daaff354b000837b54bdb591947ac80a URL: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb591947ac80a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-09T13:41:57+02:00 ndb_redis: dpcs -

[sr-dev] Re: [kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)

2024-07-09 Thread Daniel-Constantin Mierla via sr-dev
Are you using custom global variables (parameters)? - https://www.kamailio.org/wikidocs/cookbooks/5.8.x/core/#custom-global-parameters -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3905#issuecomment-2217402447 You are receiving this because

[sr-dev] Re: [kamailio/kamailio] Base58 not decoding correctly (Issue #3907)

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Closed #3907 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3907#event-13421729754 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] Base58 not decoding correctly (Issue #3907)

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Pushed a commit to compute the length after decode, basic tests look ok. It is in master branch now, to be backported. Should you encounter issues with it, comment to reopen. -- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:9d923764: core: basex - compute lenght for base58 decode

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 9d923764747ff36152fc930da66e972201516b7b URL: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972201516b7b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-08T12:08:13+02:00 core: basex - compute

[sr-dev] Re: [kamailio/kamailio] kamailio 5.7.6 startup (Issue #3908)

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
The warning can be ignored, has no relevant impact. Actually, it was changed to a debug message later, but somehow backporting was overlooked to 5.7 branch, I have just done it. You can use now latest git branch 5.7 (deb packages will build over the next night and be available in the nightly

[sr-dev] Re: [kamailio/kamailio] kamailio 5.7.6 startup (Issue #3908)

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Closed #3908 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3908#event-13420025320 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:5.7:64f0c3f3: db_mysql: switch warn to dbg for log messages for opt_ssl_mode

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 64f0c3f3979de7a40732067792d89c6d3b1c23d4 URL: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6d3b1c23d4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-07T09:35:27+02:00 db_mysql: switch warn to

[sr-dev] git:5.7:184aaf99: db_mysql: switch warn to dbg for log messages for opt_ssl_ca option

2024-07-08 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 184aaf991b6ad74b63a7f8724058cd4066f3bbd3 URL: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4066f3bbd3 Author: Victor Seva Committer: Daniel-Constantin Mierla Date: 2024-07-07T09:35:36+02:00 db_mysql: switch warn to dbg for log

[sr-dev] Re: [kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Closed #3759 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3759#event-13404816026 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
The commit e3e6fd75bdd688acebf0ec8a1b7efa6fcada1de6 allows a way to disable the checks, if one wants to add further improvements, then PRs can be made. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3759#issuecomment-2210681821 You are

[sr-dev] Re: [kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Should be fixed, as reported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3767#issuecomment-2210675972 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] Re: [kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Closed #3767 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3767#event-13404773866 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
The rpc commands do not have to be about dmq itself, but any other core or module parameter. Isn't there any rpc command executed to change Kamailio parameter values? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3905#issuecomment-2210616280

[sr-dev] Re: [kamailio/kamailio] ndb_redis: Error when receiving 'MOVED' response from redis-cluster with TLS (Issue #3894)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Closed #3894 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3894#event-13404172621 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] ndb_redis: Error when receiving 'MOVED' response from redis-cluster with TLS (Issue #3894)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
The local buffers used to build the new server spec after the MOVED were not large enough for the address returned. I increased the size, which should be now for any decently large server address. The commit is in master branch, it will be backported soon. I am closing this one, should there

[sr-dev] git:master:6f434afc: ndb_redis: larger size for buffers to create server specs on cluster redirect

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 6f434afc414b7f5b66374a124138990f7a3dd1d1 URL: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990f7a3dd1d1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-05T11:47:34+02:00 ndb_redis: larger

[sr-dev] git:master:4d2988a7: ndb_redis: print server spec lenght in error message

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 4d2988a79d992ed8f3ce4cffa6c387ef0425be94 URL: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387ef0425be94 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-05T10:41:09+02:00 ndb_redis: print

[sr-dev] Re: [kamailio/kamailio] [Warning] Aborted connection 203 to db: 'kamailio' user: 'kamailio' host: 'localhost' (Issue #3906)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Follow the provided template to report an issue (provide all the data requested in the template in the appropriate format) or use sr-us...@lists.kamailio.org mailing list to figure out if it is something related to the configuration file. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] [Warning] Aborted connection 203 to db: 'kamailio' user: 'kamailio' host: 'localhost' (Issue #3906)

2024-07-05 Thread Daniel-Constantin Mierla via sr-dev
Closed #3906 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3906#event-13401550632 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:91d6a131: etc/kamailio.cfg: set tls_threads_mode to 2

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 91d6a131ab9d3e58a1560c6305af542c92c2b19f URL: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542c92c2b19f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-04T16:23:39+02:00 etc/kamailio.cfg: set

[sr-dev] git:master:234f2ae0: tls: docs - note about tls_threads_mode core parameter

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 234f2ae07a26af8948a176d10358a0b7039ad1a2 URL: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b7039ad1a2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-07-04T16:20:47+02:00 tls: docs - note

[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
Any reason that: ``` ksr_logdata_t __kld = {0}; ``` I replaced with: ``` ksr_logdata_t __kld = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; ``` Also, `asprintf()` allocates memory, it is freed somewhere? Then, when this new mechanism is used and what is the benefit? Can you provide some examples? --

[sr-dev] Re: [kamailio/kamailio] sqlops: Don't truncated sql command when logging. (PR #3903)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
It is not a bug, it was done on purpose to limit the size of logging message, because there can be rather long queries some time and can fill the logs or slow down. If you find 64 too short, you can eventually double it. Alternative you can add a modparam to set the max length to be printed.

[sr-dev] Re: [kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
Do you run some rpc commands to change values for global or module parameters? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3905#issuecomment-2208437876 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
You have to compile the module with `Q=0` to see if the `-DWITH_SSL` compile flag is provided to the compiler: ``` cd src/modules/db_redis make clean make Q=0 ``` The output during compilation should be more verbose, you can paste it here if you want to be analyzed. -- Reply to this email

[sr-dev] Re: [kamailio/kamailio] Kamailio core dump v5.6 with cncxx module (Issue #3859)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
You should check that the final pulse variable does not have 0 value. For further discussions, use sr-users mailing list. I am closing this one, commit being backported. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] Kamailio core dump v5.6 with cncxx module (Issue #3859)

2024-07-04 Thread Daniel-Constantin Mierla via sr-dev
Closed #3859 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3859#event-13391289464 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

  1   2   3   4   5   6   7   8   9   10   >