Closed #2784.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2784#event-4958158832___
Kamailio (SER) - Development Mailing List
https://github.com/kamailio/kamailio/blob/ecc2cc69b08e797ca954af233c229ed44475ce33/src/modules/nathelper/nathelper.c#L1699
First of all, using `'a=rtcp'` in `replace_sdp_ip()` violates a principle of
SoC ([separation of
concerns](https://en.wikipedia.org/wiki/Separation_of_concerns)).
@miconda I do not understand the reasons for this bulling. I'm not trying to
offend anyone. If you are ready to continue, I am ready to explain in more
detail what problems I have found and fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
It violates the logical separation of functions.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2784#issuecomment-863889352___
Kamailio
It's work badly for 'o=' and 'c=', doesn't return an error on incorrect lines.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The main reason of my changes: #2769 is buggy and dirty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2784#issuecomment-863884625___
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for
Hello All,
I'll check it out soon.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2737#issuecomment-858826109___
Kamailio (SER) -
The previous version only worked with IPv4. I've fixed it, but haven't test it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for
Crash with `CRYPTO_THREAD_lock_free()` fixed
[FreeBSD Bugzilla – Bug 255486
](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255486)
The problem was that the implementation of the pthreads library is different.
`pthread_rwlock_init()` function was allocating memory in a non-shared area.
--
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
12 matches
Mail list logo
