> With this PR, I understood you actually want to replace the default
> _ksr_slog_func(...)
That is right.
> so I added the option to be able to set the _ksr_slog_func.
Thanks!
I'll try to submit another PR with improvements to the `LOG_XX` macro as
mentioned above for a uniform logging entr
> Source file and line number are part of the structure passed to the
> slog-function:
I understand, my question was about the possibility of adding a flavour of the
`LOG_XX` macro that takes file/line as arguments and populates the slog
structure rather than always using `__FILE__`/`__LINE__`.
@miconda thanks for looking into this! Indeed it seems that structured logging
takes care of most of our needs. But I'm not sure whether it would allow us to
do uniform logging from config files. Let me explain: right now we're using
custom log function from the PR and we're "manually" resolving
> Does it affect in any way the modules log_custom or log_systemd?
Hi @miconda , did the above answer provide sufficient details for you?
> it seems rather important change considering that logging is critical
> component
Perhaps you would us to make any additional changes to further isolate th
> Does it affect in any way the modules log_custom or log_systemd?
It does not. Mentioned modules rely on the `_km_log_func` (set via
`km_log_func_set`) while this patch uses `_km_custom_log_func` (set via
`km_custom_log_func_set`) and makes no changes to the `_km_log_func`. The only
downside
Hi @miconda , is there anything else we need to do in order to ensure this PR
is merged or will the Kamailio team take it from here?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3909#issuecomment-313191
You are receiving this because you are
Hi @miconda ,
thanks for your feedback!
Regarding `ksr_logdata_t`, most likely it got flagged by some static checker,
but we've re-tested the original version and couldn't pin-point which exact
check/rule triggered this.
Regarding the `asprintf` - thanks for spotting the memory leak! We've ne
