Merged #3992 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3992#event-14764287142
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
> I will double check that part of the code, since I don't think a lock get is
> necessary. It only updates a value inside a node, inside the list of nodes,
> but not changes the list links at all. (this in another PR)
I think you're right. However, you would need a memory fence to safely access
Merged #3956 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3956#event-14102545609
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
> I changed all function names to rtpengine_xxx . This way is better for
> readability and fixes the problem.
As long as there are no other modules that will ever use this binding ... 😆
(Welcome to one of the only two hard things in computer science)
Anyway, fine with me
--
Reply to this emai
@rfuchs commented on this pull request.
>
typedef struct rtpengine_api
{
rtpengine_start_recording_f start_recording;
rtpengine_answer_f answer;
rtpengine_offer_f offer;
- rtpengine_delete_f delete;
+ rtpengine_delete_f _delete;
> Thanks for the review. I
@rfuchs commented on this pull request.
>
typedef struct rtpengine_api
{
rtpengine_start_recording_f start_recording;
rtpengine_answer_f answer;
rtpengine_offer_f offer;
- rtpengine_delete_f delete;
+ rtpengine_delete_f _delete;
Any reason for the undersc
@rfuchs commented on this pull request.
> +typedef int (*rtpengine_answer_f)(struct sip_msg *msg, str *str);
+typedef int (*rtpengine_answer0_f)(struct sip_msg *msg);
+typedef int (*rtpengine_offer_f)(struct sip_msg *msg, str *str);
+typedef int (*rtpengine_offer0_f)(struct sip_msg *msg);
+typed
No objections from my POV
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296400629
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - De
Merged #3899 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3899#event-13365138400
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
LGTM, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3899#issuecomment-2203018343
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mai
You should be able to just run `clang-format` over your edited code and that
should reformat it to make the format checker happy.
There are some function calls (`close()` for example) between testing the
`errno` value and printing out the log line. These functions might reset
`errno` to somethi
Thank you
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3896#issuecomment-2198617071
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mail
Closed #3896 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3896#event-13342563166
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Devel
Merged #3898 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3898#event-13342561791
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
> Then how about:
>
> * `disabled`: `boolean` - set to `true` if the RTPEngine was disabled by an
> RPC call
> * `active`: `boolean` - set to `true` if the module is actively using this
> RTPEngine (i.e. the internal `rn_disabled` flag is set to 0). This will be
> always set to `false` if `disa
FWIW this is legacy from when the RPC code was converted from the old mi
interface to the new one. Looks like `recheck_ticks` is also affected by this.
If you feel like taking a stab at improving then, feel free. I don't mind a
patch that changes the output to something more sensible (although i
Closed #3854 as completed via 48317d3180e8ec67d24862ebcbbb80ab887ff5bd.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3854#event-13026141618
You are receiving this because you are subscribed to this thread.
Message ID: _
Module: kamailio
Branch: master
Commit: 48317d3180e8ec67d24862ebcbbb80ab887ff5bd
URL:
https://github.com/kamailio/kamailio/commit/48317d3180e8ec67d24862ebcbbb80ab887ff5bd
Author: Richard Fuchs
Committer: Richard Fuchs
Date: 2024-06-03T15:49:12-04:00
rtpengine: use extract_body with read_sdp_pv
Module: kamailio
Branch: master
Commit: 5b0e9e8cb818e1de0c88f9b505a5813147629499
URL:
https://github.com/kamailio/kamailio/commit/5b0e9e8cb818e1de0c88f9b505a5813147629499
Author: Donat Zenichev
Committer: Richard Fuchs
Date: 2024-03-21T11:40:39-04:00
rtpengine: format files in clang format
Fo
Module: kamailio
Branch: master
Commit: 779654d3654586dc1b2ac64b9ea6e7ce1dae75c8
URL:
https://github.com/kamailio/kamailio/commit/779654d3654586dc1b2ac64b9ea6e7ce1dae75c8
Author: Donat Zenichev
Committer: Richard Fuchs
Date: 2024-03-21T11:40:39-04:00
rtpengine: fix doc typos
Fix doc typos in
Closed #3788.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3788#event-12202438232
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
Merged as 5cd02f56 and c6fff3a531
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3788#issuecomment-2012561785
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (S
Module: kamailio
Branch: master
Commit: c6fff3a531740e648615a6e6223088693ecdccb9
URL:
https://github.com/kamailio/kamailio/commit/c6fff3a531740e648615a6e6223088693ecdccb9
Author: Donat Zenichev
Committer: Richard Fuchs
Date: 2024-03-21T11:04:53-04:00
rtpengine: update documentation in regards
Module: kamailio
Branch: master
Commit: 5cd02f5653e9b9f523a62a0dae78b801f962ce8e
URL:
https://github.com/kamailio/kamailio/commit/5cd02f5653e9b9f523a62a0dae78b801f962ce8e
Author: Donat Zenichev
Committer: Richard Fuchs
Date: 2024-03-21T11:04:53-04:00
rtpengine: add flags processing on the daem
I'll merge this if there are no objections @miconda
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3788#issuecomment-2012106700
You are receiving this because you are subscribed to this thread.
Message ID:
> Unfortunately it does not seems to work at least with "codec-accept=XXX":
> kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key
> encountered: 'codec-accept'
Right, you have to use `codec-flag-...` (dash instead of equals) for this to
work.
--
Reply to this email d
These flags should work without this patch, as they would just be put into the
`flags` list of strings and rtpengine does parse them out of there.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887531455
You are receiving this b
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887427690
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing Lis
28 matches
Mail list logo
