Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-10-03 Thread Tomohare
Closed #3255. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3255#event-7505354609 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing L

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-10-03 Thread Tomohare
> If I am not misunderstanding something, i see no problem for such situation: > the domain can also be set to a certain value `domainA`, it is not required > to be the same to sd_domain Sorry for the delay, I finally understood what you meant, but as I see it, passing `sip:group_id@domain` as

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Wouldn't it work in the old version by providing `sip:group_id@domain` as the > second parameter of `sl_lookup()`, with the `username` set to `group_id` > inside database table? Yes, I failed to communicate the idea: that a group could have multiple domains. For example: group A has speed di

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Ok, thanks - now its more clear. There might be more review comments from > people more familiar about this module. One remark about the SQL changes - > this needs to be done not in the actual SQL files, but in the XML template > available in lib/srdb1/schema. You should probably also incremen

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
@Tomohare pushed 2 commits. 92836699af2949ff9181d3a99d838099667cf654 speeddial: allow search uri of speed dial by group f8a15c42bc21990966aeb47c1ac2345d199b163a kamctl: update speeddial schema -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3255/files

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
> Thanks for the pull requests. Maybe I missed something, but it seems that the > actual implementation of the new functions is missing? if its still work in > progress, no problem just let us known. Sorry 🙇 Here are the missing modifications. -- Reply to this email directly or view it on GitH

Re: [sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare
@Tomohare pushed 1 commit. 1a2122c875995f3be6939f38d555838a6f234605 speeddial: allow search uri of speed dial by group -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3255/files/b5547542c327c363824fdd0b822cd9aada132b5c..1a2122c875995f3be6939f38d555838a6f234605 You are

[sr-dev] [kamailio/kamailio] speeddial: allow search uri of speed dial by group (PR #3255)

2022-09-28 Thread Tomohare