Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-21 Thread Federico Cabiddu
The patches applied cleanly on both branches, I needed a couple of days to test. I've cherry-picked the commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2132#issuecomment-5570

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Henning Westerholt
If the patch applies cleanly to 5.2 branch, a backport should be ok there as well. If there are other (functional) changes necessary before it could be applied, then it would be better to ask people to upgrade in this case to 5.3.x -- You are receiving this because you are subscribed to this th

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Federico Cabiddu
Merged #2132 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2132#event-2807447284___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Federico Cabiddu
I agree that the usage of http/2 will become more and more common. If you agree, I'll also backport it to 5.2.x since this is still a supported version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kama

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Daniel-Constantin Mierla
It can be merged. Probably can be considered for backporting at least for 5.3.x, otherwise over the time I expect won't work to do http queries in more and more many cases. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ht

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-16 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 17be36102e3a1c286c69a5da193dd8405000ab62 core: add support for parsing http/2 replies parsing -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2132/files/b375c5d4cb87e8f826c764cf63237

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-15 Thread Federico Cabiddu
grumvalski commented on this pull request. > @@ -47,7 +47,10 @@ #define SIP_VERSION_LEN 7 #define HTTP_VERSION "HTTP/1." -#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1) +#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1) Yes, it was not done intentionally. I'll fix and force push if you

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-15 Thread Daniel-Constantin Mierla
miconda commented on this pull request. > @@ -47,7 +47,10 @@ #define SIP_VERSION_LEN 7 #define HTTP_VERSION "HTTP/1." -#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1) +#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1) Was the above change somehow done unintentionally? Because I see no re

[sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-15 Thread Federico Cabiddu