Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-07 Thread Julien Chavanton
`dlg.dump` >> `dlg.dump_file` was not updated in the commit message but it was in the docs ... Not a real concern. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-07 Thread Julien Chavanton
Merged #2272 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2272#event-3212246013___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-07 Thread Julien Chavanton
last modifications and docs tested once more before merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2272#issuecomment-610711144___

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-07 Thread Julien Chavanton
I also hope we can find time to improve dlg.list to be much faster, this was a bigger project ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-07 Thread Daniel-Constantin Mierla
Thanks, I am fine to merge it with one more remark. Thinking a bit more about the rpc command name, I would suggest to change it to `dumpfile` or something else to suggest is writing to a file. Actually I would like to have something different that `dump` because other modules use this name to

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-06 Thread Julien Chavanton
done -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2272#issuecomment-610059625___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-06 Thread Julien Chavanton
@jchavanton pushed 1 commit. 8b8af03b7de23aa2c1eedbbcf7f8cb5dfcef48bc dialog: adding dlg.dump -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-06 Thread Julien Chavanton
@jchavanton pushed 1 commit. 7821f5804d0d4c2fdd69b4c5bfa5895d620c6976 dialog: adding dlg.dump -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-05 Thread Daniel-Constantin Mierla
Yes, it is preferred to use the included srjson.{c,h} functions, because it doesn't introduce any external dependency. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-04 Thread Julien Chavanton
Missed this one, I guess I should use it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2272#issuecomment-609074982___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-04 Thread Daniel-Constantin Mierla
Is anything particular that jansson offers for this case compared with the internal srjson (which is based on cjson lib), see src/core/utils/srjson.{c,h} ? Dialog module already uses srjson for profile storage and you can use srjson either with system malloc or internal memory. -- You are

Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-03 Thread Julien Chavanton
Hopefully we can also optimize JSON-RPC responses to support something that fast and use pipe-lining to make sure memory will never be a concern. The dialog state can be quite valuable for platform developers, we can imagine many use cases. I understand this ca already be use however it is not

[sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

2020-04-02 Thread Julien Chavanton
alternative command to output dialogs data to file, far much faster than dlg.list !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to