Merged #1877 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1877#event-2193166519___
Kamailio (SER) - Development Mailing
OK, merging, thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1877#issuecomment-471449090___
Kamailio (SER) - Development Mailing
I removed the change from this commit and focused this PR entirely on the
feature addition.
I'd have to do some more investigation to understand full scope. I'll
reconsider a PR for that when I better understand. Thanks!
--
You are receiving this because you are subscribed to this thread.
Iirc, the attrs set to empty string was an workaround to be sure the AVPs with
attrs value do not get shifted (associated) with a wrong destination. The AVP
cannot be null, so if among selected destinations some of them were with attrs
and some without, then the number of AVPs with attrs was
Hi, thanks for taking a look. I changed it since I saw that pack_dest checks if
attr is not NULL and now removing and adding through rpc both set it to NULL
instead of creating a zeroed string when calling that function. It looks a bit
more uniform to me.
--
You are receiving this because you
Hello, thank you for the pull request. I had a quick look to the diff - looks
fine for me. One question though, I noticed that you changed also the attr str
handling in ds_add_dst() function, why was this changed as well?
--
You are receiving this because you are subscribed to this thread.
Pre-Submission Checklist
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils,
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README
