Pre-Submission Checklist
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils,
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for mo
Looks good - thanks!
Would it be sensible to add a module parameter to configure the number of
failed pings before a node is considered dead (defaulting to 1 to preserve
current behaviour)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vie
Definitely :)
Should I merge and backport this one?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1840#issuecomment-461376790___
Kamailio
I am against backporting because it changes current behaviour and is not
strictly a bug fix.
For master, I would still prefer the option to preserve current behaviour (with
modparam) in case it is essential for some users to fail quickly.
--
You are receiving this because you are subscribed to
I discovered the problem exactly because I wanted to fail quickly, having a
global fr_timer of 5 s.
IMHO the patch as it is doesn't affect the capability to fail quickly since a
node is taken off the nodelist for message broadcasting immediately, except for
the ping. I would say that it affects
Okay - can be merged in that case.
Thanks again!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1840#issuecomment-461413719___
Kamailio (
Mergin, thank you :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1840#issuecomment-461418016___
Kamailio (SER) - Development Mailing Li
Merged #1840 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1840#event-2124046795___
Kamailio (SER) - Development Mailing Lis
