Closed #2209.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2209#event-5190508928___
Kamailio (SER) - Development Mailing List
Because of there are a lot of changes in source code, i have to close this PR
and create new one later.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Yes, As @henningw is mentioned, some rework substancially is doing right now, I
don't think it's over for this branching.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@miconda I had a conversation with the author of the pull request, he wants to
rework the code substancially. I don't think this should be merged in this form.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Short note to say that probably branching of 5.4 will happen soon, if you want
this merged for 5.4.x release series, then it has to be made ready during the
next days.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@henningw - because of developing lreproxy engine, i had not more time. Now, i
could come back to hiops module developing and completing it.
I will update it next days.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mojtabaesfandiari - any update on this pull request? I think the still open
topics are related to docs and the asn1 definitions. If you can't provie the
asn1 definitions for some reasons, let us know.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
The basic asn definition file erlated to Lawful Interception is available in
below link:
https://www.etsi.org/deliver/etsi_ts/101600_101699/101671/03.15.01_60/
But based on Table 7.1 and 7.3 in TS.133.108 for IMS networks, Just some of
hiX-parameters (The X parameter is refered to 1,2,3
As mentioned, you can finish the module docs and I can merge it manually, also
removing the discussed files and adapting the Makefile.
Any comment about the question related to the asn definition files?
--
You are receiving this because you are subscribed to this thread.
Reply to this email
As @henningw mentioned, I should remove asn1c system files from the main
module source. Another way that i am thinking about it is using asn1c system
file just during compiling the module and remove all them after that.
It's documents is ready now, So i should get time to publish it. I'll get
A few things to add from my side:
- many files are generated from an ASN.1 definition file (e.g. from
HI1NotificationOperations.asn), but the asn1 files are missing. It would be
great if they could be added, otherwise future extensions are difficult.
- there is a CMake file included
Thanks for the contribution. The patch is quite large and given the scope of
the module, probably not many can spend time to do a deep review of the code.
If nobody adds more, it can be merged, but first it needs the documentation of
the module (the docbook xml files in doc/ subfolder and the
12 matches
Mail list logo
