[sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-23 Thread zenichev
A simple change, which allows to check, if a coming request matches not only by an IP address and a transport protocol, but also using the source port of a request. Improvements are done for the following functions of the lcr module: - from_any_gw() - from_gw() Back compatibility provided, hence

Re: [sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-23 Thread lgtm-com[bot]
This pull request **introduces 2 alerts** when merging 14e6fc80b3d2389567c73c4a2196bf8e6d92d8d2 into 5ad81a45bb28ca419d9285cc59816db0fa1afefd - [view on LGTM.com](https://lgtm.com/projects/g/kamailio/kamailio/rev/pr-44137a6742f3d77205026dc4769f3d6ef4bed497) **new alerts:** * 2 for Comparison r

Re: [sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-24 Thread Henning Westerholt
Thanks for the pull request. There are two alerts mentioned above (check for < 0 for an unsigned int is obviously not necessary), please have a look to it. After fixing you can push to the branch, no need for a new pull request. -- You are receiving this because you are subscribed to this threa

Re: [sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-24 Thread zenichev
@zenichev pushed 1 commit. d8583d6ce1748c1ac8494616fced507b01dd4375 lcr: remove excessive checks for the 'src_port' accuracy -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2832/files/14e6fc80b3d2389567c73c4a219

Re: [sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-24 Thread juha-h
I haven't tested the new feature, but from backwards compatibility point of view, the implementation looks good to me. Thus I have nothing against the merge. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.c

Re: [sr-dev] [kamailio/kamailio] lcr: source port check for from_any_gw() and from_gw(). (#2832)

2021-08-25 Thread Victor Seva
Merged #2832 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2832#event-5204858083___ Kamailio (SER) - Development Mailing Lis