Merged #2761 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2761#event-4843484855___
Kamailio (SER) - Development Mailing
Think this PR ready to merge.
For `is_http_request()/is_http_reply()` i will create new PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Normally the HTTP traffic comes in event_route (or xmlrpc route). The core
itself does not handle http, it can delegate processing to xhttp or xmlrpc
modules, when configure to be _flexible_ on accepting non-sip traffic.
I think the is_reply()/is_request() should stay as they are specific to
maybe implement functions in core
1. `is_request("HTTP")`
2. `is_request("SIP")`
3. `is_reply("HTTP")`
4. `is_reply("SIP")`
and move these functions from `siputils` to `core`
1. `is_request()`
2. `is_reply()`
--
You are receiving this because you are subscribed to this thread.
Reply to this
@sergey-safarov pushed 1 commit.
2579bdf52816d05858ead275882ff2d2de167556 pv: pv_get_method fixed error
"pv_get_method(): no CSEQ header"
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
yes, Daniel
I have observed error `pv: fixed error "pv_get_method(): no CSEQ header"` with
HTTP replies when trying to use
```
event_route[siptrace:msg]
{
if($rm =~ "OPTIONS|HTTP") {
xlog("L_DEBUG", "trace|dropping trace for method $rm\n");
drop();
}
}
```
My goal to avoid
The example you provided is not an HTTP request, but an HTTP reply and it does
not have a method in the first line. HTTP methods are GET, POST, PUT, ...
Probably it should return $null for HTTP replies.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for
