Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-12-04 Thread Richard Fuchs
Merged #1742 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1742#event-2003599894___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-12-03 Thread Daniel-Constantin Mierla
@rfuchs - up to you, do you it as you prefer -- usually we squash if a commit is changing or is an improvement of the previous commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-12-03 Thread Richard Fuchs
Looks good to me now. @miconda do you prefer to have these commits squashed or merge as they are now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1742#issuecomment-443716012_

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-12-03 Thread Yasin CANER
@ycaner06 pushed 1 commit. 9401c82 rtpengine : b parameter is changed with via-branch in document -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1742/files/13f565e72b811820766a218cbd7cbb715f215ffe..9401c827b6127

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-12-02 Thread Yasin CANER
@ycaner06 pushed 1 commit. 13f565e rtpengine : str_key_val_prefix is fixed for null values -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1742/files/97eb8a61dd78b043c50bfd52b15a46fcf2f63e57..13f565e72b811820766a

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-11-30 Thread Yasin CANER
ycaner06 commented on this pull request. > @@ -1992,6 +1992,10 @@ static int parse_flags(struct ng_flags_parse > *ng_flags, struct sip_msg *msg, enu if (str_key_val_prefix(&key, "transcode", &val, &s) || str_key_val_prefix(&key, "codec-transcode",

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-11-30 Thread Richard Fuchs
rfuchs commented on this pull request. > @@ -1992,6 +1992,10 @@ static int parse_flags(struct ng_flags_parse > *ng_flags, struct sip_msg *msg, enu if (str_key_val_prefix(&key, "transcode", &val, &s) || str_key_val_prefix(&key, "codec-transcode",

Re: [sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-11-29 Thread Daniel-Constantin Mierla
@rfuchs - does the patch to the rtpengine module code look ok for you? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1742#issuecomment-443117115_

[sr-dev] [kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

2018-11-28 Thread Yasin CANER
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files