New additions to siptrace module broke previous functionality.
If sip_trace was used with no param and destination uri was not set
then the current message would not have been traced to database. The
current fix traces always the current message if siptrace function
was called.
Pr
I did the fix but I think the implementation as it was it's a little broken.
That is because you can trace only to database using sip_trace with no
arguments, but you can't trace only to database if using correlation_id(this
was the case in previous versions). With the new additions you can't tr
@ionutionita92 pushed 1 commit.
5b59ef8612ae1944f43216b37ff94b79c1fea642 siptrace: add sip_trace example with
trace type set to docs
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1951/files/ae216ecb10b6e430bdb
Ionut Ionita writes:
> I did the fix but I think the implementation as it was it's a little
> broken. That is because you can trace only to database using sip_trace
> with no arguments, but you can't trace only to database if using
> correlation_id(this was the case in previous versions). With the
Yes it works but the code in 5.2 is broken. Here's an example, maybe it's more
clear:
sip_trace(); /* traces to database only no db url */
sip_trace("", "$var(correlation_id)"); /* does not work; requires valid
duplicate uri */
// with my additions
sip_trace("", "$var(correlation_id)", "d"); /*
Ionut Ionita writes:
> Yes it works but the code in 5.2 is broken. Here's an example, maybe
> it's more clear:
>
> sip_trace(); /* traces to database only no db url */
> sip_trace("", "$var(correlation_id)"); /* does not work; requires valid
> duplicate uri */
> // with my additions
> sip_trace(
That's what this commit does, it fixes sip_trace(). Regarding the other part,
it's not that obvious to me because if no one reported this maybe it's not an
issue and that's the desired usage, elseway I would have fixed it already.
--
You are receiving this because you commented.
Reply to this e
I am merging, because I want to do some further adjustments.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1951#issuecomment-492144188___
Kamailio (SER) - De
Merged #1951 into master.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1951#event-2339315543___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamai
