Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-12-03 Thread lazedo
@miconda thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1726#issuecomment-443906127___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-12-03 Thread Daniel-Constantin Mierla
Closed #1726. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1726#event-2002433042___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-12-03 Thread Daniel-Constantin Mierla
Pushed it manually with some changes: use directly the core fixup function, adjusted the docs with existing functions in examples. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-11-19 Thread lazedo
@miconda i updated the documentation and added parameter to set uas.status code -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-11-19 Thread Daniel-Constantin Mierla
@lazedo - the PR does not have documentation for the new function. Also, I wonder if makes sense to have a parameter for the function in order to set the status code of uas, now it is hardcoded to 500. It can be helpful in case of some tm callbacks (e.g., for accounting or dialog) to be able to

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-11-19 Thread Victor Seva
yes, that's unrelated. Already pushed https://github.com/kamailio/pkg-kamailio-docker/commit/facc89d0bad0801bdd117061ac5fd85179fc824c to fix that issue. Waiting for the images to be updated https://hub.docker.com/r/kamailio/pkg-kamailio-docker/builds/ -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-11-16 Thread lazedo
there seems to be an unrelated? error in the build ` Compiler: clang C, DIST=sid` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] tmx: add t_drop (#1726)

2018-11-16 Thread lazedo
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README