Merged #2304 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2304#event-3296066480___
Kamailio (SER) - Development Mailing
Thanks Daniel, documentation added to the wiki.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2304#issuecomment-622961098___
Kamailio
OK to merge it. Do not forget to add docs in the core cookbook wiki.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Right, I realized after doing it. I've pushed the new suggest implementation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@grumvalski pushed 1 commit.
9948696fd84605919e6ce6a7106099f1cdd0de98 core: remove stats_name_separator
from cfg_group_core
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@grumvalski - I think it makes no sense to added to the `cfg_group_core /
default_core_cfg` structure, because that is for parameters that can be changed
at runtime. But, imo, this is not set once and actually use only during
startup, when the stats names are exported.
It can simply be a
@grumvalski pushed 1 commit.
3203a6572b874d191c3be61519853005bd5ab056 core: new core parameter
stats_name_separator
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
If you want to merge it now, I can add quickly what is needed to have the
global parameter in the interpreter, as I am familiar with lex/yacc and then
you can do further adjustments, if you need. Waiting that you do everything is
more than fine for me, as well.
--
You are receiving this
I can find some time in the next days to implement the global param. I'd also
go for prometheus format by default.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
my vote is use `Prometheus` format "_".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2304#issuecomment-621448415___
Kamailio (SER) -
It can be merged. Then I will add the global parm to set this char. The
question is what to make the default, the old dash/minus `-` (for backwards
compatibility); or underscore `_`, the new proposal in this PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this
@grumvalski pushed 2 commits.
4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 core: define KSR_STATS_NAMESEP for
stats name separator
0595795c659f6af586e63837efe56b45808cd735 ims_usrloc_pcscf, p_usrloc, usrloc:
use KSR_STATS_NAMESEP for stats names
--
You are receiving this because you are
@grumvalski pushed 1 commit.
2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 p_usrloc, ims_usrloc_pcscf: change
"-" for "_" in stats name to be prometheus compliant
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I've spot the same usage in p_usrloc and ims_usrloc_pcscf modules (they both
derived from usrloc).
I didn't notice any other module building "derivate" stats (as those), so I'm
not sure that implementing a global param is worth in this case.
--
You are receiving this because you are subscribed
Have anyone noticed use of `-` instead of `_` in other places/modules? If we do
it, better doing it for all.
Then wondering if we should do this via some config option (maybe a global
param) to set the separator char for these stats, so we have a way to let
people use older name in case this
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
16 matches
Mail list logo
