Closing this one, further discussions should be done to:
- https://github.com/kamailio/kamailio/pull/3571
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#issuecomment-1733614719
You are receiving this because you are subscribed to this
Closed #3569.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#event-10461987048
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
> I already created the code at #3571 Please test it
Thanks for the update, We will test this code and will get back to you.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#issuecomment-1733265837
You are receiving this because you are
I already created the code at https://github.com/kamailio/kamailio/pull/3571
Please test it
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#issuecomment-1725135478
You are receiving this because you are subscribed to this thread.
Message ID:
> @schiramchetty
>
> When you say you're only copying ... are you assuming that the length is
> always the same?
>
> ```
> #define SCA_STR_COPY(str1, str2) \
> memcpy((str1)->s, (str2)->s, (str2)->len); \
> (str1)->len = (str2)->len;
> ```
>
> SCA_STR_COPY doesn't do
@schiramchetty
when you say you're only copying ... are you assuming that the length is always
the same?
```
#define SCA_STR_COPY(str1, str2) \
memcpy((str1)->s, (str2)->s, (str2)->len); \
(str1)->len = (str2)->len;
```
SCA_STR_COPY doesn't do any magic. You
> Hi, what is going to happen if the length of updated RR is bigger than the
> reserved memory at saved RR? And in the case of RR being the same value?
Hi @linuxmaniac, The updated RR and saved RR variables are updated by kamailio
itself when receiving any sca subscription message. This is
Hi, what is going to happen if the length of updated RR is bigger than the
reserved memory at saved RR? And in the case of RR being the same value?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#issuecomment-1720859885
You are receiving this
> @miconda I think the fix is not really good since is not taking care of
> memory and if the previous value is equal. Created a new PR with a possible
> solution. @schiramchetty please take a look and test it
Hi @linuxmaniac, Thanks for your feedback.
We are not allocating any new memory for
@miconda I think the fix is not really good since is not taking care of memory
and if the previous value is equal. Created a new PR with a possible solution.
@schiramchetty please take a look and test it
--
Reply to this email directly or view it on GitHub:
Thanks for the PR!
A few remarks though:
- the commit has to be for development version (git master branch), not 5.5
branch. It will be then backported if it is a bug.
- 5.5 series is actually end of maintenance (its last release was out a while
ago:
11 matches
Mail list logo
