[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-20 Thread Daniel-Constantin Mierla via sr-dev
Merged #3603 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#event-10727523388 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-20 Thread Daniel-Constantin Mierla via sr-dev
Thanks for the details, I am not using the module, I wanted to be sure nothing was omitted -- I am going to merge it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#issuecomment-1773183763 You are receiving this because you are subscribed to

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-19 Thread mtryfoss via sr-dev
My plan is to have this merged and then continue working on db operations for the ims_charging module. I just wanted to have this completed first, since the other part will not work without it. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-19 Thread mtryfoss via sr-dev
Like I wrote in the ticket related to this task, most of the stuff was there already - but it both caused a crash and was not fully functional. Entries were being written to the database, but was not restored correctly on startup. I assume the old dialog module was used as a basis and that the

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-19 Thread Daniel-Constantin Mierla via sr-dev
Thanks! CodeQL can indeed fail from other reasons than the code, can be ignored if that happens. Regarding the patch of the PR, I could spot only a database delete operation being added. The commit message says `Add support for database backend`. Was there code for database support but not

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-13 Thread mtryfoss via sr-dev
Seems like there's some issue with the CodeQL Analyzer (runner image out of disk space)? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#issuecomment-1761472985 You are receiving this because you are subscribed to this thread. Message ID: