[sr-dev] Re: [kamailio/kamailio] ims_qos: Add suspend_transaction parameter (PR #3581)

2023-09-28 Thread Stefan Mititelu via sr-dev
Merged #3581 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3581#event-10499665427 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] ims_qos: Add suspend_transaction parameter (PR #3581)

2023-09-28 Thread Stefan Mititelu via sr-dev
Ok, will push a new commit to rename the C var, directly on master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3581#issuecomment-1739202919 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] Re: [kamailio/kamailio] ims_qos: Add suspend_transaction parameter (PR #3581)

2023-09-25 Thread Daniel-Constantin Mierla via sr-dev
>From my point of view after a very brief code review, it is fine to merge. I do have a comment, though. I would suggest to prefix global variables with some value specific to the module, like (`ims_qos_` or `_ims_qos_`, e.g., `_ims_qos_suspend_transaction`) because there might be cases when glo