Merged #3895 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3895#event-13355737088
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
@herlesupreeth approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3895#pullrequestreview-2151236217
You are receiving this because you are subscribed to this thread.
Message ID: _
@vingarzan commented on this pull request.
> tmb.t_request_within(&uac_r);
}
- if(h.s)
- pkg_free(h.s);
- if(content.s) {
- pkg_free(content.s);
+ watcher_contact = 0;
Shouldn't - both branches of the `if` before have the watch
@herlesupreeth commented on this pull request.
> tmb.t_request_within(&uac_r);
}
- if(h.s)
- pkg_free(h.s);
- if(content.s) {
- pkg_free(content.s);
+ watcher_contact = 0;
isnt this leaking memory here?
--
Reply to this email
Hey @jaybeepee! Since you authored most of this, if you haven't retired
:stuck_out_tongue_closed_eyes:, I'd appreciate your review! Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3895#issuecomment-2191522199
You are receiving this because
