[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Dragos Vingarzan via sr-dev
Merged #3913 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3913#event-13510344140 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Dragos Vingarzan via sr-dev
Updated and thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3913#issuecomment-2229233558 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Dragos Vingarzan via sr-dev
@vingarzan pushed 1 commit. 78c54452b046baea2898c6f1ee2cebe39921f95c nathelper: fixed handle_ruri_alias() for alias being an IPv6 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3913/files/3a49ec79893ce398cda218c80aff711a187daeb7..78c54452b046baea2898c6f1ee2cebe39921f95c You ar

[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Dragos Vingarzan via sr-dev
Sure thing, I can move them. I also prefer pointers, deep structures, etc at the beginning and initialized/blanked, in order to make cleanups meaningful. About the initialization in for I didn't know it happens, interesting! Might be some C-standards thingy. (Was declaring the `port_len` locall

[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

2024-07-15 Thread Daniel-Constantin Mierla via sr-dev
Over all, it should be ok to merge, just with the note that it is preferred to declare the variable at the beginning of the block. A few in this PR are in the middle. It is ok to have them at the beginning of the functions or at the beginning of the blocks, e.g.,: ``` if(cond) { int v; .