This is a new feature, the stable branches can get backports only for bug fixes
or documentation improvements.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1607305708
You are receiving this because you are subscribed to this th
Hi @miconda,
I was wondering, if I wish to back-port this to 5.7.1, what is the right way of
doing so?
Thanks,
Joey.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1607279322
You are receiving this because you are subscribed to
Merged #3473 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#event-9588604207
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developme
Done, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1600238969
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Ma
Hi @miconda,
Is there anything else I should do or join wait for someone to merge the PR?
Thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1600089504
You are receiving this because you are subscribed to this thread.
Message
LGTM now
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1591099003
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
@joeygo commented on this pull request.
> + }
+
+ if(rank == PROC_MAIN) {
+ if(rtpengine_dtmf_event_sock.len > 0) {
+ LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid);
+ /* fork worker process */
+
@joeygo pushed 1 commit.
9d563b820b82bdda49e8c4ad5ef0e82e09d8d535 rtpengine: release json document
object
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/3df99a84a33d1dcdb064f96e6edd36b75f9e7166..9d563b820b82bdda49e8c4ad5ef0e82e09d8d535
You are receiving this because
@joeygo commented on this pull request.
> +
+ fmsg = faked_msg_next();
+ rtb = get_route_type();
+ set_route_type(REQUEST_ROUTE);
+ init_run_actions_ctx(&ctx);
+ run_top_route(event_rt.rlist[dtmf_event_rt], fmsg, &ctx);
+ set_route_type(rtb);
+ if(ctx.ru
@rfuchs commented on this pull request.
> +
+ fmsg = faked_msg_next();
+ rtb = get_route_type();
+ set_route_type(REQUEST_ROUTE);
+ init_run_actions_ctx(&ctx);
+ run_top_route(event_rt.rlist[dtmf_event_rt], fmsg, &ctx);
+ set_route_type(rtb);
+ if(ctx.ru
@joeygo pushed 1 commit.
3df99a84a33d1dcdb064f96e6edd36b75f9e7166 rtpengine: fix build failed on
specific distribution
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/2ddab46263db2ae94038e672c79faaa769d9c306..3df99a84a33d1dcdb064f96e6edd36b75f9e7166
You are receiving
@joeygo pushed 1 commit.
2ddab46263db2ae94038e672c79faaa769d9c306 rtpengine: Fix rfuchs's PR comments
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/7c2d64ffa57bb8ebe6ce46311ca98a100b09a997..2ddab46263db2ae94038e672c79faaa769d9c306
You are receiving this because you
@miconda commented on this pull request.
> + }
+
+ if(rank == PROC_MAIN) {
+ if(rtpengine_dtmf_event_sock.len > 0) {
+ LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid);
+ /* fork worker process */
+
@joeygo commented on this pull request.
> + }
+
+ if(rank == PROC_MAIN) {
+ if(rtpengine_dtmf_event_sock.len > 0) {
+ LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid);
+ /* fork worker process */
+
@joeygo commented on this pull request.
> @@ -261,7 +262,7 @@ static int add_rtpp_node_info(
void *ptrs, struct rtpp_node *crt_rtpp, struct rtpp_set
*rtpp_list);
static int rtpp_test_ping(struct rtpp_node *node);
-static void rtpengine_dtmf_events_loop(int rank);
+static void
@joeygo commented on this pull request.
> +
+end:
+ close(rtpengine_dtmf_event_fd);
+}
+
+static int rtpengine_raise_dtmf_event(char *buffer, int len) {
+ srjson_doc_t jdoc;
+ srjson_t *it = NULL;
+ struct sip_msg *fmsg = NULL;
+ struct run_act_ctx ctx;
+ i
@joeygo commented on this pull request.
> + }
+
+ if (dtmf_event_rt == -1) {
+ LM_NOTICE("nothing to do - nobody is listening!\n");
+ goto end;
+ }
+
+ p = shm_malloc(ret + 1);
+ if (!
@joeygo commented on this pull request.
> + s_port.len = rtpengine_dtmf_event_sock.s +
> rtpengine_dtmf_event_sock.len - s_port.s;
+
+ if (s_port.len <= 0 || str2int(&s_port, &port) < 0 || port > 65535) {
+ LM_ERR("failed to initialize dtmf event listener because port
i
@rfuchs commented on this pull request.
> + s_port.len = rtpengine_dtmf_event_sock.s +
> rtpengine_dtmf_event_sock.len - s_port.s;
+
+ if (s_port.len <= 0 || str2int(&s_port, &port) < 0 || port > 65535) {
+ LM_ERR("failed to initialize dtmf event listener because port
i
@joeygo pushed 1 commit.
7c2d64ffa57bb8ebe6ce46311ca98a100b09a997 Register a new worker process for
dtmf event listener
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/87253c36f1b42f5d707ac4d2aeeda2f842f4d46d..7c2d64ffa57bb8ebe6ce46311ca98a100b09a997
You are receivin
@joeygo commented on this pull request.
>
-static int fixup_set_id(void **param, int param_no)
+static void rtpengine_dtmf_events_loop(int rank)
You are right. I removed it.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1226
@joeygo commented on this pull request.
> @@ -2147,6 +2401,9 @@ static int child_init(int rank)
/* probe rtpengines only in first worker */
if(build_rtpp_socks(0, 1))
return -1;
+
+ if (rtpengine_dtmf_ev
@miconda commented on this pull request.
> @@ -2147,6 +2401,9 @@ static int child_init(int rank)
/* probe rtpengines only in first worker */
if(build_rtpp_socks(0, 1))
return -1;
+
+ if (rtpengine_dtmf_e
@rfuchs commented on this pull request.
A bit unsure about how this is supposed to work, maybe I'm just dense?
>
-static int fixup_set_id(void **param, int param_no)
+static void rtpengine_dtmf_events_loop(int rank)
The `rank` argument seems unused?
> @@ -2147,6 +2401,9 @@ static int child_in
@rfuchs may want to check it.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1584777186
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER)
Hi,
Anything else is needed from my end or is it just waiting for spare time?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1584543228
You are receiving this because you are subscribed to this thread.
Message ID: __
26 matches
Mail list logo
