@toharish: just added the code to topoh module to offer the mask call id
function, you have to set its use_mode to 1, then bind from topos to its
inter-module api (probably an example is in sipcapture, if not see how register
module loads the sl module api).
--
Reply to this email directly or
Closed #3323.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3323#event-8228828735
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
@toharish You can close this PR and create a new one, or "force-push" the new
code to the existing PR. Creating a new PR is usually a bit easier. Regarding
the library changes for topoh, @miconda needs to comment of course.
--
Reply to this email directly or view it on GitHub:
> The approach to mask call id in topos like is done by topoh could be a good
> enough compromise for some specific needs. However, I think it would be
> better to avoid cloning the code from one module to another.
>
> A way for it would be to make topoh work in library mode with a new
The approach to mask call id in topos like is done by topoh could be a good
enough compromise for some specific needs. However, I think it would be better
to avoid cloning the code from one module to another.
A way for it would be to make topoh work in library mode with a new modparam,
in the
> Thanks for the fixed pull request. @miconda probably want to review it. I
> just noticed two copied files from topoh regarding the call-id masking. Maybe
> it make sense to discuss if this could be avoided, but there might be no easy
> solution.
It will be hard to replace the CallID in the
@toharish pushed 1 commit.
8ab2395e37eb5017b1719814eb7da1ef802d8b27 Topos: CallID mask - update comment
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3323/files/622c6d45baa91ab322bab7dc97653ca32e468cfd..8ab2395e37eb5017b1719814eb7da1ef802d8b27
You are receiving this because
Thanks for the fixed pull request. @miconda probably want to review it.
I just noticed two copied files from topoh regarding the call-id masking. Maybe
it make sense to discuss if this could be avoided, but there might be no easy
solution.
--
Reply to this email directly or view it on
