Module: kamailio
Branch: master
Commit: c571efefebc305b2049eb55458cb0ac1dc3202bb
URL: 
https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac1dc3202bb

Author: Daniel-Constantin Mierla <mico...@gmail.com>
Committer: Daniel-Constantin Mierla <mico...@gmail.com>
Date: 2018-11-19T09:47:58+01:00

smsops: free after error log message printing a field

---

Modified: src/modules/smsops/smsops_impl.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac1dc3202bb.diff
Patch: 
https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac1dc3202bb.patch

---

diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c
index 8150d081d6..8df667bb77 100644
--- a/src/modules/smsops/smsops_impl.c
+++ b/src/modules/smsops/smsops_impl.c
@@ -564,9 +564,9 @@ int decode_3gpp_sms(struct sip_msg *msg) {
 
                                                        // Check for malicious 
length, which might cause buffer overflow
                                                        if(udh_read + 
ie->data.len + 2 /* two octets are read so far */ > udh_len) {
-                                                               pkg_free(ie);
                                                                LM_ERR("IE 
Lenght for IE id %d is bigger than the remaining User-Data element!\n",
                                                                                
                                                                                
                                        ie->identifier);
+                                                               pkg_free(ie);
                                                                return -1;
                                                        }
 


_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to