Re: [sr-dev] git:master: rr: Fix memory leak when using outbound

2014-10-02 Thread Alekzander Spiridonov
Hi, I'm pretty sure that it's safe to free NULL pointer even in kamailio memory manager. So checking before pkg_free looks redundant. E.g.: + if (user.s != NULL) + pkg_free(user.s); 2014-10-02 21:39 GMT+04:00 Hugh Waite : > Module: sip-router > Branch: master

[sr-dev] git:master: rr: Fix memory leak when using outbound

2014-10-02 Thread Hugh Waite
Module: sip-router Branch: master Commit: 44e29820a759405adb7657334e86ea474196e6fd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=44e29820a759405adb7657334e86ea474196e6fd Author: Hugh Waite Committer: Hugh Waite Date: Thu Oct 2 18:37:00 2014 +0100 rr: Fix memory

[sr-dev] git:master: test/unit: updated test units 8 and 9

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 0921a4f6a2215b3e60bcc0dee4afe826f55a91d2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0921a4f6a2215b3e60bcc0dee4afe826f55a91d2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 17:58:0

[sr-dev] git:master: core: be prepared to get Via received param with brackets around ipv6 addr

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: b7bc7a5450b1e31697fb389a503463eac644b796 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b7bc7a5450b1e31697fb389a503463eac644b796 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 17:31:3

[sr-dev] git:master: tsilo: fix clang warnings on inline prototypes in header files

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: bf8c98fc71cba974a2b98c36e2c9f6966768d529 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bf8c98fc71cba974a2b98c36e2c9f6966768d529 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 17:34:4

[sr-dev] git:master: core: more verbose log message for failing to find local socket

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: f50c1e9fab16fb611f7bbc6002f4c8607bc8fbf2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f50c1e9fab16fb611f7bbc6002f4c8607bc8fbf2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 16:47:3

[sr-dev] git:master: tm: more verbose debug when failing to find socket for forwarding

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 51f58267322af394c0b0a75db2a310f57b18 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=51f58267322af394c0b0a75db2a310f57b18 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 16:34:0

Re: [sr-dev] [SR-Users] RFC: updating default values

2014-10-02 Thread Klaus Darilion
On 02.10.2014 10:48, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> One more came in my mind: >> >> - failure_reply_mode in tm set to 3 (now is 0) > > i have been using 3 there. IMO this makes sense ___ sr-dev mailing list sr-dev@lists

Re: [sr-dev] git:master: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Robert Boisvert
Daniel, I see the problem. Thanks for correcting, Bob On Thu, Oct 2, 2014 at 8:56 AM, Daniel-Constantin Mierla wrote: > Robert, > > the change is: > >{ "db_ctable", PARAM_STR, &db_ctable }, > - { "db_ctable", PARAM_STR, &db_qtable }, > + { "db_qtable", PARAM_STR, &db_qtable }, > > Pract

Re: [sr-dev] rtpengine alt stream question

2014-10-02 Thread Richard Fuchs
On 10/02/14 02:32, Alex Balashov wrote: > Hello, > > (Sorry for re-posting this here from sr-users; in retrospect, it seemed > more appropriate to do so.) > > I recently encountered SDP attributes that look like this: > >Media Attribute (a): alt:1 3 : njfxofkg bavpjfxg 192.168.2.59 41978 >

Re: [sr-dev] git:master: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Daniel-Constantin Mierla
Robert, the change is: { "db_ctable", PARAM_STR, &db_ctable }, - { "db_ctable", PARAM_STR, &db_qtable }, + { "db_qtable", PARAM_STR, &db_qtable }, Practically is changing c in q for the name of the parameter to set the db_qtable variable. Otherwise there are two db_ctable parameters defi

Re: [sr-dev] git:master: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Alekzander Spiridonov
This looks like a typo fix. 2014-10-02 16:38 GMT+04:00 Robert Boisvert : > Daniel, > > I was wondering why this change was made. Is there a conflict with > another value? > > Bob > > On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla < > mico...@gmail.com> wrote: > >> Module: sip-router >>

Re: [sr-dev] git:master: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Robert Boisvert
Daniel, I was wondering why this change was made. Is there a conflict with another value? Bob On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla wrote: > Module: sip-router > Branch: master > Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d > URL: > http://git.sip-router.org/cgi-bin/git

[sr-dev] git:master: test/unit: updates to auth parameter in unit 7 cfg

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 4f8f45bdcb7c4c82192bd8d0f7c8d2166dd75dac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4f8f45bdcb7c4c82192bd8d0f7c8d2166dd75dac Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 12:16:1

[sr-dev] git:master: test/unit: updates to unit 7

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 73fef4d500e58600758ac1c2b4eadf66d4b506a1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=73fef4d500e58600758ac1c2b4eadf66d4b506a1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 11:55:5

[sr-dev] git:master: lcr: declare inline function static to work with llvm linker

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 509659a83a53f8d979da37cee24941d22f5fffdc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=509659a83a53f8d979da37cee24941d22f5fffdc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 11:54:5

Re: [sr-dev] [SR-Users] RFC: updating default values

2014-10-02 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > One more came in my mind: > > - failure_reply_mode in tm set to 3 (now is 0) i have been using 3 there. -- juha ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinf

Re: [sr-dev] [SR-Users] RFC: updating default values

2014-10-02 Thread Daniel-Constantin Mierla
One more came in my mind: - failure_reply_mode in tm set to 3 (now is 0) Daniel On 02/10/14 10:30, Juha Heinanen wrote: Daniel-Constantin Mierla writes: - tcp_rd_buf_size - it is 4096b, but with audio/video and ice, the size is to small. I propose either 8k or even 16k i have used 16k in my

Re: [sr-dev] [SR-Users] RFC: updating default values

2014-10-02 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > - tcp_rd_buf_size - it is 4096b, but with audio/video and ice, the size > is to small. I propose either 8k or even 16k i have used 16k in my setups. > - pv_buffer_size - it is 1024b, given the above and that this is used > for variables, many don't fit. The s

[sr-dev] git:4.1: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: 4.1 Commit: f3820f1a9837451b9209aa40ca5ab750e59fec19 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f3820f1a9837451b9209aa40ca5ab750e59fec19 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 10:18:11 2

[sr-dev] git:master: mohqueue: fixed db_qtable parameter name

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dcd18e42fe6c62942ef417dd8acf7f466d Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 10:18:1

Re: [sr-dev] RFC: updating default values

2014-10-02 Thread Daniel-Constantin Mierla
Hello, apart of shared memory size (still to be considered), I made the other changes. Based on last days of testing at SIPit31 and reviewing my configs, few other values look a bit small considering what we can get on the wire: - tcp_rd_buf_size - it is 4096b, but with audio/video and ice,

[sr-dev] git:master: usrloc: hash_size default value set to 10

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 1f1b81ed76dda3a889ffec52c173c53b2225dee4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1f1b81ed76dda3a889ffec52c173c53b2225dee4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 09:51:4

[sr-dev] git:master: core: default pkg memory size set to 8MB

2014-10-02 Thread Daniel-Constantin Mierla
Module: sip-router Branch: master Commit: 2376ef7c6f3317054c844ae9b99366d084065121 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2376ef7c6f3317054c844ae9b99366d084065121 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: Thu Oct 2 09:48:3