Re: [sr-dev] [kamailio] nathelper: contact_only option (#31)

2015-02-19 Thread Victor Seva
Closed #31. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/31#event-238951081___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] nathelper: contact_only option (#31)

2015-02-19 Thread Victor Seva
Merged wrong number on commit fixes :-( --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/31#issuecomment-7522___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailm

[sr-dev] git:master:af59452e: usrloc: return received field too in get_all_*_ucontacts()

2015-02-19 Thread Victor Seva
Module: kamailio Branch: master Commit: af59452ed6ab165e9554c2d814d778abd7441699 URL: https://github.com/kamailio/kamailio/commit/af59452ed6ab165e9554c2d814d778abd7441699 Author: Victor Seva Committer: Victor Seva Date: 2015-02-20T08:15:43+01:00 usrloc: return received field too in get_all_*_u

[sr-dev] git:master:486c0692: nathelper: use always contact to build ruri and received field if available to send the ping

2015-02-19 Thread Victor Seva
Module: kamailio Branch: master Commit: 486c069222462e4bc05da36b098062be941d672d URL: https://github.com/kamailio/kamailio/commit/486c069222462e4bc05da36b098062be941d672d Author: Victor Seva Committer: Victor Seva Date: 2015-02-20T08:19:17+01:00 nathelper: use always contact to build ruri and

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread lazedo
@miconda i believe this is it ? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/91#issuecomment-75176709___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listi

Re: [sr-dev] registrar - additional features

2015-02-19 Thread Luis Azedo
no, nothing is created if not configured. current behavior is preserved From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Juha Heinanen [j...@tutpro.com] Sent: Thursday, February 19, 2015 12:23 PM To: Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio] core: add support for per-TCP connection lifetime (#95)

2015-02-19 Thread Daniel-Constantin Mierla
Can be merged. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/95#issuecomment-75132915___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:2597c31e: Merge pull request #71 from kamailio/oej/mohqueue

2015-02-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 2597c31eca105084ecbce964791d3bf965b23fdc URL: https://github.com/kamailio/kamailio/commit/2597c31eca105084ecbce964791d3bf965b23fdc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-02-19T21:46:24+01:00 Merge pull request #71

[sr-dev] git:master:cd58d9ea: mohqueue Do not declare variables in middle of function, do error checking on all modparams possible before exit, add \n att error messages

2015-02-19 Thread Olle E . Johansson
Module: kamailio Branch: master Commit: cd58d9eafc18edcc6a719d76cd1dbe252d88ae91 URL: https://github.com/kamailio/kamailio/commit/cd58d9eafc18edcc6a719d76cd1dbe252d88ae91 Author: Olle E. Johansson Committer: Olle E. Johansson Date: 2015-02-06T22:38:17+01:00 mohqueue Do not declare variables in

Re: [sr-dev] [kamailio] mohqueue MInor fixes (#71)

2015-02-19 Thread Daniel-Constantin Mierla
Merged #71. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/71#event-238683430___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] pull request for mohqueue

2015-02-19 Thread Daniel-Constantin Mierla
Yes, as I said the changes seemed minor - besides closing the open items on the tracker, I was being mostly interested in getting end of line for the LOG messages. I will merge it then. Thanks, Daniel On 17/02/15 22:41, Robert Boisvert wrote: > Daniel, > > I looked over the changes and they are m

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread lazedo
Olle, it acts on the sip uri not the user part of the sip uri. On Thu, Feb 19, 2015 at 8:27 PM, juha-h wrote: > lazedo writes: > > > added param sip_uri_match > > 0 - case sensitive (default) > > 1 - case insensitive > > should it rather be called sip_uri_user_match? > > i still don't feel com

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread juha-h
Olle E. Johansson writes: > If the module are comparing domains with case sensitivity today, > that's a bug that needs to be fixed. exactly. i also pointed this out earlier. if implemented, the new function must operate on uri user only, but i would not prefer to add this functionality at all as

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread juha-h
lazedo writes: > it acts on the sip uri not the user part of the sip uri. and that exactly is the problem as we have tried to tell. -- juha --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/94#issuecomment-75130859_

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread lazedo
i added a 3rd param to control if we search for "override" values for flags. default is 0, don't search --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/91#issuecomment-75129897___ sr-dev mailing list sr-d

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread Daniel-Constantin Mierla
We are not on the same meaning of terms here. I refer to function parameter, not module parameter. I want to do: ``` registered("location", "$fu", "1") ``` in order to do registered() with call-id match. The new parameter can be int or pv (see fixup_igp_null() and fixup_get_ivalue() helper functi

Re: [sr-dev] [kamailio] set defaults of fifo and ctl to /var/run/kamailio (#89)

2015-02-19 Thread Daniel-Constantin Mierla
The patches are ok, but before merging, the 'make install' commands must be updated to change the paths in configs and kamctl based on PREFIX. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/89#issuecomment-75130052_

Re: [sr-dev] [kamailio] nathelper: contact_only option (#31)

2015-02-19 Thread Daniel-Constantin Mierla
Can be merged. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/31#issuecomment-75129139___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread juha-h
lazedo writes: > added param sip_uri_match > 0 - case sensitive (default) > 1 - case insensitive should it rather be called sip_uri_user_match? i still don't feel comfortable in starting to bloat kamailio with non-standard behavior. why don't you canonize uri user in config script? -- juha -

Re: [sr-dev] registrar - additional features

2015-02-19 Thread Juha Heinanen
Luis Azedo writes: > add param match_return_flags - bit mask > 1 add contact xavp >in registered adds or sets into the transaction >in reg_fetch_contacts adds to plc structure does this mean that a new xavp is created even if any of the new features are not used? can you tell exactly how

Re: [sr-dev] [kamailio] Cleanup CURL handle when the POST value can't be fetched from the PVAR (#88)

2015-02-19 Thread Daniel-Constantin Mierla
Closed #88. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/88#event-238659528___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread lazedo
there are two params match_flags as you proposed 1 - callid 2 - received 3 - contact the registered() function check that flag, checks the values in xavp_cfg and assigns the value to a temp vars, that are then compared against the value in the record. match_return_flags controls if the record xav

Re: [sr-dev] [kamailio] Cleanup CURL handle when the POST value can't be fetched from the PVAR (#88)

2015-02-19 Thread Daniel-Constantin Mierla
Patch applied with the fix, to be backported. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/88#issuecomment-75127351___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread Daniel-Constantin Mierla
I don't see any new parameter to registered(...) function. Do I miss something? Perhaps I can change (sometime during next days) the current call-id matching to using a new flags param to registered() function and xavp. Then you can add from there what you need extra. --- Reply to this email di

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread lazedo
i don't think i did, the flags are in params. i added the extra search for "override" to give more flexibility. i can put that flexibility param dependent. On Thu, Feb 19, 2015 at 8:03 PM, Daniel-Constantin Mierla < notificati...@github.com> wrote: > You misunderstood my proposal. I wanted a new

Re: [sr-dev] [kamailio] registrar - additional features (#91)

2015-02-19 Thread Daniel-Constantin Mierla
You misunderstood my proposal. I wanted a new parameter to the function: registered(talble, uri, flags), because I want to avoid searching through xavps if not needed. The parameter is read only if provided. If I got right the patches, you search for the flags in xavp list. --- Reply to this e

Re: [sr-dev] [kamailio] modules/cdp: added src_addr parameter in peer definition (#45)

2015-02-19 Thread Jason Penton
Hey Daniel, Received. will look into it! On Thu Feb 19 2015 at 22:06:30 Daniel-Constantin Mierla < notificati...@github.com> wrote: > Apparently it doesn't work to assign more than one developer -- i wanted > to ping the ims guys on this item. > > — > > > Reply to this email directly or view it

Re: [sr-dev] [kamailio] modules/cdp: added src_addr parameter in peer definition (#45)

2015-02-19 Thread Daniel-Constantin Mierla
Apparently it doesn't work to assign more than one developer -- i wanted to ping the ims guys on this item. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/45#issuecomment-75125684___ sr-dev mailing list

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread Daniel-Constantin Mierla
There are helper C functions for comparing the URI, used by: * http://kamailio.org/docs/modules/devel/modules/siputils.html#siputils.f.cmp_uri Not sure how this strict uri matching can be made to work with db only mode... but I guess that is a compromise. --- Reply to this email directly or

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread Olle E. Johansson
If the module are comparing domains with case sensitivity today, that's a bug that needs to be fixed. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/94#issuecomment-75110709___ sr-dev mailing list sr-dev

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread Luis Azedo
yes, i know the docs are missing. when is something other then a fix, i will gladly add the docs if the request is accepted. "i hope we always are case insensitive for domains" this implementation acts on the full sip uri. it is open to add a 3rd option that will take the full uri and matches

[sr-dev] [kamailio] core: add support for per-TCP connection lifetime (#95)

2015-02-19 Thread Camille Oudot
A per-TCP connection `lifetime` parameter is needed, to add a new functionnality in the tcpops module: the ability to dynamically modify the connection lifetime on a connection (e.g. raise the lifetime of a successfully authenticated connection). This requires modifications in the core: - add

[sr-dev] git:master:5adbfc6c: db_text : missing OP_NEQ

2015-02-19 Thread lazedo
Module: kamailio Branch: master Commit: 5adbfc6cc62be393ac55d296cab79f7e60b17ae4 URL: https://github.com/kamailio/kamailio/commit/5adbfc6cc62be393ac55d296cab79f7e60b17ae4 Author: lazedo Committer: lazedo Date: 2015-02-18T23:01:57Z db_text : missing OP_NEQ this affects the presence package whe

Re: [sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread Olle E. Johansson
Are we still missing docs here? Note that the param in registrar has another name. Since this is not about the full SIP uri- i hope we always are case insensitive for domains - maybe a better name would be sip_username_match --- Reply to this email directly or view it on GitHub: https://github.

[sr-dev] git:4.2:9524b347: db_text : missing OP_NEQ

2015-02-19 Thread Luis Azedo
Module: kamailio Branch: 4.2 Commit: 9524b3471802c09361fd290cf35b2d5096ac0767 URL: https://github.com/kamailio/kamailio/commit/9524b3471802c09361fd290cf35b2d5096ac0767 Author: lazedo Committer: Luis Azedo Date: 2015-02-19T17:52:06Z db_text : missing OP_NEQ this affects the presence package wh

Re: [sr-dev] [kamailio] db_text : missing OP_NEQ (#92)

2015-02-19 Thread lazedo
Merged #92. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/92#event-238554677___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:367887d6: Merge pull request #92 from kamailio/lazedo-patch-1

2015-02-19 Thread lazedo
Module: kamailio Branch: master Commit: 367887d6437db5f1c5e70258d3838f3a2acbd084 URL: https://github.com/kamailio/kamailio/commit/367887d6437db5f1c5e70258d3838f3a2acbd084 Author: lazedo Committer: lazedo Date: 2015-02-19T17:50:22Z Merge pull request #92 from kamailio/lazedo-patch-1 db_text :

[sr-dev] [kamailio] presence - match sip uris using alternative function (#94)

2015-02-19 Thread lazedo
added param sip_uri_match 0 - case sensitive (default) 1 - case insensitive can be extended to a more compliant version, (sensitive user, insensitive domain). the parameter sets the function to call to match uris. You can view, comment on, or merge this pull request online at: https://github

Re: [sr-dev] [kamailio] db_text : missing OP_NEQ (#92)

2015-02-19 Thread Daniel-Constantin Mierla
Can be merged and backported if needed. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/92#issuecomment-75100503___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailm

[sr-dev] git:master:d5ac2a0b: tcpops: check protocol of current message

2015-02-19 Thread Camille Oudot
Module: kamailio Branch: master Commit: d5ac2a0b21c51f0759c16ff39e6d28e1bc8730d7 URL: https://github.com/kamailio/kamailio/commit/d5ac2a0b21c51f0759c16ff39e6d28e1bc8730d7 Author: Camille Oudot Committer: Camille Oudot Date: 2015-02-19T18:18:57+01:00 tcpops: check protocol of current message -

Re: [sr-dev] registrar - additional features

2015-02-19 Thread Luis Azedo
Hi, waiting on implementation comments, if accepted, will document before merge From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Olle E. Johansson [o...@edvina.net] Sent: Thursday, February 19, 2015 5:18 AM To: Kamailio (SER) - Development Mailing

Re: [sr-dev] registrar - additional features

2015-02-19 Thread Olle E. Johansson
I haven't seen any updates to the doc files - or did I miss them? /O On 19 Feb 2015, at 14:08, Luis Azedo wrote: > Hi, > > made this commit to the pull request. > i think it answers all questions, comments appreciated. > > > registrar - match changes > add param match_flags bit mask > 1 cal

Re: [sr-dev] registrar - additional features

2015-02-19 Thread Luis Azedo
Hi, made this commit to the pull request. i think it answers all questions, comments appreciated. registrar - match changes add param match_flags bit mask 1 callid 2 received 3 contact add param match_return_flags - bit mask 1 add contact xavp in registered adds or sets into the transac

[sr-dev] git:master:1dbcc939: Merge pull request #93 from tsearle/master

2015-02-19 Thread tsearle
Module: kamailio Branch: master Commit: 1dbcc93952db87fb158886b05b03f82626ff933c URL: https://github.com/kamailio/kamailio/commit/1dbcc93952db87fb158886b05b03f82626ff933c Author: tsearle Committer: tsearle Date: 2015-02-19T10:24:43+01:00 Merge pull request #93 from tsearle/master modules/sipt

Re: [sr-dev] [kamailio] modules/sipt: added the ability to modify the first byte of Backwards Call Indication Parameters (#93)

2015-02-19 Thread tsearle
Merged #93. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/93#event-238246839___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:059c9a33: modules/sipt: fix example values in documentation

2015-02-19 Thread Torrey Searle
Module: kamailio Branch: master Commit: 059c9a33fd451b59b83f913f86a0843e2c5bbefa URL: https://github.com/kamailio/kamailio/commit/059c9a33fd451b59b83f913f86a0843e2c5bbefa Author: Torrey Searle Committer: Torrey Searle Date: 2015-02-19T09:24:37+01:00 modules/sipt: fix example values in document

[sr-dev] git:master:a7f8ee27: add ability to modify BCI header

2015-02-19 Thread Torrey Searle
Module: kamailio Branch: master Commit: a7f8ee271acca095fa6a7c2dddf0dcba62102efd URL: https://github.com/kamailio/kamailio/commit/a7f8ee271acca095fa6a7c2dddf0dcba62102efd Author: Torrey Searle Committer: Torrey Searle Date: 2015-02-18T20:48:11+01:00 add ability to modify BCI header --- Modif

[sr-dev] [kamailio] added the ability to modify the first byte of Backwards Call Indication Parameters (#93)

2015-02-19 Thread tsearle
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/93 -- Commit Summary -- * add ability to modify BCI header * modules/sipt: fix example values in documentation -- File Changes -- M modules/sipt/README (61) M modules/sipt/d

[sr-dev] git:master:3be5902a: pv: fixed the definition of the new $sut variable

2015-02-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 3be5902a697caca2dd70fae2e17a1e0acb87c089 URL: https://github.com/kamailio/kamailio/commit/3be5902a697caca2dd70fae2e17a1e0acb87c089 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-02-19T09:36:57+01:00 pv: fixed the definiti

Re: [sr-dev] git:master:30460e26: pv: $su use the common core function to get the source address as uri

2015-02-19 Thread Luis Azedo
a typo here ? + {{"su", (sizeof("sut")-1)}, /* */ >>> should be "sut" ? + PVT_OTHER, pv_get_srcaddr_uri_full, 0, + 0, 0, 0, 0}, From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Daniel-Constantin Mierla

[sr-dev] git:master:30460e26: pv: $su use the common core function to get the source address as uri

2015-02-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 30460e263b9b5492872f1f1437fefdfbba69f92b URL: https://github.com/kamailio/kamailio/commit/30460e263b9b5492872f1f1437fefdfbba69f92b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-02-19T09:19:56+01:00 pv: $su use the common

[sr-dev] git:master:b81dff6a: core: unified function for returning string of a protocol

2015-02-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: b81dff6abab6d8c25892f28db0e663653daa6c2c URL: https://github.com/kamailio/kamailio/commit/b81dff6abab6d8c25892f28db0e663653daa6c2c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-02-19T09:09:14+01:00 core: unified function

[sr-dev] git:master:2df98c7a: nathelper: received uri is using core function for generating source uri

2015-02-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 2df98c7afdc7ef574124912de01a5fd66f7aa6bb URL: https://github.com/kamailio/kamailio/commit/2df98c7afdc7ef574124912de01a5fd66f7aa6bb Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-02-19T09:11:54+01:00 nathelper: received ur

Re: [sr-dev] propose change strncmp to strncasecmp in presence module

2015-02-19 Thread Olle E. Johansson
On 19 Feb 2015, at 02:59, Luis Azedo wrote: > but are we ready to accept sip...@abcd.com == sip:1...@abcd.com ? The domain part is always case insensitive. AbCd.COM == abCD.cOm User names are not case insensitive. ALICE != Alice I think we have a setting to make it case insensitive in registra