Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

2015-07-15 Thread Paul Arnold
Hi Charles, That fixes it. I've successfully tested both master and 4.3.0 patched with 99f7d67 and bc01d8d and both branches now working correctly. thanks, Paul --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

2015-07-15 Thread Charles Chance
Hi Paul, I've just committed another fix (https://github.com/kamailio/kamailio/commit/bc01d8d6c6abfc7912a27df3ac23bffd818758e9) if you could test and confirm. Cheers, Charles --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

2015-07-15 Thread 00Asgaroth00
Hi Charles, thanks for taking a look, unfortunately I'm away for a couple days, I should be able to confirm on Saturday/Sunday. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Hi, In this case I am getting the following error: ``` Jul 15 10:45:00 /usr/sbin/kamailio[23349]: ERROR: textops [textops.c:1854]: append_multibody_helper(): Cannot get boundary. Is body multipart? Jul 15 10:45:00 /usr/sbin/kamailio[23349]: ERROR: core [msg_translator.c:1664]: get_boundary():

[sr-dev] [kamailio] dialog: run event_route[dialog:end] in case of dialog termination by … (#246)

2015-07-15 Thread Andrey Utkin
…interface commands You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/246 -- Commit Summary -- * dialog: run event_route[dialog:end] in case of dialog termination by interface commands -- File Changes -- M

Re: [sr-dev] [kamailio] UAC trouble with REGISTER to provider (#140)

2015-07-15 Thread Daniel-Constantin Mierla
Guessing it was related to the the wrong realm discussed on mailing list. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/140#issuecomment-121517866___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] UAC trouble with REGISTER to provider (#140)

2015-07-15 Thread Daniel-Constantin Mierla
Closed #140. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/140#event-356168454___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

2015-07-15 Thread Paul Arnold
Thanks Charles, I can confirm that 99f7d67 fixes this issue. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/237#issuecomment-121509697___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:8dcc663d: Makefile.groups: rename usrloc_dmq to dmq_usrloc

2015-07-15 Thread Paul Arnold
Module: kamailio Branch: master Commit: 8dcc663d050ec314e35ed2c4bcaae592f8e39350 URL: https://github.com/kamailio/kamailio/commit/8dcc663d050ec314e35ed2c4bcaae592f8e39350 Author: Paul Arnold p...@barfoo.net Committer: Paul Arnold p...@barfoo.net Date: 2015-07-15T12:10:13+10:00 Makefile.groups:

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Daniel-Constantin Mierla
Can you try with msg_apply_changes() immediately after append_body_part() to see if still crashes? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121513813___ sr-dev mailing list

Re: [sr-dev] [kamailio] 4.3 compiler warnings (#185)

2015-07-15 Thread Daniel-Constantin Mierla
Closed #185. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/185#event-356164389___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] 4.3 compiler warnings (#185)

2015-07-15 Thread Daniel-Constantin Mierla
Closing this as not default compilation options for a rather very old piece of code -- we need to revisit how far we go with those warning flags on default basis --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

2015-07-15 Thread Charles Chance
Hi, Please test using latest master at https://github.com/kamailio/kamailio/commit/99f7d67b20c011e78c277a44ea8cd4d6a820806f and if it resolves the issue I will backport to 4.3. Cheers, Charles --- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:67dfb62c: modules/ims_usrloc_scscf: only remove impurecord if there are no active subscriptions

2015-07-15 Thread jaybeepee
Module: kamailio Branch: master Commit: 67dfb62cf15ab60401243c3632a587b64ed5d376 URL: https://github.com/kamailio/kamailio/commit/67dfb62cf15ab60401243c3632a587b64ed5d376 Author: jaybeepee jason.pen...@gmail.com Committer: jaybeepee jason.pen...@gmail.com Date: 2015-07-15T09:15:40+02:00

Re: [sr-dev] [kamailio] Errors work BLF modules pua and presence (#104)

2015-07-15 Thread Daniel-Constantin Mierla
Closing as no follow up was made for about 4 months. Re-open and add requested details if the issue is still there for you. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/104#issuecomment-121516489___

Re: [sr-dev] [kamailio] Errors work BLF modules pua and presence (#104)

2015-07-15 Thread Daniel-Constantin Mierla
Closed #104. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/104#event-356166039___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Unquoted IPv6 Contact header alias parameter causes issues with Asterisk (PJSIP) TOPOH module (#120)

2015-07-15 Thread Daniel-Constantin Mierla
Closed #120. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/120#event-356167429___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Makefile.groups was not updated when usrloc_dmq was renamed to dmq_usrloc (#245)

2015-07-15 Thread Victor Seva
Merged #245. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/245#event-356145762___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:b4079013: Merge pull request #245 from pwarnold/master

2015-07-15 Thread Victor Seva
Module: kamailio Branch: master Commit: b40790134c01c6a0afa839f7896219ccff6e0818 URL: https://github.com/kamailio/kamailio/commit/b40790134c01c6a0afa839f7896219ccff6e0818 Author: Victor Seva linuxman...@torreviejawireless.org Committer: Victor Seva linuxman...@torreviejawireless.org Date:

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Here is another backtrace full log. On Thursday, July 9, 2015 5:21 PM, Victor Seva notificati...@github.com wrote: yes, thanks— Reply to this email directly or view it on GitHub. GNU gdb (GDB) Red Hat Enterprise Linux (7.2-75.el6) Copyright (C) 2010 Free Software Foundation,

Re: [sr-dev] [kamailio] PID file permissions (#231)

2015-07-15 Thread Daniel-Constantin Mierla
Closed #231. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/231#event-356161654___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] PID file permissions (#231)

2015-07-15 Thread Daniel-Constantin Mierla
Re-open if there is still some issue related to the topic. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/231#issuecomment-121514487___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

2015-07-15 Thread Paul Arnold
Hi Charles, 99f7d67b20c011e78c277a44ea8cd4d6a820806f fixes the garbled text issue (#237) but doesn't fix this problem. thanks, Paul --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
No, I am calling msg_apply_changes() _after_ append_body_part() as you recommended, and it is not crashing any more. It does not correctly append the isup though due to the error I pasted. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dialog: run event_route[dialog:end] in case of dialog termination by … (#246)

2015-07-15 Thread Daniel-Constantin Mierla
Thanks for the patch. At quick look, it seems that the event route will be called twice in case of a dialog lifetime timeout. At line 1408 in dlg_handlers.c, the event route code is executed again after dlg_bye_all() and dlg_bye_all() executes inside the event route code. Might be an option to

Re: [sr-dev] [kamailio] pua_reginfo: fix NOTIFY xml (#247)

2015-07-15 Thread Daniel-Constantin Mierla
It is ok to merge from my point of view. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/247#issuecomment-121722021___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:63bd356c: pua_reginfo: use ul.get_urecord_by_ruid instead of ul.get_urecord

2015-07-15 Thread Victor Seva
Module: kamailio Branch: master Commit: 63bd356cc3c7aa64d64361283f630f88b8db88af URL: https://github.com/kamailio/kamailio/commit/63bd356cc3c7aa64d64361283f630f88b8db88af Author: Victor Seva linuxman...@torreviejawireless.org Committer: Victor Seva linuxman...@torreviejawireless.org Date:

[sr-dev] git:master:8f3caea2: Merge pull request #247 from kamailio/vseva/pua_reginfo

2015-07-15 Thread ng-voice GmbH
Module: kamailio Branch: master Commit: 8f3caea21172893abb3f6be8856058f41f2bb17f URL: https://github.com/kamailio/kamailio/commit/8f3caea21172893abb3f6be8856058f41f2bb17f Author: ng-voice GmbH cars...@ng-voice.com Committer: ng-voice GmbH cars...@ng-voice.com Date: 2015-07-15T21:36:04+02:00

[sr-dev] git:master:7d31d78e: pua_reginfo: use ruid to fix comparation of contact

2015-07-15 Thread Victor Seva
Module: kamailio Branch: master Commit: 7d31d78e3ac861cddfcb70c9940242ec7f3f0dbc URL: https://github.com/kamailio/kamailio/commit/7d31d78e3ac861cddfcb70c9940242ec7f3f0dbc Author: Victor Seva linuxman...@torreviejawireless.org Committer: Victor Seva linuxman...@torreviejawireless.org Date:

Re: [sr-dev] [kamailio] pua_reginfo: fix NOTIFY xml (#247)

2015-07-15 Thread ng-voice GmbH
Merged #247. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/247#event-356827094___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] dialog: run event_route[dialog:end] in case of dialog termination by … (#246)

2015-07-15 Thread Andrey Utkin
Thanks for this deep review. Amended that commit, it should be in this pull request now (9ccc3f510ce2d97dbe1efb690ef1d4e8f18885d5). What about that double dlg_unref() at dlg_handlers.c near 1408 after dlg_bye_all() in case of non-zero return? Is it ok? --- Reply to this email directly or view

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Daniel-Constantin Mierla
Is it still crashing? Or what you mean by backtrace? Are you still calling msg_apply_changes() before append_body_part()? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121590485___

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Daniel-Constantin Mierla
I haven't said to remove the existing one, but perhaps you misunderstood, let it in the old place as well, have two of them. --- Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio] pua_reginfo: fix NOTIFY xml (#247)

2015-07-15 Thread Victor Seva
Before the changes the xml was always the same: UL_CONTACT_UPDATE - state=active event=registered ``` Jul 15 13:48:14 sp1 proxy[25780]: DEBUG: pua_reginfo [usrloc_cb.c:240]: reginfo_usrloc_cb(): AOR: 8883567711@A.A.A.A (location) Jul 15 13:48:14 sp1 proxy[25780]: DEBUG: pua_reginfo

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Wow, it works like a charm! Thank you! --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121636676___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Ok let me try, sorry. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121632655___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
I agree --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121637910___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Victor Seva
still I would say that we should not crash, doesn't it @miconda ? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121637754___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Daniel-Constantin Mierla
@andreikabeliy use sr-users mailing list for usual questions, not related to an issue. We use this as bug and features request tracker, not a discussion forum. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Victor Seva
On 07/15/2015 04:52 PM, andreikabeliy wrote: Can Kamailio decode an ISUP at all? storing it in the readable format so then I can append it using append_body_part()? No idea if this is what you are asking for: http://kamailio.org/docs/modules/stable/modules/sipt.html signature.asc

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Closed #240. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#event-356534505___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Reopened #240. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#event-356535702___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread andreikabeliy
Can Kamailio decode an ISUP at all? storing it in the readable format so then I can append it using append_body_part()? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/240#issuecomment-121641642___

Re: [sr-dev] [kamailio] Textops and Multipart Body - adding ISUP segfaults Kamailio (#240)

2015-07-15 Thread Daniel-Constantin Mierla
The crash was done on purpose, calling abort() in a function that was supposed not be used in that way. I will take care of doing some safety checks around to avoid getting there. --- Reply to this email directly or view it on GitHub: