Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Daniel-Constantin Mierla
I see that an dlg_unref is removed and not re-added -- from the patch: ``` if(dlg_bye_all(dlg, NULL)<0) - dlg_unref(dlg, 1); ``` Any reason for that? If BYE failed to be be sent, then the dialog will hang around forever. --- Reply to this em

[sr-dev] git:master:0f479b53: sanity: adjusted log messages for check_proxy_require()

2015-08-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 0f479b5366fae4c5ad0c78e4c91661b7a421d5e8 URL: https://github.com/kamailio/kamailio/commit/0f479b5366fae4c5ad0c78e4c91661b7a421d5e8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-08-24T09:28:29+02:00 sanity: adjusted log m

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Federico Cabiddu
I thought that the dlg_unref below was enough both for successful and unsuccessful case. Am I missing something? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/291#issuecomment-134072501___ sr-dev mailin

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Daniel-Constantin Mierla
At that stage, dialog needs to be unref'ed two times in order to be destroyed. If BYE is sent ok, then one unref is done when processing the response of the BYE. If BYE is not sent, then the dialog is unref'ed by that IF condition, because there is no expected response. Removing one unref is no

Re: [sr-dev] [kamailio] dialog's keepalives keep sending to old address after re-INVITE with updated location (#273)

2015-08-24 Thread Daniel-Constantin Mierla
I looked at code while traveling, but it was not something straightforward to change. Contact address is kept in a continuous block of memory with other attributes. To update it requires a bit more changes than just replacing old contact. It is in my short todo list. --- Reply to this email dir

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Federico Cabiddu
Thank you for the explanation Daniel. I'll fix the patch. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/291#issuecomment-134076389___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-rout

[sr-dev] [kamailio] jsonrpc-c notification does not free shm memory (#296)

2015-08-24 Thread zxcpoiu
Use Case Description: I'm trying to log "user last register status" using function `jsonrpc_notification` from module `jsonrpc-c` # invoke in kamailio.cfg: `jsonrpc_notification("last_reg", "{'user': '$au', 'data':['$Ts', '$au', '$ct', '$ua', '$sel(received.proto_ip_port)']}");` **acc

Re: [sr-dev] [kamailio] kamctl ul show/xmlrpc ul.lookup not find valid AOR (Kamailio v4.3.1) (#264)

2015-08-24 Thread 00Asgaroth00
Hi, Just a freindly 'bump' to remind you of this issue, please let me know if you need me to provide any more info on this one. Thanks --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/264#issuecomment-134130870___

Re: [sr-dev] [kamailio] kamctl ul show/xmlrpc ul.lookup not find valid AOR (Kamailio v4.3.1) (#264)

2015-08-24 Thread Daniel-Constantin Mierla
Hello, thanks for reminding, they are really useful, especially in holidays season. A short update: somehow made my mind on how to fix it, by propagating the case_sensitive from registrar to the core, and check it from there in usrloc module. My concern is that other places might need this (e.g

Re: [sr-dev] [kamailio] Fix dialog module still loading DB when db_fetch_rows == 0 (#295)

2015-08-24 Thread Daniel-Constantin Mierla
It is not easy to track all those patches one after the other and because the commit message is not formatted as we recommend, I would suggest: * make a diff between your branch and kamailio main master branch * apply it to a fresh clone of kamailio main master branch * write the commit message a

[sr-dev] git:master:9c943031: dmq_usrloc: check existence of usrloc domain before continuing.

2015-08-24 Thread Charles Chance
Module: kamailio Branch: master Commit: 9c943031f29889c21b25b49b5dd267f4b2460bae URL: https://github.com/kamailio/kamailio/commit/9c943031f29889c21b25b49b5dd267f4b2460bae Author: Charles Chance Committer: Charles Chance Date: 2015-08-24T18:17:23+01:00 dmq_usrloc: check existence of usrloc doma

[sr-dev] git:master:7b357914: dmq_usrloc: fix indentation

2015-08-24 Thread Charles Chance
Module: kamailio Branch: master Commit: 7b35791472620bee9f489b80f3528ce00ffbd688 URL: https://github.com/kamailio/kamailio/commit/7b35791472620bee9f489b80f3528ce00ffbd688 Author: Charles Chance Committer: Charles Chance Date: 2015-08-24T18:41:12+01:00 dmq_usrloc: fix indentation --- Modified

[sr-dev] [kamailio] dispatcher: add new probing_mode=3 to always probe flagged gateways (#297)

2015-08-24 Thread evolvetsi
- added DS_PROBE_ONLYFLAGGED probing_mode option. If set, any gateways with a state of PROBING will be continually probed and the PROBING flag will never be cleared. This allows probing specific gateways continually, keeping their up/down status current. This is related to

[sr-dev] [kamailio] Memory Leak in t_uac_dlg Mi function (#298)

2015-08-24 Thread Torge Szczepanek
We are using the t_uac_dlg function through a UDP MI Datagram to create local SIP/TCP requests. We are seeing a memory leak of increasing shared Memory usage, which is increasing at the same rate as tcp connections are created (tested under 4.0.1 and 4.3.1). /usr/sbin/kamailio[25407]: NOTIC

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

2015-08-24 Thread Charles Chance
Just looking into this now but I am struggling to reproduce the issue - can you confirm you are still seeing it with the 0x04 flag on save() and that all instances are running the most up-to-date version (with delete replication)? --- Reply to this email directly or view it on GitHub: https://gi

Re: [sr-dev] [kamailio] dispatcher: add new probing_mode=3 to always probe flagged gateways (#297)

2015-08-24 Thread Daniel-Constantin Mierla
To change the content of README for module, you have to edit xml file inside modules/dispatcher/doc/. Then, to regenerate the readme, do: ``` make modules-readme modules=modules/dispatcher ``` You need docbook utils and xsl packages for the above command to work, but it is ok to just change the

[sr-dev] [kamailio] modules/p_usrloc: fixes get_all_ucontacts() function signature (#299)

2015-08-24 Thread Mikko Lehto
I am not user of p_usrloc, but accidentally compiled this and bumped into mentioned warning. Clang 3.0 and GCC 4.7 do not complain. Clang 3.5 and GCC 4.8 do complain. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/299 -- Commit Summary

Re: [sr-dev] [kamailio] modules/p_usrloc: fixes get_all_ucontacts() function signature (#299)

2015-08-24 Thread Daniel-Constantin Mierla
Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/299#issuecomment-134369839___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:7e7ffea7: Merge pull request #299 from mslehto/warn-p_usrloc

2015-08-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 7e7ffea767db9b2afd9dec6eea20389e21da1b50 URL: https://github.com/kamailio/kamailio/commit/7e7ffea767db9b2afd9dec6eea20389e21da1b50 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-08-24T22:31:35+02:00 Merge pull request #29

Re: [sr-dev] [kamailio] modules/p_usrloc: fixes get_all_ucontacts() function signature (#299)

2015-08-24 Thread Daniel-Constantin Mierla
Merged #299. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/299#event-391006910___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:4dc718a0: modules/p_usrloc: fixes get_all_ucontacts() function signature

2015-08-24 Thread Mikko Lehto
Module: kamailio Branch: master Commit: 4dc718a0f20169ed76b9f7618e3e9994c9313102 URL: https://github.com/kamailio/kamailio/commit/4dc718a0f20169ed76b9f7618e3e9994c9313102 Author: Mikko Lehto Committer: Mikko Lehto Date: 2015-08-24T22:27:51+03:00 modules/p_usrloc: fixes get_all_ucontacts() func

Re: [sr-dev] [kamailio] dispatcher: add new probing_mode=3 to always probe flagged gateways (#297)

2015-08-24 Thread evolvetsi
Gotcha. I went ahead and made the changes to the xml file and regenerated the README.. Looks good to me, though I notice that the various special characters in the README file changed when I regenerated it.. You may want to regenerate the readme using your kit instead. --- Reply to this emai

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Federico Cabiddu
I'm going to close this request and open a new one with a clean patch. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/291#issuecomment-134481792___ sr-dev mailing list sr-dev@lists.sip-router.org http://l

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#291)

2015-08-24 Thread Federico Cabiddu
Closed #291. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/291#event-391330649___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#300)

2015-08-24 Thread Federico Cabiddu
…-request Set the dialog context before calling dlg_bye_all. In this way the dialog context is the correct one in the event route tm:local-request; otherwise it could happen that, in the timer process, the context is invalid due to some previous timed-out transaction which set (and not reset) t

[sr-dev] git:master:31d984c6: Merge pull request #300 from grumvalski/ontimeout_bye_dlg_ctx

2015-08-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 31d984c6a1b59da455387cb10bfd68dd8d8bbcc8 URL: https://github.com/kamailio/kamailio/commit/31d984c6a1b59da455387cb10bfd68dd8d8bbcc8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-08-25T08:49:13+02:00 Merge pull request #30

[sr-dev] git:master:5002f66a: modules/dialog: make dialog context available in event route tm:local-request

2015-08-24 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 5002f66a98b6104702c8c862e7335ff189e7b7d8 URL: https://github.com/kamailio/kamailio/commit/5002f66a98b6104702c8c862e7335ff189e7b7d8 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2015-08-25T07:26:19+02:00 modules/dialog: make dialog context av

Re: [sr-dev] [kamailio] modules/dialog: make dialog context available in event route tm:local… (#300)

2015-08-24 Thread Daniel-Constantin Mierla
Merged #300. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/300#event-391377441___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:c56209fa: Merge pull request #297 from evolvetsi/master

2015-08-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: c56209fa2d487385def4b98bfb662d90236ac5f8 URL: https://github.com/kamailio/kamailio/commit/c56209fa2d487385def4b98bfb662d90236ac5f8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2015-08-25T08:57:43+02:00 Merge pull request #29

Re: [sr-dev] [kamailio] dispatcher: add new probing_mode=3 to always probe flagged gateways (#297)

2015-08-24 Thread Daniel-Constantin Mierla
Merged #297. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/297#event-391381926___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev