Re: [sr-dev] [kamailio] presence: use advertised ip for local contact (#365)

2015-10-07 Thread Daniel-Constantin Mierla
Closed #365. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/365#event-429696334___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] presence: use advertised ip for local contact (#365)

2015-10-07 Thread Daniel-Constantin Mierla
Reopened #365. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/365#event-429696346___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio] mem/q_malloc: log more diagnostic information in qm_debug_frag (#361)

2015-10-07 Thread Alex Dowad
I had an instance of SER crash in production with this error message from qm_debug_frag: [mem/q_malloc.c:149]: BUG: qm_*: fragm. 0x4cee3b88 (address 0x4cee3ba0) end overwritten(0, 0)! The fragment end was been overwritten with zeroes... buffer overflow? Or an aliasing bug? Maybe a double-free?

Re: [sr-dev] [SR-Users] rfc: event route when kamailio starts

2015-10-07 Thread jh
> More or less what I want to ask here is whether the forking of the other > children should wait until the event_route[core:worker-one-init] is > finished (e.g., what is done in this event route is important before any > sip packet is routed) or just leave it like it is. I need htable

[sr-dev] Errored: kamailio/kamailio#1408 (master - 274f103)

2015-10-07 Thread Travis CI
Build Update for kamailio/kamailio - Build: #1408 Status: Errored Duration: 18 minutes and 20 seconds Commit: 274f103 (master) Author: Olle E. Johansson Message: nathelper Via header for SIP ping over IPv6 needs square brackets View the changeset:

[sr-dev] git:master:b3d38eac: core: new feature to execute event_route[core:worker-one-init]

2015-10-07 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: b3d38eac7a24bff88a1ec555aa5a50ea5c3f0232 URL: https://github.com/kamailio/kamailio/commit/b3d38eac7a24bff88a1ec555aa5a50ea5c3f0232 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:0ef0791e: core: faked message api moved to core

2015-10-07 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 0ef0791e5e5ff01622ce8e9575ecc8f40fa4d726 URL: https://github.com/kamailio/kamailio/commit/0ef0791e5e5ff01622ce8e9575ecc8f40fa4d726 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] git:master:b3d38eac: core: new feature to execute event_route[core:worker-one-init]

2015-10-07 Thread Jason Penton
This is interesting, what is the motivation ;) ? On Wed, 7 Oct 2015 at 12:14 Daniel-Constantin Mierla wrote: > Module: kamailio > Branch: master > Commit: b3d38eac7a24bff88a1ec555aa5a50ea5c3f0232 > URL: >

Re: [sr-dev] [kamailio] nathelper: Bad IPv6 reference in Via header (#363)

2015-10-07 Thread Olle E. Johansson
Via: SIP/2.0/UDP :67C:FFD8:E07F:0:0:0:8:5060;branch=0 should be Via: SIP/2.0/UDP [:67C:FFD8:E07F:0:0:0:8]:5060;branch=0 The syntax for the host part says IPv6 reference. --- Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio] nathelper: Bad IPv6 reference in Via header (#363)

2015-10-07 Thread Olle E. Johansson
Nathelper sends a Via header with IPv6 address with no square brackets This cause parsing errors on the receiving side and all kinds of unhappy packets in the universe and Internet of SIP. --- Reply to this email directly or view it on GitHub:

[sr-dev] git:4.3:74042e3c: nathelper Via header for SIP ping over IPv6 needs square brackets

2015-10-07 Thread Olle E . Johansson
Module: kamailio Branch: 4.3 Commit: 74042e3c00edd441e30d7aba25807f99617be375 URL: https://github.com/kamailio/kamailio/commit/74042e3c00edd441e30d7aba25807f99617be375 Author: Olle E. Johansson Committer: Olle E. Johansson Date: 2015-10-07T14:04:27+02:00

Re: [sr-dev] [kamailio] mem/q_malloc: log more diagnostic information in qm_debug_frag (#361)

2015-10-07 Thread Daniel-Constantin Mierla
Are you running old ser version? Or you just referred to it as SER, if yes, what version are you running? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/361#issuecomment-146142639___ sr-dev mailing list

Re: [sr-dev] [kamailio] nathelper: Bad IPv6 reference in Via header (#363)

2015-10-07 Thread Olle E. Johansson
Committed fix to master. Needs backport to 4.3 / 4.2 but the code is a bit different there. Tested - it works --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/363#issuecomment-146166674___ sr-dev

Re: [sr-dev] [kamailio] nathelper: Bad IPv6 reference in Via header (#363)

2015-10-07 Thread Olle E. Johansson
Note: The code hard codes "UDP" but for both IPv4 and IPv6 one may need keepalives even on TCP connections, unfortunately. That may be another bug to fix. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] nathelper: Bad IPv6 reference in Via header (#363)

2015-10-07 Thread Olle E. Johansson
Closed #363. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/363#event-429023915___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] nat_traversal: Builds wrong URI for IPv6, bad URI parsing (#362)

2015-10-07 Thread Olle E. Johansson
Right now it causes crashes and core dumps when using IPv6 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/362#issuecomment-146129236___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] Errored: kamailio/kamailio#1408 (master - 274f103)

2015-10-07 Thread Olle E. Johansson
Seems like an issue with the CLANG build… I can’t find anything related to the patch here. /O > On 07 Oct 2015, at 14:03, Travis CI wrote: > > kamailio / kamailio >

[sr-dev] [kamailio] nat_traversal: Builds wrong URI for IPv6, bad URI parsing (#362)

2015-10-07 Thread Olle E. Johansson
nat_traversal doesn't handle IPv6 keepalives. It doesn't add [ and ] around IPv6 addresses and there's some bad parsing of SIP URI's in the code, assuming the first colon after "sip:" (not sips or tel) is a separator for port numbers. A better parser would be nice to use. --- Reply to this

[sr-dev] git:master:274f1034: nathelper Via header for SIP ping over IPv6 needs square brackets

2015-10-07 Thread Olle E . Johansson
Module: kamailio Branch: master Commit: 274f1034bfb9ea0d52ef291d2f95021ca86f3081 URL: https://github.com/kamailio/kamailio/commit/274f1034bfb9ea0d52ef291d2f95021ca86f3081 Author: Olle E. Johansson Committer: Olle E. Johansson Date: 2015-10-07T13:44:03+02:00

Re: [sr-dev] [kamailio] tm: fake msg and environment to append new branches (#346)

2015-10-07 Thread Federico Cabiddu
Thanks for looking at it Daniel. If you prefer I can wait your analysis before merging. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#issuecomment-146207063___ sr-dev mailing list

[sr-dev] git:master:7185a8a7: modules/ims_charging: set the last_event timestamp if there was failure to get credit

2015-10-07 Thread jaybeepee
Module: kamailio Branch: master Commit: 7185a8a708001a6e2d2150e2541880c04c2374b4 URL: https://github.com/kamailio/kamailio/commit/7185a8a708001a6e2d2150e2541880c04c2374b4 Author: jaybeepee Committer: jaybeepee Date: 2015-10-07T15:48:53+02:00

Re: [sr-dev] [kamailio] tm: fake msg and environment to append new branches (#346)

2015-10-07 Thread Daniel-Constantin Mierla
Can be merged. Anyhow, wondering if would be just enough to use a local temporary msg structure, will be simpler, but then if branch route is executed, some context attributes won't be there... I will try to analyze a bit more the whole concept with faking the environment, because sometimes

[sr-dev] git:master:e9eea6bc: nathelper Remove SVN IDs

2015-10-07 Thread Olle E . Johansson
Module: kamailio Branch: master Commit: e9eea6bc7adcf21ce6217597e749deb6111a115b URL: https://github.com/kamailio/kamailio/commit/e9eea6bc7adcf21ce6217597e749deb6111a115b Author: Olle E. Johansson Committer: Olle E. Johansson Date: 2015-10-07T15:33:39+02:00

Re: [sr-dev] [kamailio] mem/q_malloc: log more diagnostic information in qm_debug_frag (#361)

2015-10-07 Thread Daniel-Constantin Mierla
If it would be a double free, then that should be caught earlier, iirc. Likely to be a buffer overflow, which may be fixed meanwhile, because 3.2.3 is rather old, you should at least upgrade to latest 3.2.x. If you got a coredump, then print the content of the fragment to see what piece of

[sr-dev] Errored: kamailio/kamailio#1409 (4.3 - 74042e3)

2015-10-07 Thread Travis CI
Build Update for kamailio/kamailio - Build: #1409 Status: Errored Duration: 11 minutes and 55 seconds Commit: 74042e3 (4.3) Author: Olle E. Johansson Message: nathelper Via header for SIP ping over IPv6 needs square brackets (cherry picked from commit

Re: [sr-dev] [kamailio] nat_traversal: Builds wrong URI for IPv6, bad URI parsing (#362)

2015-10-07 Thread Daniel-Constantin Mierla
nat_traversal was not much on focus during past years because initial developers are gone, and a lot of us are actually using nathelper for the nat traversal needs. If you have a fix, just push it to the repository. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] mem/q_malloc: log more diagnostic information in qm_debug_frag (#361)

2015-10-07 Thread Alex Dowad
Hi, @miconda. In production, I'm running Kamailio 3.2.3 (59f87e). I just called it SER because the `make_and_install` build script generates a binary called `ser`. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] git:master:b3d38eac: core: new feature to execute event_route[core:worker-one-init]

2015-10-07 Thread Daniel-Constantin Mierla
Doing something only one time at kamailio start. There is event_route[htbale:mod-init], but that would require htable and some other modules might not be initialized. Anyhow, it is sort of not finished, because there are some aspects I want to discuss and see what people would need from such

Re: [sr-dev] [kamailio] tm: fake msg and environment to append new branches (#346)

2015-10-07 Thread Daniel-Constantin Mierla
If it fixes things now, merge it, refactoring can be done later. Overall, is about not getting to fake the env too many times if same env can be re-used -- again, I need to look at other parts, it actually may not be the case for this situation. --- Reply to this email directly or view it on

[sr-dev] git:master:3de200b3: Merge pull request #346 from grumvalski/t_append_branches_fix

2015-10-07 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 3de200b3c965586b3dd9370eca073f10c556e3b3 URL: https://github.com/kamailio/kamailio/commit/3de200b3c965586b3dd9370eca073f10c556e3b3 Author: Federico Cabiddu Committer: Federico Cabiddu Date:

Re: [sr-dev] [kamailio] tm: fake msg and environment to append new branches (#346)

2015-10-07 Thread Federico Cabiddu
Merged #346. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/346#event-429175307___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] mem/q_malloc: log more diagnostic information in qm_debug_frag (#361)

2015-10-07 Thread Alex Dowad
Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/361#issuecomment-146211859___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] nat_traversal: Builds wrong URI for IPv6, bad URI parsing (#362)

2015-10-07 Thread Olle E. Johansson
I think we can add to the documentation "Doesn't support IPv6" - because it requires a lot of work to do anything else. We have also focused on Nathelper now. - ok? --- Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio] ims_qos - rx_avp.c: rx_add_framed_ip_avp call to inet_pton with IPv6 fails due to [] format (#364)

2015-10-07 Thread dschaafsma
This is an issue in 4.2, not sure about how 4.3+ currently handle this call path. rx_add_framed_ip_avp() is called with an IP formatted as "[2001:db8::ff00:42:8329]" This passes the INET6_ADDRSTRLEN check due to '::' compression, but inet_pton will fail to parse. One possible hack/fix is:

[sr-dev] [kamailio] presence: use advertised ip for local contact (#365)

2015-10-07 Thread lazedo
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/365 -- Commit Summary -- * presence: use advertised ip for local contact -- File Changes -- M modules/presence/utils_func.h (17) -- Patch Links --

[sr-dev] rfc: event route when kamailio starts

2015-10-07 Thread Daniel-Constantin Mierla
Hello, based on a recent discussion with Alex Balashov (at Kazoocon this week), I pushed a patch that enables the execution of event_route[core:worker-one-init] when kamailio is started. It would be more like an alternative for event_route[htable:mod-init], for the cases when htable is not used,

[sr-dev] 4.3 branch gcc warnings

2015-10-07 Thread Victor Seva
Hi, building the 4.3 branch I'm having a lot of: "declared but never defined" for parse_param. For instance: gcc -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -Wall -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat