[sr-dev] Presence notify - duplicate aux body processing?

Hi All, Whilst attempting to track down the source of an issue introduced at some point since 4.2.1, I came across the following and would appreciate a second opinion. In send_notify_request() function (/modules/presence/notify.c), the aux body processing function attached to the event is

[sr-dev] [kamailio] registrar: reg_xavp_cfg should not be reset when sock_flag is not set (#475)

- since there are functions like `registered()` would use it - reported by Jayesh Nambiar (@jayesh1017) in the comment of GH#470 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/475 -- Commit Summary -- * registrar: reg_xavp_cfg

Re: [sr-dev] [kamailio] registrar: reg_xavp_cfg should not be reset when sock_flag is not set (#475)

Merged #475. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/475#event-514696859___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:256d5f75: Merge pull request #475 from ianlin/master

Module: kamailio Branch: master Commit: 256d5f754ddfa7c47086f18a6d15fb08ae6bff87 URL: https://github.com/kamailio/kamailio/commit/256d5f754ddfa7c47086f18a6d15fb08ae6bff87 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio] registrar: reg_xavp_cfg should not be reset when sock_flag is not set (#475)

Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/475#issuecomment-171570835___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] debugger moduel - get config line number

Hi, I'm trying to get the line number when a config function is called. Looking at the *fixup_dbg_pv_dump*(): " dbg_sip_msg_action = dbg_fixup_get_action(param, param_no); _dbg_sip_msg_cline = dbg_sip_msg_action->cline; " The above works as long as the config function is called with at

Re: [sr-dev] debugger moduel - get config line number

On 14.01.2016 14:10, smititelu wrote: I'm trying to get the line number when a config function is called. Looking at the *fixup_dbg_pv_dump*(): *fixup_dbg_sip_msg()** ___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Rtpengine table changes (#429)

@rfuchs , did you already have time to take a look on this pull request? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/429#issuecomment-171658291___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] [kamailio] modules/ndb_mongodb: fixes documentation typo (#476)

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/476 -- Commit Summary -- * modules/ndb_mongodb: fixes documentation typo -- File Changes -- M modules/ndb_mongodb/README (2) M modules/ndb_mongodb/doc/ndb_mongodb_admin.xml

[sr-dev] [kamailio] Use C99 boolean (#477)

Spotted few cases where using C99 bool can remove local typedef and corresponding macros You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/477 -- Commit Summary -- * modules/statsd: use C99 boolean * modules/nat_traversal: use C99

Re: [sr-dev] Presence notify - duplicate aux body processing?

i suppose we can review it but we're not seeing the issue anymore. can you provide some sip traces that you think are wrong ? the commits below aren't related with the one you mentioned before. the problem solved with the commits below is , "in a serie of subscribers being notified only the

Re: [sr-dev] Presence notify - duplicate aux body processing?

the commit was introduced because of dbmode = 3 > pres_timer_send_notify > process_dialogs > notifier_notify > notify > send_notify_request and then gets the body and processes the aux_body_processing notify_body = get_p_notify_body(subs->pres_uri, subs->event, NULL,

Re: [sr-dev] [kamailio] Rtpengine table changes (#429)

Only briefly. Gonna look at it now, sorry for the delay --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/429#issuecomment-171666775___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Rtpengine table changes (#429)

No problem, didn't intend to hustle you. Just wanted to check the state as sometimes things may slither out-of-sight unintendedly :smirk: --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Rtpengine table changes (#429)

OK, so one thing I've noticed is that it doesn't seem to take concurrency into account. Previously the linked lists were created at startup before Kamailio forks and then left alone, but modifying a linked list during runtime with multiple processes accessing the shared memory simultaneously is

Re: [sr-dev] Presence notify - duplicate aux body processing?

Hi Luis, I really appreciate your reply. My issue is the one you have also observed yourself - incorrect notify version for dbmode <> 3 - and tried to fix recently with this commit: https://github.com/kamailio/kamailio/commit/6dd065629604a32081d5e7b63bbbd292f56aaf23 and subsequently with these