Re: [sr-dev] [kamailio] MS ODBC Driver crashes kamailio on boot (#501)

2016-02-09 Thread Daniel-Constantin Mierla
You can always replace the sensitive information with generic tokens such as USER, HOST, PASSWORD, IP1, etc... I am more interested where is invalid data rather than valid values. Can you try without tls module? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/

Re: [sr-dev] [kamailio] Fix node selection when rtpengine_delete(), for branching scenarios (#505)

2016-02-09 Thread Stefan Mititelu
> Do you still want me to try with DBG mode enabled in sip proxy? If it's not much fuss to do it, try it. You should **not** see that "failed to" log anymore, after rtpengine_delete(): ``` rtpengine [rtpengine.c:2792]: select_rtpp_node_old(): rtpengine hash table lookup **failed to** find node f

Re: [sr-dev] [kamailio] Fix node selection when rtpengine_delete(), for branching scenarios (#505)

2016-02-09 Thread juha-h
Stefan Mititelu writes: > @juha-h can you try a basic call with DBG mode enable? > You should see a log like "rtpengine hash table lookup *find* ..." for the > rtpengine_delete(); no corner case scenarios can happen now. Thanks. I tried by setting rtpengine-deamon log level to 7 and basic call l

Re: [sr-dev] DB Reconnect behaviour in db_unixodbc module

2016-02-09 Thread Daniel-Constantin Mierla
Hello, On 09/02/16 14:05, Tim Chubb wrote: > > Answer own question, re-read c docs and remember how rust my c skills are… > > I think the !strncmp was throwing me, to think “if not equal to this > or that, then reconnect” rather than !strncmp being short hand for > strncmp(…)==0. > > > > With th

Re: [sr-dev] [kamailio] Fix node selection when rtpengine_delete(), for branching scenarios (#505)

2016-02-09 Thread Stefan Mititelu
@juha-h can you try a basic call with DBG mode enable? You should see a log like "rtpengine hash table lookup *find* ..." for the rtpengine_delete(); no corner case scenarios can happen now. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/505#issue

[sr-dev] [kamailio] Fix node selection when rtpengine_delete(), for branching scenarios (#505)

2016-02-09 Thread Stefan Mititelu
Reported by @juha-h You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/505 -- Commit Summary -- * rtpengine: Fix node selection for branching cases * rtpengine: LM_NOTICE to LM_DBG -- File Changes -- M modules/rtpengine/rtpengine

Re: [sr-dev] DB Reconnect behaviour in db_unixodbc module

2016-02-09 Thread Tim Chubb
Answer own question, re-read c docs and remember how rust my c skills are... I think the !strncmp was throwing me, to think "if not equal to this or that, then reconnect" rather than !strncmp being short hand for strncmp(...)==0. With that cleared up in my mind I'm still at a loss as to why only

[sr-dev] DB Reconnect behaviour in db_unixodbc module

2016-02-09 Thread Tim Chubb
Hi Can someone explain the reasoning behind not reconnecting when an ODBC error code of '08003' or '08S01' is received back in modules/db_unixodbc/dbase.c? Such as on lines 120 and 121? /* Connection broken */ if( !strncmp((char*)sqlstate,"08003",5) || !strncmp((char*)sqlstate,"08S01",5) ) { ret

Re: [sr-dev] [kamailio] MS ODBC Driver crashes kamailio on boot (#501)

2016-02-09 Thread Tim Chubb
TLS module is loaded, and when i issue the commands you asked for above it displays the connection string, which i cant really share publically. I have also rebuilt the build box in case it was an issue of conflicting versions. Behavious is slightly different now rather than an outright crash t

[sr-dev] git:master:eb820d1b: ims_charging: updated docs for dependency on ims_dialog

2016-02-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: eb820d1b29f9d89c81950641ac1084eca2bbe02c URL: https://github.com/kamailio/kamailio/commit/eb820d1b29f9d89c81950641ac1084eca2bbe02c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2016-02-09T13:23:22+01:00 ims_charging: updated

[sr-dev] git:master:45b0f699: examples: updated ims configs to use ims_dialog module

2016-02-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 45b0f6992f1a37107be1d3cfdbdb10b60ac6d1c5 URL: https://github.com/kamailio/kamailio/commit/45b0f6992f1a37107be1d3cfdbdb10b60ac6d1c5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2016-02-09T13:26:15+01:00 examples: updated ims

[sr-dev] info: dialog_ng renamed to ims_dialog

2016-02-09 Thread Daniel-Constantin Mierla
Hello, based on a previous discussion on mailing lists, I just renamed the dialog_ng to ims_dialog in order to reflect better its purpose nowadays (use together with the other ims modules) and avoid confusion that it is something that includes the features of dialog module and some new stuff. Fun

[sr-dev] git: new commits in branch master

2016-02-09 Thread Daniel-Constantin Mierla
- URL: https://github.com/kamailio/kamailio/commit/5b32b1301ded6862b1a0db12324e821bad5e64c8 Author: Daniel-Constantin Mierla Date: 2016-02-09T11:30:42+01:00 dialog_ng: renamed to ims_dialog - reflecting better the target usage at this moment - future considerations can results in merging bot

Re: [sr-dev] [kamailio] Database timeout over SSL? (#406)

2016-02-09 Thread Tobias Lindgren
@miconda here's a log of Kamailio starting up vs. when the error occurs for three different timer processes (restarts): ``` Feb 5 12:36:36 /usr/sbin/kamailio[19627]: DEBUG: db_cluster [dbcl_api.c:269]: db_cluster_init(): initializing with cluster [cluster://k2] Feb 5 12:36:36 /usr/sbin/kamail

Re: [sr-dev] [kamailio] Add t_is_request_route() config function (#503)

2016-02-09 Thread Daniel-Constantin Mierla
Even the development is frozen for 4.4, this is the missing one from the group that helps to detect the top route (along with t_is_branch_route(), t_is_failure_route(), ...) and given that is practically just a condition around route_type global variables, it might worth merging, we haven't bran

[sr-dev] git:master:326adcfa: Merge pull request #504 from kamailio/co/tcp_closed_event_enhancements

2016-02-09 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 326adcfa3fa644e1b27b075d2305b2a3649b20c9 URL: https://github.com/kamailio/kamailio/commit/326adcfa3fa644e1b27b075d2305b2a3649b20c9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2016-02-09T10:45:46+01:00 Merge pull request #50

Re: [sr-dev] [kamailio] tcp:closed event enhancements (#504)

2016-02-09 Thread Daniel-Constantin Mierla
Merged #504. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/504#event-544103232___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] tcp:closed event enhancements (#504)

2016-02-09 Thread Daniel-Constantin Mierla
Thanks! I will merge this to complete the new feature for event_route on tcp close event. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/504#issuecomment-18178___ sr-dev mailing list sr-dev@lists.sip

[sr-dev] git:master:bc7dc166: tcpops: add "disabled mode" to closed_event param

2016-02-09 Thread Camille Oudot
Module: kamailio Branch: master Commit: bc7dc166858d0def2c827ff7be037bfcaa9f0e7e URL: https://github.com/kamailio/kamailio/commit/bc7dc166858d0def2c827ff7be037bfcaa9f0e7e Author: Camille Oudot Committer: Camille Oudot Date: 2016-02-08T19:59:19+01:00 tcpops: add "disabled mode" to closed_event

[sr-dev] git:master:83575430: tcpops: per-connection control over tcp:closed

2016-02-09 Thread Camille Oudot
Module: kamailio Branch: master Commit: 8357543007760d941fcb92c12297f0109397853e URL: https://github.com/kamailio/kamailio/commit/8357543007760d941fcb92c12297f0109397853e Author: Camille Oudot Committer: Camille Oudot Date: 2016-01-29T20:00:20+01:00 tcpops: per-connection control over tcp:clos

[sr-dev] git:master:df875b53: tcp: define new flag to control tcpop's tcp:closed

2016-02-09 Thread Camille Oudot
Module: kamailio Branch: master Commit: df875b53340c9e09b6ca0baaa2154000d0bbba47 URL: https://github.com/kamailio/kamailio/commit/df875b53340c9e09b6ca0baaa2154000d0bbba47 Author: Camille Oudot Committer: Camille Oudot Date: 2016-01-29T18:18:19+01:00 tcp: define new flag to control tcpop's tcp:

[sr-dev] git:master:8bf03256: tcpops: update README

2016-02-09 Thread Camille Oudot
Module: kamailio Branch: master Commit: 8bf032566a810f7fa60dd96310be8d9a5095b032 URL: https://github.com/kamailio/kamailio/commit/8bf032566a810f7fa60dd96310be8d9a5095b032 Author: Camille Oudot Committer: Camille Oudot Date: 2016-02-08T20:03:21+01:00 tcpops: update README --- Modified: module

Re: [sr-dev] rtpengine module notice

2016-02-09 Thread smititelu
On 09.02.2016 10:13, Juha Heinanen wrote: My understanding has been that rtpengine_delete() without a branch param, should delete the whole call specified by just the callid. Is that not the case? It deletes the call. The question is to which rtpengine machine is the delete() command sent. Righ

Re: [sr-dev] rtpengine module notice

2016-02-09 Thread Juha Heinanen
smititelu writes: > The NOTICE message indicates that there is no entry in the hastable for > the *(callid, viabranch)* pair, and the node selection algorithm will > start running (select_rtpp_node_new()). This means that a new entry will > be added in the hastable, containing the selected node