Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

Will rename and right now wait for more feedback. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256995175___ sr-dev

[sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

- fix 'methods' variable type in receiving branch; by default in struct definition it is an 'unsigned int', but while receiving DMQ message value puts into 'int' and cause flags corruption in some cases You can view, comment on, or merge this pull request online at:

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

Closed #835. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/835#event-840237531___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

The module will be able to parse ISUP binary protocol to string serialization i.e. JSON or pseudo variables and later we can insert the parsed messages into DB and using it in Homer. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

Then maybe ss7ops is more appropriate as name, not to suggest a protocol support. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

I did not want to step on anyone's shoes. You all have done great work with this product and I have been using it since 1.5 (I think that was it). I do have some more ideas like using the textops module to insert the Replaces and PAI headers...just been looking and learning but not sure it's a

Re: [sr-dev] [kamailio/kamailio] sca: implement db_mode only (#781)

I assume you mean more then one kamailio server in a load-balancing type environment? If so, that was on my radar for future enhancements but I am glad someone is finally looking at this module and making some improvements. Thank you so much This module is one that I use at many customers

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

* It receives M2UA over hep3 (through the sipcapture module) * Right now it is just meant to parse ISUP (and later TCAP/MAP) and store it in the home/sipcapture db. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

> Ok, I will step away then and you can remove my pull request. Please, keep contributing, we are more than happy to get more people involve. Take a look over the new code and feel free to close this if you think is not relevant anymore > Just an FYI that the sca.cfg needs to be updated to

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

Trying to understand what's the module about in order to be able to make more comments on its name: * does it receive ss7 packet over hep3 or it can forward it to homer over hep3? In Kamailio we can also receive binary packets which are not sip (we do for stun module) * what is the target

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

should we keep this module's name or change to another ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256940321___

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

Just an FYI that the sca.cfg needs to be updated to reflect the newer kamailio.cfg changes. Also, this script block needs to be added to the sca.cfg at the end #!ifdef WITH_SCA event_route[tm:local-request] { if (is_method("NOTIFY")) { record_route(); } } #!endif Seems to

Re: [sr-dev] [kamailio/kamailio] sca: implement db_mode only (#781)

Any thoughts @TheGrandWazoo ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/781#issuecomment-256940663___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

@miconda any suggestion ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/837#issuecomment-256940541___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

Ok, I will step away then and you can remove my pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

sipcapture is using the HEPv3 protocol and it can encapsulate non SIP payloads (e.g. M2UA+MTP+ISUP). This is a first implementation/try and only supports M2UA/ITU MTP/ITU ISUP. ISUP is converted from the wire message to a semi-parsed (some fields are extracted but not all) JSON object and then

[sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

This can be used with sipcapture and begings with M2UA and ISUP support. More SIGTRAN (M3UA, SUA) support is planned and maybe TCAP/MAP in the future. The ISUP message format depends on the specific message so I have exported a Smalltalk ITU ISUP model to C to avoid manual errors. You can view,

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

Yes, I'm touching it and I already planned #781 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/835#issuecomment-256940097___ sr-dev

Re: [sr-dev] [kamailio/kamailio] sipcapture: Terminate the log line with a \n (#836)

Merged #836. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/836#event-840149576___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:61fdddf2: Merge pull request #836 from zecke/fix-sipcapture-log

Module: kamailio Branch: master Commit: 61fdddf24b639903159b4cac33a74dc5330c5c06 URL: https://github.com/kamailio/kamailio/commit/61fdddf24b639903159b4cac33a74dc5330c5c06 Author: Alexandr Dubovikov Committer: GitHub Date:

[sr-dev] [kamailio/kamailio] sipcapture: Terminate the log line with a \n (#836)

Add a newline to avoid the log of other messages starting behind the REQUEST, PRE output. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/836 -- Commit Summary -- * sipcapture: Terminate the log line with a \n -- File Changes --

Re: [sr-dev] [kamailio/kamailio] sipcapture: Terminate the log line with a \n (#836)

@adubovikov please have a look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/836#issuecomment-256938691___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

There were several commits by @linuxmaniac recently, iirc -- a git log over modules/sca should reveal more accurately who worked lately on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

Is there a new maintainer on the project? I has not been touched in so long that I thought I was t he only one looking at it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

@TheGrandWazoo pushed 1 commit. f523d45 Revert "sca: sca_call_info.c: Remove redundant code" -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] git:master:8ed8d834: db_postgres: safety check of str buffer pointer before writing

Module: kamailio Branch: master Commit: 8ed8d8349dad1e2abd2ac026b4540e9a296c866b URL: https://github.com/kamailio/kamailio/commit/8ed8d8349dad1e2abd2ac026b4540e9a296c866b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:1e2060c0: pua: one more proper propagation of ua_flags in subs_cbparam_indlg()

Module: kamailio Branch: master Commit: 1e2060c0e0aa28fc1c2129d5e5fe3e210827e850 URL: https://github.com/kamailio/kamailio/commit/1e2060c0e0aa28fc1c2129d5e5fe3e210827e850 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:62c5d0d9: pua: fix propagation of ua_flag - it is func param, not in subs

Module: kamailio Branch: master Commit: 62c5d0d9cbd87a6b47c1a211588230ebc2652b8f URL: https://github.com/kamailio/kamailio/commit/62c5d0d9cbd87a6b47c1a211588230ebc2652b8f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:82e22fb3: pua: copy over subs flag in subscribe_cbparam()

Module: kamailio Branch: master Commit: 82e22fb36c5155d920b60e8cad689578eec8fb70 URL: https://github.com/kamailio/kamailio/commit/82e22fb36c5155d920b60e8cad689578eec8fb70 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:13ff91b1: htable: earlier init of jdoc used for dmq for proper clean on error cases

Module: kamailio Branch: master Commit: 13ff91b1955d7248f8aaaf350675275e425443dc URL: https://github.com/kamailio/kamailio/commit/13ff91b1955d7248f8aaaf350675275e425443dc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:d7431dd1: lib/srdb1: fix the memset to 0 in util function

Module: kamailio Branch: master Commit: d7431dd190bb1f4aba8e2373807047ac6fe8db90 URL: https://github.com/kamailio/kamailio/commit/d7431dd190bb1f4aba8e2373807047ac6fe8db90 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:0a6c85ff: modules: readme files regenerated - dialog ...

Module: kamailio Branch: master Commit: 0a6c85ff386ccd9c129e25bddbd1f4cafff2f014 URL: https://github.com/kamailio/kamailio/commit/0a6c85ff386ccd9c129e25bddbd1f4cafff2f014 Author: Kamailio Dev Committer: Kamailio Dev Date:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

Merged #831. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/831#event-840068364___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:1f25c84e: Merge pull request #831 from Soapnix/dlg_dmq

Module: kamailio Branch: master Commit: 1f25c84eb0145f30ab5cf9c707d05dc56ea16a61 URL: https://github.com/kamailio/kamailio/commit/1f25c84eb0145f30ab5cf9c707d05dc56ea16a61 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2016-10-28T15:48:28+02:00

Re: [sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

The PR cannot be merged because it has a conflict on modules/sca/sca_call_info.c as shown above. Can you fix it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:2ee8fef9: Merge pull request #830 from tverlaan/use_default_port_on_loose_route

Module: kamailio Branch: master Commit: 2ee8fef95b3dcd4b3aa42f2068277c84fbe53bd5 URL: https://github.com/kamailio/kamailio/commit/2ee8fef95b3dcd4b3aa42f2068277c84fbe53bd5 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2016-10-28T15:44:33+02:00

[sr-dev] [kamailio/kamailio] sca: sca_call_info.c: Remove redundant code (#835)

- In reviewing the code block that I removed it is actually duplicated in the sca_create_cononical_aor_for_ua() function which is called from sca_create_canonical_aor() which is called inside this 'if' block, so why do it twice. The function sca_get_msg_contact_uri() is also called in

Re: [sr-dev] [kamailio/kamailio] rr: default to port 5060 if port is omitted in route header (#830)

Yes that is correct. You're right about the protocol. I'll add another check for that. I'm curious if `record_route()` adds port 5061 or omits that as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

@Soapnix pushed 1 commit. 586fe44 dialog: removing unused DMQ variables -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

i think in this case the kamailio does not need to change the From Header at all. But for any reasons i compares old with new URI (according the code) During this the kamailio changes the From header to this: ```

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

Of courese not. Do not get me wrong. dlg_dmq works proprely, we double check they funcs and stability before I write for you. I'm already have a commit, which removes those two unused variables. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

The design of uac_replace_from() with record-route parameters is expecting that From/To headers are not changed. If that is done, then the endpoint is supporting the rfc3261 and restore should not be needed - e.g., change only for the initial invite and for the rest change the from/to to

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

So, you say they are not needed for the new functionality to work properly, right? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

We are glad to help improving kamailio. Our company is very interested in this feature (and some other - now troubleshooting dmq_usrloc). Yeah, I'm so sorry - I missed this variables during last code clean - fuction which use them was removed. -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] dialog: adding dialog replication via DMQ (#831)

Thanks, useful patch! One thing, two new global variables are defined, exported as module parameters, but they are not actually used: ``` int dlg_id_offset = 1; int dlg_id_increment = 1; ``` By name, I guess they are intended to be used for dialog id generation, but no code or docs related to

Re: [sr-dev] [kamailio/kamailio] rr: default to port 5060 if port is omitted in route header (#830)

For proper clarification -- so if the port is not present, then the match is made on IP and it may select a socket that has that ip but at different port. Right? That's indeed something to be fixed, however, i think that when protocol is tls (and maybe wss), then the 5061 port should be tried.

Re: [sr-dev] [kamailio/kamailio] pv: Use memcpy to copy len bytes instead of strcpy (#832)

Lovely! thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/832#issuecomment-256886916___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] Presence: Fix startup inconsistency in presentity hash table (#809)

@phil-lavin wondering if you got any chance to test this one in order to merge or not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pv: Use memcpy to copy len bytes instead of strcpy (#832)

And I see that the patch is actually for the pv module, it looks ok, I will merge it, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pv: Use memcpy to copy len bytes instead of strcpy (#832)

Merged #832. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/832#event-839840667___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:43871e4a: Merge pull request #832 from zecke/pv/use-memcpy-for-bytes

Module: kamailio Branch: master Commit: 43871e4a81afc2ee1ce43b8224809dc11fe61c37 URL: https://github.com/kamailio/kamailio/commit/43871e4a81afc2ee1ce43b8224809dc11fe61c37 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2016-10-28T12:04:45+02:00

Re: [sr-dev] [kamailio/kamailio] pv: Use memcpy to copy len bytes instead of strcpy (#832)

If binary data needs to be copied over, then memcpy should be used, indeed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: