Re: [sr-dev] [kamailio/kamailio] compiler warnings when compiling core/cfg/cfg_ctx.c (#1004)

Daniel-Constantin Mierla writes: > I just did a test again, Debian Jessie, -Wall is there, the result > doesn't show any warning like you report. It is just make as we have > it default in the Makefiles: I don't get any warnings either if I run the same command as you:

Re: [sr-dev] [kamailio/kamailio] compiler warnings when compiling core/cfg/cfg_ctx.c (#1004)

I just did a test again, Debian Jessie, -Wall is there, the result doesn't show any warning like you report. It is just make as we have it default in the Makefiles: ``` kamailio-dev$ make Q=0 make -C src/ make[1]: Entering directory '/home/porto/work/sip/esr/kamailio-dev/src' Makefile.defs defs

[sr-dev] [kamailio/kamailio] compiler warnings when compiling core/cfg/cfg_ctx.c (#1004)

On Debian Jessie, I get the warnings below when compiling core/cfg/cfg_ctx.c of Kamailio 5.0. If I remove -Wall, the warnings do not show up, but that is not a solution. -- Juha -- gcc -funroll-loops -Wcast-align -m64

Re: [sr-dev] [kamailio/kamailio] presense memory leak (#1001)

Closed #1001. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1001#event-969700055___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] presense memory leak (#1001)

thanks! now it works correctly -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1001#issuecomment-281164278___ sr-dev mailing list

[sr-dev] git:master:504699b6: pua_usrloc: free memory in case of failire in pua send_publish()

Module: kamailio Branch: master Commit: 504699b6c2f34fbf7db02f57909eefdffc6b8180 URL: https://github.com/kamailio/kamailio/commit/504699b6c2f34fbf7db02f57909eefdffc6b8180 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:c027c6d3: pua_usrloc: removed old svn ids

Module: kamailio Branch: master Commit: c027c6d32f1c0add72ab00c14885d46bd1b7d485 URL: https://github.com/kamailio/kamailio/commit/c027c6d32f1c0add72ab00c14885d46bd1b7d485 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] presense memory leak (#1001)

Do you get error messages in the syslog containing next string? ``` ... failed sending publish for ul event ... ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

Closed #1002. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1002#event-969624618___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

@miconda I found a simple way to get the value of the X-Forwarded-For header without changing the code in the websocket module. I thought about this after reading again the comment for Juha. I'm retrieving the X-Forwarded-For header in the event:xhttp and use htable to track the conid

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

tamiel commented on this pull request. > + + if ((wsc = wsconn_get(msg->rcv.proto_reserved1)) == NULL) { + LM_ERR("$ws_real_src_ip cannot retrieve websocket connection\n"); + return pv_get_null(msg, param, res); + } + + wscid = wsc->id; + +

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

tamiel commented on this pull request. > + if (wsc->real_src_ip[0] == 0) { + wsconn_put(wsc); + LM_DBG("$ws_real_src_ip ws_conid %d real_src_ip is not set\n", wscid); + return pv_get_null(msg, param, res); + } + +

Re: [sr-dev] [kamailio/kamailio] rtpproxy: ice_candidate_priority_avp has missleading documentation (#1003)

The lines from 2323 to 2337 shows to me that internal the 0 is used for disabling the feature if no avp is set. https://github.com/kamailio/kamailio/blob/master/src/modules/rtpproxy/rtpproxy.c#L2323-L2337 So the check could be changed to: `ice_candidate_priority_val.n < 0 ||

Re: [sr-dev] [kamailio/kamailio] presense memory leak (#1001)

> @snen maybe it is not a leak, but a use of large memory . it is possible of course, so it is not leak but logic issue This process is sip worker. 1. start kamailio with "m64 -M4" (children=2) 2. check current pkg

Re: [sr-dev] [kamailio/kamailio] rtpproxy: ice_candidate_priority_avp has missleading documentation (#1003)

Quick look into the code and the valid values seems to be only 1 or 2. I guess the docs needs to be updated to reflect it. Maybe the dev that added the feature can comment more. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[sr-dev] git:master:304d1cf1: ndb_redis: export functions via inter-module api

Module: kamailio Branch: master Commit: 304d1cf1babdb6925731f6974edf84d3796753c5 URL: https://github.com/kamailio/kamailio/commit/304d1cf1babdb6925731f6974edf84d3796753c5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] [kamailio/kamailio] rtpproxy: ice_candidate_priority_avp has missleading documentation (#1003)

### Description Dokumentation says: ``` If specified and if value of the avp value is not 0, rtpproxy_manage function adds ICE relay candidate attributes to sdp stream(s) containing ICE candidate attributes. ``` I would read it as, if the avp is set and the value is 0 no ICE relay candidate

[sr-dev] git:master:9ac5de5e: ndb_redis: removed svn ids

Module: kamailio Branch: master Commit: 9ac5de5e1d8bec9efa3c7325200fda69b3d2e3e9 URL: https://github.com/kamailio/kamailio/commit/9ac5de5e1d8bec9efa3c7325200fda69b3d2e3e9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:12a93645: tm: funcs - updated log messages to new macros

Module: kamailio Branch: master Commit: 12a9364526053734f97792d540503d9b66e4b85b URL: https://github.com/kamailio/kamailio/commit/12a9364526053734f97792d540503d9b66e4b85b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] ucontacts in shared memory even on DB_ONLY (#997)

They will be merged (or fixed in another way) and backported before release. But I didn't have the time to look properly at the commit in PR. I saw you do copy of the structure content, but then the backup variable is declared also static, meaning it is safe for one more layer ... but probably

Re: [sr-dev] [kamailio/kamailio] ucontacts in shared memory even on DB_ONLY (#997)

@miconda should I merge both PRs? Can I backport them to 5.0 before the release? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:4020ced0: kamctl: regenerated the dbschema scripts

Module: kamailio Branch: master Commit: 4020ced0d5802da0bc90114c885a8449c6f83607 URL: https://github.com/kamailio/kamailio/commit/4020ced0d5802da0bc90114c885a8449c6f83607 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] Releasing Kamailio v5.0.0

Hello, I am considering to release Kamailio v5.0.0 at the beginning of next week, depending how things evolve in the next days, either on Monday, Feb 27, or Tuesday, Feb 28. I haven't noticed any new issues specific for the new features added for 5.0 lately, so it looks pretty good so far. If

Re: [sr-dev] Cleaning wiki accounts

Hello, the cleanup was performed several days ago. If any good account was hit, just let me know or just create a new account. Anyhow, meanwhile, couple of new spam accounts were made, so I am considering futher actions in the near future: - accept new wiki accounts only with admin/moderator

Re: [sr-dev] Fwd: Kamailio 4.3.x location_attrs update issue

Hello, indeed, the location_attrs should be deleted along with the contact records. What db_mode value you use for usrloc module? Cheers, Daniel On 20/02/2017 10:17, Mridul B wrote: > Hi, > > We've noticed a case where the *location_attrs* table isn't updated > when there's an unexpected

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

Backporting of new features in stable branches is not allowed, unless it is actually a fix or solving major security needs. Others can comment their opinion. One more or less cosmetic opinion, I would make a class of variables, $ws(name), so if the future new fields can be added to it (like

Re: [sr-dev] [kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

miconda commented on this pull request. > + + if ((wsc = wsconn_get(msg->rcv.proto_reserved1)) == NULL) { + LM_ERR("$ws_real_src_ip cannot retrieve websocket connection\n"); + return pv_get_null(msg, param, res); + } + + wscid = wsc->id; + +

[sr-dev] Fwd: Kamailio 4.3.x location_attrs update issue

Hi, We've noticed a case where the *location_attrs* table isn't updated when there's an unexpected shutdown of a SIP device (here there'll be no REGISTER message sent with expires=0). We're using Kamailio v4.3.x When the SIP device shuts down ungracefully. The location table is updated using