Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-16 Thread Joshua Colp
On Mon, Jan 16, 2017, at 10:26 AM, Daniel-Constantin Mierla wrote: > > > On 16/01/2017 09:33, Daniel-Constantin Mierla wrote: > > > > On 16/01/2017 00:48, Joshua Colp wrote: > >> On Sat, Jan 14, 2017, at 06:39 PM, Joshua Colp wrote: > >>> On Sat, Ja

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-15 Thread Joshua Colp
On Sat, Jan 14, 2017, at 06:39 PM, Joshua Colp wrote: > On Sat, Jan 14, 2017, at 06:20 PM, Daniel-Constantin Mierla wrote: > > If you want a solution to avoid the issue via config: in the > > request_route, store the RPID in an avp and update the acc parameter to > >

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-14 Thread Joshua Colp
s and it is freeing only those > headers. Thanks for the configuration suggestion Daniel! I'm going to try that as it should do the job. I'll follow up if I encounter the same issue despite the configuration change (which shouldn't be possible - but I don't know if I'm that lucky). Cheers, --

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-14 Thread Joshua Colp
On Sat, Jan 14, 2017, at 04:09 PM, Joshua Colp wrote: > On Sat, Jan 14, 2017, at 02:43 PM, Joshua Colp wrote: > > > > > Testing is in progress and so far so good. I do think the code in > > acc_onreply that cleans up the parsed header is not correct, though. > &g

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-14 Thread Joshua Colp
On Sat, Jan 14, 2017, at 02:43 PM, Joshua Colp wrote: > > Testing is in progress and so far so good. I do think the code in > acc_onreply that cleans up the parsed header is not correct, though. > It's referencing the shared memory memory instead of the locally scoped > one w

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-14 Thread Joshua Colp
k the code in acc_onreply that cleans up the parsed header is not correct, though. It's referencing the shared memory memory instead of the locally scoped one where any parsed headers (should) live. -- Joshua Colp Digium, Inc. | Senior Software Developer 44

Re: [sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-14 Thread Joshua Colp
> a seg fault as expected. Thanks Daniel! Based on some logging I added I can confirm that the parsing did happen in another process, so I think you are right that this will fix the issue. I'm going to work on backporting the change and testing it out. Cheers, -- Joshua Colp Digium, Inc. | Senio

[sr-dev] Remote-Party-ID Parsed Header Crash

2017-01-13 Thread Joshua Colp
.len $27 = 10 Has anyone seen anything like this before or have a suggestion on where to look further? I've traced through the code in question and it all seems to be correct. Thanks a lot, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us