Updated documentation for modules who uses libcurl, regarding memory leak in
Centos 6 libcurl library.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/853
-- Commit Summary --
* Updated documentation of modules which are impacted by
Hi,
Sorry for false alarm. Utils module do not impact http_client, just rechecked.
http_client_query - adds user-agent header
http_connect - does NOT add user-agent header
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Actually http_connect do not add user-agent at all(in case if utils module
loaded or not), but http_client_query adds user-agent in all cases. I'm not
sure if this works as intended. Nevertheless you can find in attachment
configuration how to reproduce this issue. I would like to emphasize one
Sure, I will try to create simple configuration today and I will attach it here.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi,
I found strange bug. When I load utils and http_client modules then user-agent
are sent in http request using http_client module(http_connect funcion), but if
I do not load utils module, then user-agent is not sent anymore.
Thank you!
---
You are receiving this because you are subscribed
@@ -56,6 +56,7 @@ typedef struct {
char *cacert;
char *ciphersuites;
char *http_proxy;
+char *useragent;
unsigned int authmethod;
unsigned int http_proxy_port;
unsigned int tlsversion;
@@ -206,6 +207,7 @@ static int curL_query_url(struct sip_msg* _m, const char*
After clarification from Olle it looks like that this pull request should be
closed, cause he never intended to add header User-Agent with http_client_query
function. Meanwhile it looks like there are still bug, cause http_connect
function do not adds User-Agent header anyway.
---
You are
This commit add minor fix, so user-agent header now is added for HTTP requests.
I'm not a C programmer, but this fix makes it work. I highly recommend to
review this fix. :)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/674
--
Historically we are using this module and we need possibility to add user-agent
header for HTTP requests, if you plan to remove this module and you think that
nobody needs such functionality, then probably we can drop this pull request.
Thank you!
---
You are receiving this because you are
I'm very sorry, this is my first commit, so I might ask not so very clever
questions. :)
I tried to use same logic for user_agent as for xcap_table, which is string.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
following commit will introduce possibility to add User-Agent header
for http_query by adding utils module parameter - user_agent,
if none is defined then no User-Agent header is added.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/670
11 matches
Mail list logo
