Re: [sr-dev] [kamailio/kamailio] Free database column name as part of database result cleanup (#611)

2016-06-03 Thread William King
I'll update the patch and open a new PR when it's ready. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/611#issuecomment-223570443___ sr-d

Re: [sr-dev] [kamailio/kamailio] Free database column name as part of database result cleanup (#611)

2016-06-03 Thread William King
Closed #611. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/611#event-681089393___ sr-dev mailing list sr-dev@lists.sip-router.org http://

Re: [sr-dev] [kamailio/kamailio] change answered elsewhere to call completed elsewhere (#610)

2016-05-11 Thread William King
@miconda I can update the patch. @oej Yes, there are a few mobile implementations that strstr match several sip messages to avoid fully parsing them. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kama

Re: [sr-dev] [kamailio/kamailio] Free database column name as part of database result cleanup (#611)

2016-05-11 Thread William King
@miconda Makes sense. No need to malloc/free if it isn't absolutely required for a commonly used code path. I'll look over the patch and see if I can see a better approach(using flags to signify malloced pointer). One of the larger concerns here was that clang's address sanitizer was pointing ou

[sr-dev] [kamailio/kamailio] Free database column name as part of database result cleanup (#611)

2016-05-10 Thread William King
The column name is currently not free'd. Some db bankends copy this data so that memory is leaked. Some store internal database pointers and those shouldn't be free'd. One returns a pointer to a stack variable which shouldn't be done. The patch cleans up all db backends to copy the column name and

[sr-dev] [kamailio/kamailio] change answered elsewhere to call completed elsewhere (#610)

2016-05-10 Thread William King
"Call completed elsewhere", RFC3326, defines this as the string to send. Author: Frank Carmickle You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/610 -- Commit Summary -- * change answered elsewhere to call completed elsewhere -- Fi