Re: [sr-dev] [kamailio/kamailio] textops: get_body_part doesn't detect multipart headers ending properly (#564)

2016-04-23 Thread foucse
I finally had some time to look into the source code, the issue comes from the file textops/textops.c:2071 ```C while (find_line_start("Content-Type: ", 14, , )) { end = start + 14; len = len - 14; if (len > (content_type.len + 2))

Re: [sr-dev] [kamailio/kamailio] textops: get_body_part doesn't detect multipart headers ending properly (#564)

2016-04-11 Thread foucse
Hi, Here is one example, the XML body is not standard (yet), so I had to remove it. Content-Length is to be checked ``` 2016/04/11 16:38:17.645936 192.168.2.2:5062 -> 192.168.100.1:5060 INVITE sip:b...@example.com SIP/2.0 via: SIP/2.0/UDP 192.168.2.2:5062;branch=z9hG4bK-18344-1-10 From: "alice"

[sr-dev] [kamailio/kamailio] textops: get_body_part doesn't detect multipart headers ending (#564)

2016-04-11 Thread foucse
When I use get_body_part on a multipart body, it doesn't detect properly the ending of multipart headers: For instance in: ``` --vvemeemm0wqr7ayc5h367f3v8e66mc9t Content-Type: application/sdp Content-Length: 479 v=0 o=- 3669362310 3669362310 IN IP4 192.168.2.4 [...] ``` "Content-Length: 479"

Re: [sr-dev] [kamailio/kamailio] sdpops: Parsing of a multipart INVITE body (SDP + an unknown MIME type) (#561)

2016-04-05 Thread foucse
Closed #561. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/561#event-615040164___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] sdpops: Parsing of a multipart INVITE body (SDP + an unknown MIME type) (#561)

2016-04-05 Thread foucse
Hi Daniel, Yes, it works with "isalnum" in my test, but another define, just below: is_char_equal is also using "isalpha" but I don't know if it needs modification: ```C #define is_char_equal(_c_,_cs_) \ ( (isalpha((int)_c_)?(((_c_)|0x20)==(_cs_)):((_c_)==(_cs_)))==1 ) ``` --- You are

Re: [sr-dev] [kamailio/kamailio] sdpops: Parsing of a multipart INVITE body (SDP + an unknown MIME type) (#561)

2016-04-04 Thread foucse
I have taken some time to investigate this issue and the problem is that you use the "isalpha" function in the is_mime_char routine: ```C #define is_mime_char(_c_) \ (isalpha((int)_c_) || (_c_)=='-' || (_c_)=='+' || (_c_)=='.' || (_c_)=='_') ``` But a MIME type can have digits in it

[sr-dev] [kamailio/kamailio] sdpops: Parsing of a multipart INVITE body (SDP + an unknown MIME type) (#561)

2016-04-04 Thread foucse
``` version: kamailio 5.0.0-dev0 (i386/linux) 00f108-dirty flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,

Re: [sr-dev] [kamailio] Presence module should support a 32bit unsigned expire value (#521)

2016-03-03 Thread foucse
Hi Daniel, ``` version: kamailio 4.4.0-pre1 (i386/linux) c5289e-dirty flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,

[sr-dev] [kamailio] Presence module should support a 32bit unsigned expire value (#521)

2016-02-29 Thread foucse
Hello, ``` kamailio -v version: kamailio 4.4.0-pre0 (i386/linux) f39d14-dirty flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,

Re: [sr-dev] [kamailio] Merge pull request #459 from kamailio/lazedo/db_text_replace (d0372a1)

2016-01-04 Thread foucse
Conflicts ! Auto-merging modules/presence/notify.c CONFLICT (add/add): Merge conflict in modules/presence/notify.c Auto-merging modules/db_text/dbtext.h CONFLICT (add/add): Merge conflict in modules/db_text/dbtext.h Auto-merging modules/db_text/dbtext.c CONFLICT (add/add): Merge conflict in

Re: [sr-dev] [kamailio] debugger module: Kamailio crashes when shutting down (#446)

2015-12-16 Thread foucse
Hello smititelu, ``` version: kamailio 4.4.0-dev7 (i386/linux) 645838-dirty flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,

[sr-dev] [kamailio] debugger module: (#446)

2015-12-16 Thread foucse
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/446___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] debugger module: Kamailio crashes when shutting down (#446)

2015-12-16 Thread foucse
Yes I forgot to mention those, they were in my shared configuration --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/446#issuecomment-165052305___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] Bad usage of presence, xcap server and pidf-manipulation makes Kamailio crash (#441)

2015-12-14 Thread foucse
Hello Daniel, Looks like it is solved, not crashing anymore: ``` [...] Dec 14 16:58:25 banshee1 kamailio-0[16952]: INFO:

[sr-dev] [kamailio] Bad usage of presence, xcap server and pidf-manipulation makes Kamailio crash (#441)

2015-12-14 Thread foucse
Hi everyone, ``` version: kamailio 440-dev7 (i386/linux) c73b9c-dirty flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,

Re: [sr-dev] [kamailio] kamailio 4.4.0-dev5 crashes using pua + pua_reginfo (#377)

2015-10-26 Thread foucse
Hello Daniel, I have done some extensive testing this time to be sure and it looks like Kamailio doesn't crash anymore, which is good. So issue solved, thank you. I have only these errors in logs, which are normal and I think I can handle them: ``` Oct 26 09:48:51 system

Re: [sr-dev] [kamailio] kamailio 4.4.0-dev5 crashes using pua + pua_reginfo (#377)

2015-10-23 Thread foucse
I managed to catch the issue again on another test. Same backtrace: ``` Program terminated with signal 11, Segmentation fault. #0 0xb64c24c0 in get_hash1_raw () at ../../hashes.h:109 109 hash_update_str(s, s+len, p, v, h); #0 0xb64c24c0 in get_hash1_raw () at ../../hashes.h:109 #1

Re: [sr-dev] [kamailio] kamailio 4.4.0-dev5 crashes using pua + pua_reginfo (#377)

2015-10-23 Thread foucse
Ok, I recompiled Kamailio with all debug symbols, here is the full backtrace of another test run, same crash, same log messages: ``` Program terminated with signal 11, Segmentation fault. #0 0xb652b2e4 in get_hash1_raw (s=0x0, len=0) at ../../hashes.h:109 109 hash_update_str(s,

Re: [sr-dev] [kamailio] kamailio 4.4.0-dev5 crashes using pua + pua_reginfo (#377)

2015-10-22 Thread foucse
Issue maybe related to DBMS, no segfault with MySQL and the same scenario. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/377#issuecomment-150247458___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] [kamailio] kamailio 4.4.0-dev5 crashes using pua + pua_reginfo (#377)

2015-10-22 Thread foucse
``` version: kamailio 4.4.0-dev5 (i386/linux) 9251a6 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE,

Re: [sr-dev] [kamailio] RLS : Full state NOTIFY should be produced on first subscription (#276)

2015-08-07 Thread foucse
Well replacing this : ```C++ if (dbmode != RLS_DB_ONLY) ``` By this : ```C++ if(get_to(msg)-tag_value.s==NULL || get_to(msg)-tag_value.len==0) ``` Which is a detection of initial transaction if I'am understanding well (no to tag). There is such a detection upper in the code (line 610-611) :

[sr-dev] [kamailio] RLS : Full state NOTIFY should be produced on first subscription (#276)

2015-08-06 Thread foucse
Scenario : Loading a rls-services XML file to ad...@example.com (XCAP HTTP PUT) : ```xml ?xml version=1.0 encoding=UTF-8? rls-services service uri=sip:poi...@example.com list name=points entry uri=sip:poi...@example.com display-namePoint 1/display-name

Re: [sr-dev] [kamailio] Proposed: Consolidate example kamailio.cfg files (#209)

2015-08-06 Thread foucse
IMHO, configuration file consolidation in one single file will make the learning curve much steeper for beginners and newcomers. I found it rather difficult to read and understand one big file with alot of #!ifdef blocks. Multiple, but simple and very specialized configuration files have the

[sr-dev] [kamailio] Update hash.h (#270)

2015-07-30 Thread foucse
presence;winfo - presence.winfo just a typo, imho You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/270 -- Commit Summary -- * Update hash.h -- File Changes -- M modules/pua/hash.h (2) -- Patch Links --