Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Giacomo Vacca
Merged #1006. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1006#event-974671990___ sr-dev mailing list sr-dev@lists.sip-router.org http:

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Alexandr Dubovikov
looks very good for me! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1006#issuecomment-282032780___ sr-dev mailing list sr-dev@lists.sip

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Giacomo Vacca
I'll leave some time for @adubovikov to read/review, then I'll proceed with merge and backport. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1006#issuecomment-281999002___

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Daniel-Constantin Mierla
@giavac welcome, thanks for all your contributions! Now you should be able to merge the PR by yourself and commit directly (if you want that instead of PR -- that should be more handy for backports at least). -- You are receiving this because you are subscribed to this thread. Reply to this ema

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Giacomo Vacca
Thanks Daniel -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1006#issuecomment-281987562___ sr-dev mailing list sr-dev@lists.sip-router.or

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Daniel-Constantin Mierla
Thanks! Can be merged and backported to branch 5.0 as it fixes the compatibility with HEPv3. Note: I invited @giavac to join developers team, given his many contributions over the time -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Camille Oudot
camilleoudot approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1006#pullrequestreview-23455735___ sr-dev mail

[sr-dev] [kamailio/kamailio] Add HEPv3 support to siptrace (#1006)

2017-02-23 Thread Giacomo Vacca
This PR allows kamailio to duplicate messages to Homer using HEPv3 [0]. An optional correlation ID (which can contain PVs) can be passed to `sip_trace()`. The packing macros in hep.h are authored by @camilleoudot and I've just used them. An example of formats: ``` modparam("siptrace", "duplica