Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Fabrice Fontaine
OK thanks, I will close this PR and create 2 PRs: one for kmini and another for kpcre -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Fabrice Fontaine
Closed #901. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/901#event-922281331___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Daniel-Constantin Mierla
Yes, it's ok to add new groups that can help in what you need. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Fabrice Fontaine
buildroot does not use deb or rpm specs from kamailio tree. To integrate a package to buildroot, I have to define a .mk that explain how to download the source from github and selects the appropriate modules depending on what packages were selected by the user. For example, if the package

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Daniel-Constantin Mierla
@ffontaine - is the buildroot using deb or rpm specs from kamailio tree? There is another set of groups, which doesn't have 'k' as prefix of the last word in the name -- for example, there is module_group_standard and module_group_kstandard. The module_group_k... were intended for packaging,

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Fabrice Fontaine
My goal was to integrate kamailio into buildroot (https://buildroot.org/). buildroot allows the user to create its own embedded linux system and the pcre package is not always selected by the user. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-13 Thread Victor Seva
I do believe pcre is quite common and we can live with it on kstandard -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-10 Thread Daniel-Constantin Mierla
Maybe @linuxmaniac can have an additional opinion on this topic. There is a conflict already due to other changes, so cannot be just merged any longer, but the question of this PR is whether to to create or not a pcre group. -- You are receiving this because you are subscribed to this thread.

Re: [sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2017-01-02 Thread Daniel-Constantin Mierla
I think this was added because of lcr module to be included in the main package (e.g., deb) and pcre being very common. If many people want to change this and have a dedicated group, then comment here. -- You are receiving this because you are subscribed to this thread. Reply to this email

[sr-dev] [kamailio/kamailio] Add kpcre group (#901)

2016-12-23 Thread Fabrice Fontaine
Previously pcre was included into kstandard but pcre module depends on pcre library so create its own group and remove it from kstandard as standard modules should have no internal/external compile or link dependencies Signed-off-by: Fabrice Fontaine You can view,