Re: [sr-dev] [kamailio/kamailio] Makefile.defs: default locks review (#1035)

2017-03-16 Thread Daniel-Constantin Mierla
Very likely the ports system set the ARCH variable in environment or command line for building kamailio, that's why a simple assignment didn't work. Also, the Makefile should have done the amd64=>x86_64 even without my changes if the ARCH was not enforced from outside. -- You are receiving

Re: [sr-dev] [kamailio/kamailio] Makefile.defs: default locks review (#1035)

2017-03-16 Thread SubnetsRU
Yes, now arch changed properly. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1035#issuecomment-286990909___ sr-dev mailing

Re: [sr-dev] [kamailio/kamailio] Makefile.defs: default locks review (#1035)

2017-03-15 Thread SubnetsRU
There isn't enough again your last modification Makefile.defs: it doesn't work with ports framework: I've add info string to your "hack": ``` ifeq ($(ARCH), amd64) ARCH=x86_64 $(info switch target architecture from amd64 to <$(ARCH)>) endif ``` and I've got: `switch target architecture

Re: [sr-dev] [kamailio/kamailio] Makefile.defs: default locks review (#1035)

2017-03-15 Thread SubnetsRU
There is not enough add arch to Makefile.defs, because build aborts with error: ``` gmake[2]: Entering directory '/usr/ports/net/kamailio/work/kamailio-4.4.5' CC (gcc) [kamailio] nonsip_hooks.o In file included from parser/../mem/../lock_ops.h:92:0, from

[sr-dev] [kamailio/kamailio] Makefile.defs: default locks review (#1035)

2017-03-15 Thread Daniel-Constantin Mierla
Apparently the default locks are set to PTHREAD mutex, when the architecture is not handled explicitely. It should be reviewed and eventually switch to standard POSIX, they should work everywhere while PTHREAD are targeting threads and work only in few cases for processes. -- You are