Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

Merged #1024. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1024#event-1002969820___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

Thanks, it can be merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1024#issuecomment-287086658___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

Just updated the PR with your suggestion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1024#issuecomment-287024005___ sr-dev mailing

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

@grumvalski pushed 1 commit. d2c3f38 core: compile by default support for SO_REUSEPORT when available on the OS -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

I think ifdef can be used to check if SO_REUSEPORT is defined, on macos: ``` /usr/include/sys/socket.h:136:#define SO_REUSEPORT0x0200 /* allow local address & port reuse */ ``` On Linux: ``` /usr/include/asm-generic/socket.h:25:#define SO_REUSEPORT 15 ``` So it appears it

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

Thanks for the feedback Daniel. About the first point, I think that we still need the #define because if SO_REUSEPORT is not defined for the running OS the compilation will fail. As far as I know the option is currently supported in FreeBSD/OpenBSD/NetBSD/Mac OSX, not in Solaris. Maybe we could

Re: [sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

The patch is not that complex, so it can be merged, but I think there are few things to add afterwards: * find a way to have the option compiled always and enabled if available. Very unlikely someone will re-compile with other define options. With a quick search, maybe uname()

[sr-dev] [kamailio/kamailio] core: enable reuse of tcp sockets (#1024)

As discussed on the mailing list and at FOSDEM this is a PR to start the discussion on the support of SO_REUSEPORT. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1024 -- Commit Summary -- * core: enable reuse of tcp sockets --