Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

Merged #724. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/724#event-762634127___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

Yes, all good here. #726 has been running good too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/724#issuecomment-239379162___ sr-dev

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

Hi Daniel, no problem at all. Whenever you can. It's been running in production for a few days now, along with #726. We use BLF extremely heavily and no further problems have been seen by customers. That said, give it another week or so such that we can be sure the memory footprint is

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

Thanks! I will review and merge asap -- just that these days I am traveling with limited available time and the pull request is consistent. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

@phil-lavin pushed 1 commit. 3b206c8 presence: log when presentity is deleted due to already existing --- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

Found the leak with `valgrind`. Added as a second commit. Going to run in production for a few days and see if memory stays stable. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

@phil-lavin pushed 1 commit. 3c09579 presence: fix memory leak introduced by last commit --- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

This may have a memory leak... Going to investigate more so hold off on merging for now. If anyone can spot it, free beer may be on offer. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] presence: Always check if a record exists for this dialog before inserting (#724)

- The presence implementation is a little dubious, to say the least. It probably wants re-writing at some stage. However, this fixes a race condition that could have a number of causes in which the PUA is unaware of the eTag at the point it sends the PUBLISH. The mechanism is such that the