Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-28 Thread Olle E. Johansson
Where you using the old http_client_query function? I noticed it doesn't work. For me, the other function used the default_proxy. I committed a patch to trunk, please test again. Added your debugging too so we see the same things. --- You are receiving this because you are subscribed to this

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-28 Thread Olle E. Johansson
Reopened #541. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#event-605022110___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-24 Thread Olle E. Johansson
Ok, will check again. Thanks for testing. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#issuecomment-200873850___ sr-dev mailing

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-24 Thread filiplx
Did not manage to get default proxy to work. I used the same config as I used with my home-brewed version of http_client. The API calls work, it's just the proxy config that isn't applied. # # Config # #!define API_SERVER_A "apiA=>http://name:p...@api01.host.com; #!define API_SERVER_B

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-22 Thread Olle E. Johansson
Closed #541. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#event-598238980___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-22 Thread Olle E. Johansson
Committed to 4.4. Please open a new issue if you find a problem. Thanks for your contribution! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-19 Thread Olle E. Johansson
@filiplx If you have some time to test, I would really appreciate feedback. Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-19 Thread Olle E. Johansson
I have pushed a commit to trunk, please test. Will write docs soon. Basically you can add "httpproxy" in the external configuration file - per connection - or default in modparams. Will commit to 4.4 too. --- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-19 Thread filiplx
I will try to test it today. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#issuecomment-198266536___ sr-dev mailing list

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-15 Thread Olle E. Johansson
Ok, this took me on a path longer than expected. We use the defaults when we create the connection objects, not in this part of the code. I've modified the code to handle proxy per connection in the text config and with the default settings in modparams. It resulted in a somewhat larger patch

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-14 Thread Olle E. Johansson
I notice that I had a setting for this in the code, but it is not mentioned in the documentation. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#issuecomment-196177840___ sr-dev mailing list

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-13 Thread Olle E. Johansson
We need to add to the TODO to add proxy support on a per connection basis --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#issuecomment-195935713___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-13 Thread Olle E. Johansson
Great patch, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/541#issuecomment-195935616___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-11 Thread Daniel-Constantin Mierla
You can make a pull request with the changes that are needed, in this way it can be reviewed easier and merged if the developer doesn't discover anything wrong. --- Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio] module http_client - support setting default http proxy (#541)

2016-03-11 Thread filiplx
The code on master branch is _almost_ done. What's missing is this: /** * functions.c * curL_query_url() */ if (default_http_proxy != NULL) { res |= curl_easy_setopt(curl, CURLOPT_PROXY, default_http_proxy); } if (default_http_proxy_port > 0) { res |=